From: Greg KH <gregkh@linuxfoundation.org>
To: christian.koenig@amd.com
Cc: Alex Deucher <alexdeucher@gmail.com>,
Deepak R Varma <mh12gx2825@gmail.com>,
David Airlie <airlied@linux.ie>,
LKML <linux-kernel@vger.kernel.org>,
Maling list - DRI developers <dri-devel@lists.freedesktop.org>,
Melissa Wen <melissa.srw@gmail.com>,
amd-gfx list <amd-gfx@lists.freedesktop.org>,
Daniel Vetter <daniel@ffwll.ch>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
Alex Deucher <alexander.deucher@amd.com>
Subject: Re: [PATCH] drm/amdgpu: do not initialise global variables to 0 or NULL
Date: Tue, 3 Nov 2020 07:53:24 +0100 [thread overview]
Message-ID: <20201103065324.GD75930@kroah.com> (raw)
In-Reply-To: <c916ae88-5933-ab06-ad32-d87f00cac21f@gmail.com>
On Mon, Nov 02, 2020 at 09:06:21PM +0100, Christian König wrote:
> Am 02.11.20 um 20:43 schrieb Alex Deucher:
> > On Mon, Nov 2, 2020 at 1:42 PM Deepak R Varma <mh12gx2825@gmail.com> wrote:
> > > Initializing global variable to 0 or NULL is not necessary and should
> > > be avoided. Issue reported by checkpatch script as:
> > > ERROR: do not initialise globals to 0 (or NULL).
> > I agree that this is technically correct, but a lot of people don't
> > seem to know that so we get a lot of comments about this code for the
> > variables that are not explicitly set. Seems less confusing to
> > initialize them even if it not necessary. I don't have a particularly
> > strong opinion on it however.
>
> Agree with Alex.
>
> Especially for the module parameters we should have a explicit init value
> for documentation purposes, even when it is 0.
Why is this one tiny driver somehow special compared to the entire rest
of the kernel? (hint, it isn't...)
Please follow the normal coding style rules, there's no reason to ignore
them unless you like to constantly reject patches like this that get
sent to you.
thnaks,
greg k-h
next prev parent reply other threads:[~2020-11-03 6:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-02 18:41 [PATCH] drm/amdgpu: do not initialise global variables to 0 or NULL Deepak R Varma
2020-11-02 19:43 ` Alex Deucher
2020-11-02 20:06 ` Christian König
2020-11-03 6:53 ` Greg KH [this message]
2020-11-02 20:48 ` Christian König
2020-11-03 7:53 ` Greg KH
2020-11-03 8:23 ` Christian König
2020-11-03 14:50 ` Deucher, Alexander
2020-11-03 15:34 ` Greg KH
2020-11-02 20:10 ` Greg KH
2020-11-02 22:30 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201103065324.GD75930@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=alexdeucher@gmail.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=melissa.srw@gmail.com \
--cc=mh12gx2825@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).