From: Lars Poeschel <poeschel@lemonage.de>
To: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Cc: Willy Tarreau <willy@haproxy.com>,
Ksenija Stanojevic <ksenija.stanojevic@gmail.com>,
open list <linux-kernel@vger.kernel.org>,
Willy Tarreau <w@1wt.eu>
Subject: Re: [PATCH v5 02/25] auxdisplay: Introduce hd44780_common.[ch]
Date: Tue, 3 Nov 2020 09:46:10 +0100 [thread overview]
Message-ID: <20201103084610.oxfdp2665l7u3u6j@lem-wkst-02.lemonage> (raw)
In-Reply-To: <CANiq72nY2aXiTcG0=OJR4JNkY7qZU1dStfMHkbFoT5cekNRkvA@mail.gmail.com>
On Sat, Oct 31, 2020 at 10:26:30AM +0100, Miguel Ojeda wrote:
> Hi Lars,
>
> On Thu, Oct 29, 2020 at 10:57 AM <poeschel@lemonage.de> wrote:
> >
> > diff --git a/drivers/auxdisplay/Kconfig b/drivers/auxdisplay/Kconfig
> > index 81757eeded68..a56171d1a1ba 100644
> > --- a/drivers/auxdisplay/Kconfig
> > +++ b/drivers/auxdisplay/Kconfig
> > @@ -14,12 +14,31 @@ menuconfig AUXDISPLAY
> >
> > If you say N, all options in this submenu will be skipped and disabled.
> >
> > +config CHARLCD
> > + tristate "Character LCD core support" if COMPILE_TEST
> > + help
> > + This is the base system for character-based LCD displays.
> > + It makes no sense to have this alone, you select your display driver
> > + and if it needs the charlcd core, it will select it automatically.
> > + This is some character LCD core interface that multiple drivers can
> > + use.
> > +
> > +config HD44780_COMMON
> > + tristate "Common functions for HD44780 (and compatibles) LCD displays" if COMPILE_TEST
> > + help
> > + This is a module with the common symbols for HD44780 (and compatibles)
> > + displays. This is the code that multiple other modules use. It is not
> > + useful alone. If you have some sort of HD44780 compatible display,
> > + you very likely use this. It is selected automatically by selecting
> > + your concrete display.
> > +
> > if AUXDISPLAY
> >
>
> These two should be after `if AUXDISPLAY`, no? I noticed the menu is
> broken when I went to compile test this (the options appear outside
> and the auxdisplay menu is empty). Perhaps you don't use menuconfig so
> you didn't see it?
I did see it and had a look and did not spot anything obvious (to me).
So I put this aside as "This is supposed to be this way."
> Sorry I missed this in previous iterations...
No need to be sorry. In the end it's my fault. I fix this.
Regards,
Lars
next prev parent reply other threads:[~2020-11-03 8:46 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-29 9:52 [PATCH 00/25] Make charlcd device independent poeschel
2020-10-29 9:52 ` [PATCH v5 01/25] auxdisplay: Use an enum for charlcd backlight on/off ops poeschel
2020-10-29 9:57 ` [PATCH v5 02/25] auxdisplay: Introduce hd44780_common.[ch] poeschel
2020-10-29 9:57 ` [PATCH v5 03/25] auxdisplay: Move hwidth and bwidth to struct hd44780_common poeschel
2020-10-29 9:57 ` [PATCH v5 04/25] auxdisplay: Move ifwidth " poeschel
2020-10-29 9:57 ` [PATCH v5 05/25] auxdisplay: Move write_data pointer to hd44780_common poeschel
2020-10-29 9:57 ` [PATCH v5 06/25] auxdisplay: Move write_cmd pointers to hd44780 drivers poeschel
2020-10-29 9:57 ` [PATCH v5 07/25] auxdisplay: Move addr out of charlcd_priv poeschel
2020-10-29 9:57 ` [PATCH v5 08/25] auxdisplay: hd44780_common_print poeschel
2020-10-29 9:57 ` [PATCH v5 09/25] auxdisplay: provide hd44780_common_gotoxy poeschel
2020-10-29 9:57 ` [PATCH v5 10/25] auxdisplay: add home to charlcd_ops poeschel
2020-10-29 9:57 ` [PATCH v5 11/25] auxdisplay: Move clear_display to hd44780_common poeschel
2020-10-29 9:57 ` [PATCH v5 12/25] auxdisplay: make charlcd_backlight visible " poeschel
2020-10-29 9:57 ` [PATCH v5 13/25] auxdisplay: Make use of enum for backlight on / off poeschel
2020-10-29 9:57 ` [PATCH v5 14/25] auxdisplay: Move init_display to hd44780_common poeschel
2020-10-29 9:57 ` [PATCH v5 15/25] auxdisplay: implement various hd44780_common_ functions poeschel
2020-10-29 9:57 ` [PATCH v5 16/25] auxdisplay: cleanup unnecessary hd44780 code in charlcd poeschel
2020-10-29 9:57 ` [PATCH v5 17/25] auxdisplay: Move char redefine code to hd44780_common poeschel
2020-10-29 9:57 ` [PATCH v5 18/25] auxdisplay: Call charlcd_backlight in place poeschel
2020-10-29 9:57 ` [PATCH v5 19/25] auxdisplay: hd44780_common: Reduce clear_display timeout poeschel
2020-10-29 9:57 ` [PATCH v5 20/25] auxdisplay: hd44780: Remove clear_fast poeschel
2020-10-29 9:57 ` [PATCH v5 21/25] auxdisplay: charlcd: replace last device specific stuff poeschel
2020-10-29 9:57 ` [PATCH v5 22/25] auxdisplay: Change gotoxy calling interface poeschel
2020-10-29 9:57 ` [PATCH v5 23/25] auxdisplay: charlcd: Do not print chars at end of line poeschel
2020-10-31 9:18 ` Miguel Ojeda
2020-10-31 9:26 ` [PATCH v5 02/25] auxdisplay: Introduce hd44780_common.[ch] Miguel Ojeda
2020-11-03 8:46 ` Lars Poeschel [this message]
2020-10-29 10:01 ` [PATCH v5 24/25] auxdisplay: lcd2s DT binding doc poeschel
2020-10-29 10:01 ` [PATCH v5 25/25] auxdisplay: add a driver for lcd2s character display poeschel
2020-10-31 9:30 ` [PATCH 00/25] Make charlcd device independent Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201103084610.oxfdp2665l7u3u6j@lem-wkst-02.lemonage \
--to=poeschel@lemonage.de \
--cc=ksenija.stanojevic@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=w@1wt.eu \
--cc=willy@haproxy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).