* [kbuild] sound/soc/codecs/wcd934x.c:1571:9: warning: Identical condition 'ret', second condition is always false
@ 2020-11-03 10:57 Dan Carpenter
0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2020-11-03 10:57 UTC (permalink / raw)
To: kbuild, Stephen Boyd
Cc: lkp, kbuild-all, linux-kernel, Mark Brown, Arnd Bergmann
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: b7cbaf59f62f8ab8f157698f9e31642bff525bd0
commit: bbd7ffdbef6888459f301c5889f3b14ada38b913 clk: Allow the common clk framework to be selectable
compiler: ia64-linux-gcc (GCC) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
cppcheck possible warnings: (new ones prefixed by >>, may not real problems)
>> sound/soc/codecs/wcd934x.c:1571:9: warning: Identical condition 'ret', second condition is always false [identicalConditionAfterEarlyExit]
return ret;
^
sound/soc/codecs/wcd934x.c:1568:6: note: first condition
if (ret)
^
sound/soc/codecs/wcd934x.c:1571:9: note: second condition
return ret;
^
vim +/ret +1571 sound/soc/codecs/wcd934x.c
a61f3b4f476eceb Srinivas Kandagatla 2019-12-19 1561
a61f3b4f476eceb Srinivas Kandagatla 2019-12-19 1562 ret = wcd934x_set_prim_interpolator_rate(dai, (u8)rate_val,
a61f3b4f476eceb Srinivas Kandagatla 2019-12-19 1563 sample_rate);
a61f3b4f476eceb Srinivas Kandagatla 2019-12-19 1564 if (ret)
a61f3b4f476eceb Srinivas Kandagatla 2019-12-19 1565 return ret;
a61f3b4f476eceb Srinivas Kandagatla 2019-12-19 1566 ret = wcd934x_set_mix_interpolator_rate(dai, (u8)rate_val,
a61f3b4f476eceb Srinivas Kandagatla 2019-12-19 1567 sample_rate);
a61f3b4f476eceb Srinivas Kandagatla 2019-12-19 1568 if (ret)
a61f3b4f476eceb Srinivas Kandagatla 2019-12-19 1569 return ret;
a61f3b4f476eceb Srinivas Kandagatla 2019-12-19 1570
a61f3b4f476eceb Srinivas Kandagatla 2019-12-19 @1571 return ret;
^^^^^^^^^^^
Just "return 0;"
a61f3b4f476eceb Srinivas Kandagatla 2019-12-19 1572 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
_______________________________________________
kbuild mailing list -- kbuild@lists.01.org
To unsubscribe send an email to kbuild-leave@lists.01.org
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2020-11-03 10:57 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-03 10:57 [kbuild] sound/soc/codecs/wcd934x.c:1571:9: warning: Identical condition 'ret', second condition is always false Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).