From: Vincent Whitchurch <vincent.whitchurch@axis.com>
To: Sasha Levin <sashal@kernel.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>,
Rob Herring <robh@kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH AUTOSEL 4.4 3/5] of: Fix reserved-memory overlap detection
Date: Tue, 3 Nov 2020 12:11:10 +0100 [thread overview]
Message-ID: <20201103111110.lvapcdf4nndunsie@axis.com> (raw)
In-Reply-To: <20201103012119.184049-3-sashal@kernel.org>
On Tue, Nov 03, 2020 at 02:21:16AM +0100, Sasha Levin wrote:
> From: Vincent Whitchurch <vincent.whitchurch@axis.com>
>
> [ Upstream commit ca05f33316559a04867295dd49f85aeedbfd6bfd ]
>
> The reserved-memory overlap detection code fails to detect overlaps if
> either of the regions starts at address 0x0. The code explicitly checks
> for and ignores such regions, apparently in order to ignore dynamically
> allocated regions which have an address of 0x0 at this point. These
> dynamically allocated regions also have a size of 0x0 at this point, so
> fix this by removing the check and sorting the dynamically allocated
> regions ahead of any static regions at address 0x0.
>
> For example, there are two overlaps in this case but they are not
> currently reported:
>
> foo@0 {
> reg = <0x0 0x2000>;
> };
>
> bar@0 {
> reg = <0x0 0x1000>;
> };
>
> baz@1000 {
> reg = <0x1000 0x1000>;
> };
>
> quux {
> size = <0x1000>;
> };
>
> but they are after this patch:
>
> OF: reserved mem: OVERLAP DETECTED!
> bar@0 (0x00000000--0x00001000) overlaps with foo@0 (0x00000000--0x00002000)
> OF: reserved mem: OVERLAP DETECTED!
> foo@0 (0x00000000--0x00002000) overlaps with baz@1000 (0x00001000--0x00002000)
>
> Signed-off-by: Vincent Whitchurch <vincent.whitchurch@axis.com>
> Link: https://lore.kernel.org/r/ded6fd6b47b58741aabdcc6967f73eca6a3f311e.1603273666.git-series.vincent.whitchurch@axis.com
> Signed-off-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Sasha Levin <sashal@kernel.org>
I'm not sure if this really needs to be backported. It's only fixing
what is essentially a minor debugging feature.
next prev parent reply other threads:[~2020-11-03 11:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-03 1:21 [PATCH AUTOSEL 4.4 1/5] ARM: dts: sun4i-a10: fix cpu_alert temperature Sasha Levin
2020-11-03 1:21 ` [PATCH AUTOSEL 4.4 2/5] x86/kexec: Use up-to-dated screen_info copy to fill boot params Sasha Levin
2020-11-03 1:21 ` [PATCH AUTOSEL 4.4 3/5] of: Fix reserved-memory overlap detection Sasha Levin
2020-11-03 11:11 ` Vincent Whitchurch [this message]
2020-11-03 1:21 ` [PATCH AUTOSEL 4.4 4/5] scsi: core: Don't start concurrent async scan on same host Sasha Levin
2020-11-03 1:21 ` [PATCH AUTOSEL 4.4 5/5] vsock: use ns_capable_noaudit() on socket create Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201103111110.lvapcdf4nndunsie@axis.com \
--to=vincent.whitchurch@axis.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).