From: Petr Mladek <pmladek@suse.com>
To: Matteo Croce <mcroce@linux.microsoft.com>
Cc: linux-kernel@vger.kernel.org, Guenter Roeck <linux@roeck-us.net>,
Arnd Bergmann <arnd@arndb.de>, Mike Rapoport <rppt@kernel.org>,
Kees Cook <keescook@chromium.org>,
Pavel Tatashin <pasha.tatashin@soleen.com>,
Robin Holt <robinmholt@gmail.com>
Subject: Re: [PATCH v2 2/2] reboot: fix parsing of reboot cpu number
Date: Tue, 3 Nov 2020 15:25:43 +0100 [thread overview]
Message-ID: <20201103142543.GP20201@alley> (raw)
In-Reply-To: <CAFnufp3tOKOB=xqe8Ln46n2wBFMDC4XoZpu51xk5B=Acp=L-JA@mail.gmail.com>
On Tue 2020-11-03 12:43:32, Matteo Croce wrote:
> On Mon, Nov 2, 2020 at 12:01 PM Petr Mladek <pmladek@suse.com> wrote:
> >
> > On Sun 2020-11-01 02:57:40, Matteo Croce wrote:
> > > On Fri, Oct 30, 2020 at 3:30 PM Petr Mladek <pmladek@suse.com> wrote:
> > > >
> > > > On Tue 2020-10-27 14:35:45, Matteo Croce wrote:
> > > > > From: Matteo Croce <mcroce@microsoft.com>
> > > > >
> > > > > The kernel cmdline reboot= argument allows to specify the CPU used
> > > > > for rebooting, with the syntax `s####` among the other flags, e.g.
> > > > >
> > > > > reboot=soft,s4
> > > > > reboot=warm,s31,force
> > > > >
> > > > > In the early days the parsing was done with simple_strtoul(), later
> > > > > deprecated in favor of the safer kstrtoint() which handles overflow.
> > > > >
> > > > > But kstrtoint() returns -EINVAL if there are non-digit characters
> > > > > in a string, so if this flag is not the last given, it's silently
> > > > > ignored as well as the subsequent ones.
> > > > >
> > > > > To fix it, revert the usage of simple_strtoul(), which is no longer
> > > > > deprecated, and restore the old behaviour.
> > > > >
> > > > > While at it, merge two identical code blocks into one.
> > > >
> > > > > --- a/kernel/reboot.c
> > > > > +++ b/kernel/reboot.c
> > > > > @@ -552,25 +552,19 @@ static int __init reboot_setup(char *str)
> > > > >
> > > > > case 's':
> > > > > {
> > > > > - int rc;
> > > > > -
> > > > > - if (isdigit(*(str+1))) {
> > > > > - rc = kstrtoint(str+1, 0, &reboot_cpu);
> > > > > - if (rc)
> > > > > - return rc;
> > > > > - if (reboot_cpu >= num_possible_cpus()) {
> > > > > - reboot_cpu = 0;
> > > > > - return -ERANGE;
> > > > > - }
> > > > > - } else if (str[1] == 'm' && str[2] == 'p' &&
> > > > > - isdigit(*(str+3))) {
> > > > > - rc = kstrtoint(str+3, 0, &reboot_cpu);
> > > > > - if (rc)
> > > > > - return rc;
> > > > > - if (reboot_cpu >= num_possible_cpus()) {
> > > > > - reboot_cpu = 0;
> > > >
> > > > ^^^^^^
> > > >
> > > > > + int cpu;
> > > > > +
> > > > > + /*
> > > > > + * reboot_cpu is s[mp]#### with #### being the processor
> > > > > + * to be used for rebooting. Skip 's' or 'smp' prefix.
> > > > > + */
> > > > > + str += str[1] == 'm' && str[2] == 'p' ? 3 : 1;
> > > > > +
> > > > > + if (isdigit(str[0])) {
> > > > > + cpu = simple_strtoul(str, NULL, 0);
> > > > > + if (cpu >= num_possible_cpus())
> > > > > return -ERANGE;
> > > > > - }
> > > > > + reboot_cpu = cpu;
> > > >
> > > > The original value stays when the new one is out of range. It is
> > > > small functional change that should get mentioned in the commit
> > > > message or better fixed separately.
> >
> > Ah, I see. From some reason, I assumed that it was defined as
> > module_param() or core_param(). Then it would be possible to modify
> > it later via /sys.
> >
> > I am sorry for the noise.
> >
>
> Never mind :)
>
> So, is this an ack? Or I need to prepare a v3 with the revert as first patch?
Good question ;-) It would be nice to do it the cleaner way but I do
not resist on it. Feel free to use:
Reviewed-by: Petr Mladek <pmladek@suse.com>
Now, the question is who would actually push this upstream. These
patches often go via Andrew Morton. He actually committed both
changes that are fixed here.
I suggest to resend the patchset with my Reviewed-by and
Cc: stable@vger.kernel.org lines. And put Andrew and Greg into Cc.
Best Regards,
Petr
next prev parent reply other threads:[~2020-11-03 14:26 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-27 13:35 [PATCH v2 0/2] fix parsing of reboot= cmdline Matteo Croce
2020-10-27 13:35 ` [PATCH v2 1/2] reboot: fix overflow parsing reboot cpu number Matteo Croce
2020-10-27 13:42 ` Greg KH
2020-10-30 14:13 ` Petr Mladek
2020-10-30 14:18 ` Matteo Croce
2020-10-27 13:35 ` [PATCH v2 2/2] reboot: fix parsing of " Matteo Croce
2020-10-27 13:42 ` Greg KH
2020-10-30 14:30 ` Petr Mladek
2020-11-01 1:57 ` Matteo Croce
2020-11-02 11:01 ` Petr Mladek
2020-11-03 11:43 ` Matteo Croce
2020-11-03 14:25 ` Petr Mladek [this message]
2020-11-03 15:43 ` Matteo Croce
2020-11-03 16:22 ` Petr Mladek
2020-10-27 13:42 ` [PATCH v2 0/2] fix parsing of reboot= cmdline Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201103142543.GP20201@alley \
--to=pmladek@suse.com \
--cc=arnd@arndb.de \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mcroce@linux.microsoft.com \
--cc=pasha.tatashin@soleen.com \
--cc=robinmholt@gmail.com \
--cc=rppt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).