From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87C4FC2D0A3 for ; Tue, 3 Nov 2020 17:04:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4478C22226 for ; Tue, 3 Nov 2020 17:04:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="AtMg9SkL" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728372AbgKCREh (ORCPT ); Tue, 3 Nov 2020 12:04:37 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:43016 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726581AbgKCREg (ORCPT ); Tue, 3 Nov 2020 12:04:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1604423075; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=P6Nqd/GTymSo6mkhELu0bxwV3r/gwkmZPBYT64Awjzw=; b=AtMg9SkLmD8daTfJvCVedE33/KZel2QOvzczQNhuwIkWe/oT0eMYNPjEm8Rm11D3Z/AaJq zXLaOVoRGmw5y9vd7ec+2Q+HAfE+q/56eQK8qq+gVj0DJgun6WYIBT0aiCLZdcAqUtzkF4 lcPvvjkGLB1Xud2AjORC8nLWpRLypIw= Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-481-IRH0COoaO0G5xTPdHbmLXQ-1; Tue, 03 Nov 2020 12:04:33 -0500 X-MC-Unique: IRH0COoaO0G5xTPdHbmLXQ-1 Received: by mail-pf1-f197.google.com with SMTP id z12so12554944pfa.22 for ; Tue, 03 Nov 2020 09:04:33 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=P6Nqd/GTymSo6mkhELu0bxwV3r/gwkmZPBYT64Awjzw=; b=gH2ooGWtMYcvi/SSsY7yyL1aERRvEW1O79ZfjfFHVHdhNFJn6R+aSqOgls5BJ7Vbvy G5NY0PQC8j2Yv7xICFHf/HPJNlpscyVQUEZztOuRn8NmH2yGoVzpNvOd+Dkz/sQTg6RM 0ktf8l1xA0jzcD2+IUG+dasjHQqFqEifiXDZugKhHnKo6wWt8qtSMEfFmiblWUfQU6eZ Fcxaqmo15bbbvFFHCuOTr2li7o3wQEDXcVGsOeyBJAwljGTgVkSFFPzzKDSM2sqrBLTn gteuJOSB3TEiCOO6LAPaMHhb9HKV0HQCGCd0hCsceTXQ4PxFcqfhWyMup7sMmRAbfqiD 8Ysw== X-Gm-Message-State: AOAM530Zop265rhHn2ozcIBRFowRC00xp8gKhh2mphkOcsaBpBr+ujBs ioEb4kGigNnZ10xLhP/o8bIPxu8kyqdTKI+QFa6blz244DfMY9k6bWmbuEDxengVhpucDxN8h3Q WU/r376zjtkwlRsqZtGnBoA/F X-Received: by 2002:a17:90a:7089:: with SMTP id g9mr160162pjk.4.1604423072874; Tue, 03 Nov 2020 09:04:32 -0800 (PST) X-Google-Smtp-Source: ABdhPJzKrStQIiawQJXfEFp92+BAuOv0tSVW7WzCsy3loX2ZPEWNt9Fyvdp3RWqxou54wmyvUe6r9g== X-Received: by 2002:a17:90a:7089:: with SMTP id g9mr160141pjk.4.1604423072675; Tue, 03 Nov 2020 09:04:32 -0800 (PST) Received: from xiangao.remote.csb ([209.132.188.80]) by smtp.gmail.com with ESMTPSA id v24sm15775598pgi.91.2020.11.03.09.04.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Nov 2020 09:04:31 -0800 (PST) Date: Wed, 4 Nov 2020 01:04:21 +0800 From: Gao Xiang To: Chao Yu Cc: Chao Yu , linux-erofs@lists.ozlabs.org, LKML , nl6720 , stable Subject: Re: [PATCH] erofs: derive atime instead of leaving it empty Message-ID: <20201103170421.GB886627@xiangao.remote.csb> References: <20201031195102.21221-1-hsiangkao.ref@aol.com> <20201031195102.21221-1-hsiangkao@aol.com> <20201103025033.GA788000@xiangao.remote.csb> <275b73d7-9865-91c0-ecf2-bceed09a4dae@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <275b73d7-9865-91c0-ecf2-bceed09a4dae@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Chao, On Tue, Nov 03, 2020 at 11:58:42PM +0800, Chao Yu wrote: > Hi Xiang, > > On 2020-11-3 10:50, Gao Xiang wrote: > > Hi Chao, > > > > On Sun, Nov 01, 2020 at 03:51:02AM +0800, Gao Xiang wrote: > > > From: Gao Xiang > > > > > > EROFS has _only one_ ondisk timestamp (ctime is currently > > > documented and recorded, we might also record mtime instead > > > with a new compat feature if needed) for each extended inode > > > since EROFS isn't mainly for archival purposes so no need to > > > keep all timestamps on disk especially for Android scenarios > > > due to security concerns. Also, romfs/cramfs don't have their > > > own on-disk timestamp, and squashfs only records mtime instead. > > > > > > Let's also derive access time from ondisk timestamp rather than > > > leaving it empty, and if mtime/atime for each file are really > > > needed for specific scenarios as well, we can also use xattrs > > > to record them then. > > > > > > Reported-by: nl6720 > > > [ Gao Xiang: It'd be better to backport for user-friendly concern. ] > > > Fixes: 431339ba9042 ("staging: erofs: add inode operations") > > > Cc: stable # 4.19+ > > > Signed-off-by: Gao Xiang > > > > May I ask for some extra free slots to review this patch plus > > [PATCH 1/4] of > > https://lore.kernel.org/r/20201022145724.27284-1-hsiangkao@aol.com > > > > since it'd be also in linux-next for a while before sending out > > to Linus. And the debugging messages may also be an annoying > > thing for users. > > Sorry for the delay review, will check the details tomorrow. :) No problem, thanks! If we'd like to submit a -fixes pull request, it'd be better not to be in the latter half of 5.10 rc... And considering that it'd be stayed in linux-next for almost a week, so yeah... (Only these 2 patches are considered for -fixes for now.) Thanks. Gao Xiang > > Thanks, > > > > > Thanks a lot! > > > > Thanks, > > Gao Xiang > > >