* [PATCH] forcedeth: fix excluded_middle.cocci warnings
@ 2020-11-02 8:38 Julia Lawall
2020-11-04 1:48 ` Jakub Kicinski
0 siblings, 1 reply; 2+ messages in thread
From: Julia Lawall @ 2020-11-02 8:38 UTC (permalink / raw)
To: Rain River, Zhu Yanjun, Jakub Kicinski
Cc: netdev, linux-kernel, Denis Efremov, kbuild-all
From: kernel test robot <lkp@intel.com>
Condition !A || A && B is equivalent to !A || B.
Generated by: scripts/coccinelle/misc/excluded_middle.cocci
Fixes: b76f0ea01312 ("coccinelle: misc: add excluded_middle.cocci script")
CC: Denis Efremov <efremov@linux.com>
Signed-off-by: kernel test robot <lkp@intel.com>
Signed-off-by: Julia Lawall <julia.lawall@inria.fr>
---
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 3cea11cd5e3b00d91caf0b4730194039b45c5891
commit: b76f0ea013125358d1b4ca147a6f9b6883dd2493 coccinelle: misc: add excluded_middle.cocci script
:::::: branch date: 7 hours ago
:::::: commit date: 6 weeks ago
forcedeth.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
--- a/drivers/net/ethernet/nvidia/forcedeth.c
+++ b/drivers/net/ethernet/nvidia/forcedeth.c
@@ -1043,8 +1043,7 @@ static int using_multi_irqs(struct net_d
struct fe_priv *np = get_nvpriv(dev);
if (!(np->msi_flags & NV_MSI_X_ENABLED) ||
- ((np->msi_flags & NV_MSI_X_ENABLED) &&
- ((np->msi_flags & NV_MSI_X_VECTORS_MASK) == 0x1)))
+ ((np->msi_flags & NV_MSI_X_VECTORS_MASK) == 0x1))
return 0;
else
return 1;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] forcedeth: fix excluded_middle.cocci warnings
2020-11-02 8:38 [PATCH] forcedeth: fix excluded_middle.cocci warnings Julia Lawall
@ 2020-11-04 1:48 ` Jakub Kicinski
0 siblings, 0 replies; 2+ messages in thread
From: Jakub Kicinski @ 2020-11-04 1:48 UTC (permalink / raw)
To: Julia Lawall
Cc: Rain River, Zhu Yanjun, netdev, linux-kernel, Denis Efremov, kbuild-all
On Mon, 2 Nov 2020 09:38:30 +0100 (CET) Julia Lawall wrote:
> From: kernel test robot <lkp@intel.com>
>
> Condition !A || A && B is equivalent to !A || B.
>
> Generated by: scripts/coccinelle/misc/excluded_middle.cocci
>
> Fixes: b76f0ea01312 ("coccinelle: misc: add excluded_middle.cocci script")
> CC: Denis Efremov <efremov@linux.com>
> Signed-off-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Julia Lawall <julia.lawall@inria.fr>
Applied, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-11-04 1:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-02 8:38 [PATCH] forcedeth: fix excluded_middle.cocci warnings Julia Lawall
2020-11-04 1:48 ` Jakub Kicinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).