From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A0F8C2D0A3 for ; Tue, 3 Nov 2020 21:50:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C889321556 for ; Tue, 3 Nov 2020 21:50:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604440220; bh=Rl7KlvGNjgpipQ9OxJ/zByIUtYu+3qLpWUB+MrcImnw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=b07L7hX6qfGcVm76PKG9+Yvyk7RkSiZTnZi9UmVPIOtnp+kYUJXTG6RAIastDzrOk /AzfQ32bfKuC0pHtLuK3KZMtYh3j1vL26q1dtdTlLKhGxF/Yl3JzJe1DAn7wt3oke/ RHqFZIumGcpl4RTlCdo/pMQzH9y/s/yPuyzqxTMc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729645AbgKCUtJ (ORCPT ); Tue, 3 Nov 2020 15:49:09 -0500 Received: from mail.kernel.org ([198.145.29.99]:39196 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731479AbgKCUsF (ORCPT ); Tue, 3 Nov 2020 15:48:05 -0500 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5C38822404; Tue, 3 Nov 2020 20:48:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604436484; bh=Rl7KlvGNjgpipQ9OxJ/zByIUtYu+3qLpWUB+MrcImnw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=b5Pm4/wdA7YAyy29NdKAEfXJgtwIYp0UHqbH/oHSGGCnWQbaqV1feXnIVzfjisCXh NbSuQpN8w2dnQeOqj7rd7rhVEotKFSnQYQQpsGQ+d+AzjnXJlPtA+A4VMzGQ7qXFFB ndhi/vPcqvIlNt+1S3+B4WjanjHeGTuLq+UrsRd4= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Stable@vger.kernel.org, Andy Shevchenko , Jonathan Cameron Subject: [PATCH 5.9 271/391] iio:imu:st_lsm6dsx: check st_lsm6dsx_shub_read_output return Date: Tue, 3 Nov 2020 21:35:22 +0100 Message-Id: <20201103203405.316967620@linuxfoundation.org> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20201103203348.153465465@linuxfoundation.org> References: <20201103203348.153465465@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Tom Rix commit f71e41e23e129640f620b65fc362a6da02580310 upstream. Potential error return is not checked. This can lead to use of undefined data. Detected by clang static analysis. st_lsm6dsx_shub.c:540:8: warning: Assigned value is garbage or undefined *val = (s16)le16_to_cpu(*((__le16 *)data)); ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Fixes: c91c1c844ebd ("iio: imu: st_lsm6dsx: add i2c embedded controller support") Signed-off-by: Tom Rix Reviewed-by: Andy Shevchenko Link: https://lore.kernel.org/r/20200809175551.6794-1-trix@redhat.com Signed-off-by: Jonathan Cameron Signed-off-by: Greg Kroah-Hartman --- drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_shub.c | 2 ++ 1 file changed, 2 insertions(+) --- a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_shub.c +++ b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_shub.c @@ -313,6 +313,8 @@ st_lsm6dsx_shub_read(struct st_lsm6dsx_s err = st_lsm6dsx_shub_read_output(hw, data, len & ST_LS6DSX_READ_OP_MASK); + if (err < 0) + return err; st_lsm6dsx_shub_master_enable(sensor, false);