From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 039DAC2D0A3 for ; Tue, 3 Nov 2020 21:48:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BEB2E21556 for ; Tue, 3 Nov 2020 21:48:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604440125; bh=10E+evXaSoanrGML/WlMAmxK4soRQKnBX3Wuv12W+X8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=0tr3XEsjcsJF0d5vJwY6mhGvfKnA3VJjJJTSeWnYIRVZlrmWsN8jdFjrEnV5MaFR1 wO+79tfy17GR/Qmg+BcWSE7aACybWTQdDHxRvFpmOFewibd+PO5Yg9Via+4jtOkRqO bzXLbq5mno4m6VK2n9LVMeDMozVPRbCaPUfomDE8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732171AbgKCVso (ORCPT ); Tue, 3 Nov 2020 16:48:44 -0500 Received: from mail.kernel.org ([198.145.29.99]:43690 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731732AbgKCUt7 (ORCPT ); Tue, 3 Nov 2020 15:49:59 -0500 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 46A2F22404; Tue, 3 Nov 2020 20:49:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604436598; bh=10E+evXaSoanrGML/WlMAmxK4soRQKnBX3Wuv12W+X8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=LgOnKe33AIVTv7mdjjtBr3dL5PLGzgGGni+rCKs7m/w9ksTXU+IayhkWoqdLjX8cC rJ8fzhi0NSvlLpxgISqgClZmSmZB25bK1eGr8VeQS/QDdqY9zy2lBZrfszXTyzlOaZ wslDYjVXSkwtSc/IkliX1aofqo+KFvu7s8gmc7Cw= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Zhihao Cheng , Richard Weinberger Subject: [PATCH 5.9 303/391] ubifs: dent: Fix some potential memory leaks while iterating entries Date: Tue, 3 Nov 2020 21:35:54 +0100 Message-Id: <20201103203407.549317349@linuxfoundation.org> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20201103203348.153465465@linuxfoundation.org> References: <20201103203348.153465465@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Zhihao Cheng commit 58f6e78a65f1fcbf732f60a7478ccc99873ff3ba upstream. Fix some potential memory leaks in error handling branches while iterating dent entries. For example, function dbg_check_dir() forgets to free pdent if it exists. Signed-off-by: Zhihao Cheng Cc: Fixes: 1e51764a3c2ac05a2 ("UBIFS: add new flash file system") Signed-off-by: Richard Weinberger Signed-off-by: Greg Kroah-Hartman --- fs/ubifs/debug.c | 1 + 1 file changed, 1 insertion(+) --- a/fs/ubifs/debug.c +++ b/fs/ubifs/debug.c @@ -1123,6 +1123,7 @@ int dbg_check_dir(struct ubifs_info *c, err = PTR_ERR(dent); if (err == -ENOENT) break; + kfree(pdent); return err; }