From: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Mark Brown" <broonie@kernel.org>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
"Hans Verkuil" <hverkuil@xs4all.nl>,
"Maxime Ripard" <mripard@kernel.org>,
kevin.lhopital@hotmail.com,
"Kévin L'hôpital" <kevin.lhopital@bootlin.com>
Subject: Re: [PATCH 1/3] dt-bindings: media: i2c: Add OV8865 bindings documentation
Date: Wed, 4 Nov 2020 11:26:43 +0100 [thread overview]
Message-ID: <20201104102643.GH2123@aptenodytes> (raw)
In-Reply-To: <20201102232411.GD26150@paasikivi.fi.intel.com>
[-- Attachment #1: Type: text/plain, Size: 6023 bytes --]
Hi Sakari and thanks for the review!
On Tue 03 Nov 20, 01:24, Sakari Ailus wrote:
> On Fri, Oct 23, 2020 at 07:54:04PM +0200, Paul Kocialkowski wrote:
> > This introduces YAML bindings documentation for the OV8865
> > image sensor.
> >
> > Co-developed-by: Kévin L'hôpital <kevin.lhopital@bootlin.com>
> > Signed-off-by: Kévin L'hôpital <kevin.lhopital@bootlin.com>
> > Signed-off-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
> > ---
> > .../bindings/media/i2c/ovti,ov8865.yaml | 124 ++++++++++++++++++
> > 1 file changed, 124 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/media/i2c/ovti,ov8865.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov8865.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov8865.yaml
> > new file mode 100644
> > index 000000000000..807f1a94afae
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov8865.yaml
> > @@ -0,0 +1,124 @@
> > +# SPDX-License-Identifier: GPL-2.0
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/media/i2c/ovti,ov8865.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: OmniVision OV8865 Image Sensor Device Tree Bindings
> > +
> > +maintainers:
> > + - Paul Kocialkowski <paul.kocialkowski@bootlin.com>
> > +
> > +properties:
> > + compatible:
> > + const: ovti,ov8865
> > +
> > + reg:
> > + maxItems: 1
> > +
> > + clocks:
> > + items:
> > + - description: EXTCLK Clock
> > +
> > + clock-names:
> > + items:
> > + - const: extclk
>
> Is this needed with a single clock?
Yes I think so: we grab the clock with devm_clk_get which takes a name string
that matches the clock-names property.
> And... shouldn't this also come with assigned-clock-rates etc., to set the
> clock frequency?
I'm a bit confused why we would need to do that in the device-tree rather than
setting the clock rate with clk_set_rate in the driver, like any other driver
does. I think this was discussed before (on the initial ov8865 series) and the
conclusion was that there is no particular reason for media i2c drivers to
behave differently. So I believe this is the correct approach.
> > +
> > + dvdd-supply:
> > + description: Digital Domain Power Supply
> > +
> > + avdd-supply:
> > + description: Analog Domain Power Supply (internal AVDD is used if missing)
> > +
> > + dovdd-supply:
> > + description: I/O Domain Power Supply
> > +
> > + powerdown-gpios:
> > + maxItems: 1
> > + description: Power Down Pin GPIO Control (active low)
> > +
> > + reset-gpios:
> > + maxItems: 1
> > + description: Reset Pin GPIO Control (active low)
> > +
> > + port:
> > + type: object
> > + description: Input port, connect to a MIPI CSI-2 receiver
> > +
> > + properties:
> > + endpoint:
> > + type: object
> > +
> > + properties:
> > + remote-endpoint: true
> > +
> > + bus-type:
> > + const: 4
> > +
> > + clock-lanes:
> > + maxItems: 1
>
> I believe you can drop clock-lanes and bus-type; these are both constants.
I don't understand why bus-type should be dropped because it is constant:
if bus-type is set to something else, the driver will definitely not probe
since we're requesting V4L2_MBUS_CSI2_DPHY for v4l2_fwnode_endpoint_parse.
So I think it's quite important for the bindings to reflect this.
> I presume the device does not support lane remapping?
That's correct so this is indeed not something we can configure.
But shouldn't we instead specift clock-lanes = <0> as a const rather than
getting rid of it?
> Could you also add link-frequencies, to list which frequencies are known to
> be good?
Ah right, I had missed it. I'm a bit unsure about what I should do with the
information from the driver though: should I refuse to use link frequencies that
are not in the list?
Cheers,
Paul
> Same comments on the other OV sensor bindings.
>
> > +
> > + data-lanes:
> > + minItems: 1
> > + maxItems: 4
> > +
> > + required:
> > + - bus-type
> > + - data-lanes
> > + - remote-endpoint
> > +
> > + additionalProperties: false
> > +
> > + required:
> > + - endpoint
> > +
> > +required:
> > + - compatible
> > + - reg
> > + - clocks
> > + - clock-names
> > + - dvdd-supply
> > + - dovdd-supply
> > + - port
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > + - |
> > + #include <dt-bindings/clock/sun8i-a83t-ccu.h>
> > + #include <dt-bindings/gpio/gpio.h>
> > +
> > + i2c2 {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + ov8865: camera@36 {
> > + compatible = "ovti,ov8865";
> > + reg = <0x36>;
> > +
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&csi_mclk_pin>;
> > +
> > + clocks = <&ccu CLK_CSI_MCLK>;
> > + clock-names = "extclk";
> > +
> > + avdd-supply = <®_ov8865_avdd>;
> > + dovdd-supply = <®_ov8865_dovdd>;
> > + dvdd-supply = <®_ov8865_dvdd>;
> > +
> > + powerdown-gpios = <&pio 4 17 GPIO_ACTIVE_LOW>; /* PE17 */
> > + reset-gpios = <&pio 4 16 GPIO_ACTIVE_LOW>; /* PE16 */
> > +
> > + port {
> > + ov8865_out_mipi_csi2: endpoint {
> > + bus-type = <4>; /* MIPI CSI-2 D-PHY */
> > + clock-lanes = <0>;
> > + data-lanes = <1 2 3 4>;
> > +
> > + remote-endpoint = <&mipi_csi2_in_ov8865>;
> > + };
> > + };
> > + };
> > + };
> > +
> > +...
>
> --
> Regards,
>
> Sakari Ailus
--
Paul Kocialkowski, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-11-04 10:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-23 17:54 [PATCH 0/3] media: i2c: OV8865 image sensor support Paul Kocialkowski
2020-10-23 17:54 ` [PATCH 1/3] dt-bindings: media: i2c: Add OV8865 bindings documentation Paul Kocialkowski
2020-10-30 16:39 ` Rob Herring
2020-11-02 23:24 ` Sakari Ailus
2020-11-04 10:26 ` Paul Kocialkowski [this message]
2020-11-05 8:19 ` Sakari Ailus
2020-11-05 15:35 ` Paul Kocialkowski
2020-11-11 13:18 ` Sakari Ailus
2020-11-13 17:27 ` Maxime Ripard
2020-11-18 22:38 ` Sakari Ailus
2020-10-23 17:54 ` [PATCH 2/3] media: i2c: Add support for the OV8865 image sensor Paul Kocialkowski
2020-10-23 17:54 ` [PATCH NOT FOR MERGE 3/3] ARM: dts: sun8i: a83t: bananapi-m3: Enable MIPI CSI-2 with OV8865 Paul Kocialkowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201104102643.GH2123@aptenodytes \
--to=paul.kocialkowski@bootlin.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hverkuil@xs4all.nl \
--cc=kevin.lhopital@bootlin.com \
--cc=kevin.lhopital@hotmail.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=mripard@kernel.org \
--cc=robh+dt@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).