From: Lee Jones <lee.jones@linaro.org>
To: Charles Keepax <ckeepax@opensource.cirrus.com>
Cc: linux-kernel@vger.kernel.org, patches@opensource.cirrus.com
Subject: Re: [PATCH RESEND 1/2] mfd: madera: Add reset as part of resume
Date: Wed, 4 Nov 2020 15:40:05 +0000 [thread overview]
Message-ID: <20201104154005.GO4488@dell> (raw)
In-Reply-To: <20201027094132.16472-1-ckeepax@opensource.cirrus.com>
On Tue, 27 Oct 2020, Charles Keepax wrote:
> The DCVDD supply does not always power down when the CODEC enters
> suspend, for example shared regulators or always-on regulators. In
> these cases if a register is written back to the default value whilst
> the CODEC is in suspend that register will retain the previous value.
> As DCVDD never powered down, the register retains its old value and
> as the cache sync only synchronises registers that differ from the
> default the new value is never written out.
>
> Ensure the registers are in the expected state after suspend by always
> resetting the CODEC on resume. This also has the benefit of being
> recommended by the datasheet for DCVDD supplies that take longer than
> 2mS to rise.
>
> Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
> ---
> drivers/mfd/madera-core.c | 16 +++++++++++++++-
> 1 file changed, 15 insertions(+), 1 deletion(-)
Applied, thanks.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
prev parent reply other threads:[~2020-11-04 15:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-27 9:41 [PATCH RESEND 1/2] mfd: madera: Add reset as part of resume Charles Keepax
2020-10-27 9:41 ` [PATCH RESEND 2/2] mfd: madera: Add special errata reset handling for cs47l15 Charles Keepax
2020-11-04 15:42 ` Lee Jones
2020-11-04 15:40 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201104154005.GO4488@dell \
--to=lee.jones@linaro.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).