From: Jakub Kicinski <kuba@kernel.org>
To: Alex Elder <elder@linaro.org>
Cc: davem@davemloft.net, evgreen@chromium.org,
subashab@codeaurora.org, cpratapa@codeaurora.org,
bjorn.andersson@linaro.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 0/6] net: ipa: tell GSI the IPA version
Date: Wed, 4 Nov 2020 16:31:38 -0800 [thread overview]
Message-ID: <20201104163138.6c5d534d@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <20201102175400.6282-1-elder@linaro.org>
On Mon, 2 Nov 2020 11:53:54 -0600 Alex Elder wrote:
> The GSI code that supports IPA avoids having knowledge about the
> IPA layer it serves. One result of this is that Boolean flags are
> used during GSI initialization to convey that certain hardware
> version-dependent special behaviors should be used.
>
> A given version of IPA hardware uses a fixed/well-defined version
> of GSI, so the IPA version really implies the GSI version.
>
> If given only the IPA version, the GSI code supporting IPA can
> use it to implement certain special behaviors required for IPA
> *or* GSI. This avoids the need to pass and maintain numerous
> Boolean flags.
Applied, thanks.
> Note: the last patch in this series depends on this patch posted
> for review earlier today:
> https://lore.kernel.org/netdev/20201102173435.5987-1-elder@linaro.org
But in the future please don't post dependent changes like this. The
build bots cannot figure this out and give up on checking your series.
next prev parent reply other threads:[~2020-11-05 0:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-02 17:53 [PATCH net-next 0/6] net: ipa: tell GSI the IPA version Alex Elder
2020-11-02 17:53 ` [PATCH net-next 1/6] net: ipa: expose IPA version to the GSI layer Alex Elder
2020-11-02 17:53 ` [PATCH net-next 2/6] net: ipa: record IPA version in GSI structure Alex Elder
2020-11-02 17:53 ` [PATCH net-next 3/6] net: ipa: use version in gsi_channel_init() Alex Elder
2020-11-02 17:53 ` [PATCH net-next 4/6] net: ipa: use version in gsi_channel_reset() Alex Elder
2020-11-02 17:53 ` [PATCH net-next 5/6] net: ipa: use version in gsi_channel_program() Alex Elder
2020-11-02 17:54 ` [PATCH net-next 6/6] net: ipa: eliminate legacy arguments Alex Elder
2020-11-05 0:31 ` Jakub Kicinski [this message]
2020-11-05 13:40 ` [PATCH net-next 0/6] net: ipa: tell GSI the IPA version Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201104163138.6c5d534d@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=cpratapa@codeaurora.org \
--cc=davem@davemloft.net \
--cc=elder@linaro.org \
--cc=evgreen@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=subashab@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).