From: Miquel Raynal <miquel.raynal@bootlin.com>
To: YouChing Lin <ycllin@mxic.com.tw>
Cc: richard@nod.at, vigneshr@ti.com, juliensu@mxic.com.tw,
gch981213@gmail.com, linux-mtd@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mtd: spinand: macronix: Add support for MX35LFxGE4AD
Date: Wed, 4 Nov 2020 18:44:44 +0100 [thread overview]
Message-ID: <20201104184444.3fd2d52d@xps13> (raw)
In-Reply-To: <1604490442-9052-1-git-send-email-ycllin@mxic.com.tw>
Hi YouChing,
YouChing Lin <ycllin@mxic.com.tw> wrote on Wed, 4 Nov 2020 19:47:22
+0800:
> The Macronix MX35LF2GE4AD / MX35LF4GE4AD are 3V, 2G / 4Gbit serial
> SLC NAND flash device (with on-die ECC).
>
> Validated by read, erase, read back, write, read back and nandtest
> on Xilinx Zynq PicoZed FPGA board which included Macronix SPI Host
> (drivers/spi/spi-mxic.c).
>
> Signed-off-by: YouChing Lin <ycllin@mxic.com.tw>
> ---
> drivers/mtd/nand/spi/macronix.c | 20 ++++++++++++++++++++
> 1 file changed, 20 insertions(+)
>
> diff --git a/drivers/mtd/nand/spi/macronix.c b/drivers/mtd/nand/spi/macronix.c
> index 8e801e4..4f7f954 100644
> --- a/drivers/mtd/nand/spi/macronix.c
> +++ b/drivers/mtd/nand/spi/macronix.c
> @@ -119,6 +119,26 @@ static int mx35lf1ge4ab_ecc_get_status(struct spinand_device *spinand,
> &update_cache_variants),
> SPINAND_HAS_QE_BIT,
> SPINAND_ECCINFO(&mx35lfxge4ab_ooblayout, NULL)),
> + SPINAND_INFO("MX35LF2GE4AD",
> + SPINAND_ID(SPINAND_READID_METHOD_OPCODE_DUMMY, 0x26),
> + NAND_MEMORG(1, 2048, 64, 64, 2048, 40, 1, 1, 1),
> + NAND_ECCREQ(8, 512),
> + SPINAND_INFO_OP_VARIANTS(&read_cache_variants,
> + &write_cache_variants,
> + &update_cache_variants),
> + 0 /*SPINAND_HAS_QE_BIT*/,
What is the purpose of this comment? Shouldn't get rid of it and just
keep '0' if the QE bit is not supported?
> + SPINAND_ECCINFO(&mx35lfxge4ab_ooblayout,
> + mx35lf1ge4ab_ecc_get_status)),
> + SPINAND_INFO("MX35LF4GE4AD",
> + SPINAND_ID(SPINAND_READID_METHOD_OPCODE_DUMMY, 0x37),
> + NAND_MEMORG(1, 4096, 128, 64, 2048, 40, 1, 1, 1),
> + NAND_ECCREQ(8, 512),
> + SPINAND_INFO_OP_VARIANTS(&read_cache_variants,
> + &write_cache_variants,
> + &update_cache_variants),
> + 0 /*SPINAND_HAS_QE_BIT*/,
Ditto
> + SPINAND_ECCINFO(&mx35lfxge4ab_ooblayout,
> + mx35lf1ge4ab_ecc_get_status)),
> SPINAND_INFO("MX31LF1GE4BC",
> SPINAND_ID(SPINAND_READID_METHOD_OPCODE_DUMMY, 0x1e),
> NAND_MEMORG(1, 2048, 64, 64, 1024, 20, 1, 1, 1),
Thanks,
Miquèl
next prev parent reply other threads:[~2020-11-04 17:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-04 11:47 [PATCH] mtd: spinand: macronix: Add support for MX35LFxGE4AD YouChing Lin
2020-11-04 17:44 ` Miquel Raynal [this message]
2020-11-19 21:11 ` Miquel Raynal
2020-11-19 21:15 ` Miquel Raynal
2020-11-20 1:10 ` 回信: " ycllin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201104184444.3fd2d52d@xps13 \
--to=miquel.raynal@bootlin.com \
--cc=gch981213@gmail.com \
--cc=juliensu@mxic.com.tw \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
--cc=ycllin@mxic.com.tw \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).