From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18AC2C4741F for ; Wed, 4 Nov 2020 20:29:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B3E98207BB for ; Wed, 4 Nov 2020 20:29:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604521766; bh=YsqwvDkysjqcelivUMh1EQTcXoiX5e6CH0oo7FC4XJg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=YLDaJjzMhirBE64HMmv43hEAROeLh9RpY9Ak411MBbcLLygg69k0YlkizsVTs8T/h mOEBL4VK/X69JWHjuDU7odO3SVB6ASVdq1vrbBA+woCIehttX8BVPhAtHeyRstYH9H +VUXzBsOfaNqsMYlUghNt6bga3HXBDzMzophBRFg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731892AbgKDU3Z (ORCPT ); Wed, 4 Nov 2020 15:29:25 -0500 Received: from mail.kernel.org ([198.145.29.99]:55002 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730965AbgKDU3Y (ORCPT ); Wed, 4 Nov 2020 15:29:24 -0500 Received: from gmail.com (unknown [104.132.1.84]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6410320795; Wed, 4 Nov 2020 20:29:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604521763; bh=YsqwvDkysjqcelivUMh1EQTcXoiX5e6CH0oo7FC4XJg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Jj4d0tvrS66vd21+5PcYYN3ftlTVckqzHc2eMJR7eZLgQ77Nw1SLN/S/EnVFE+1lI ZkKaFNIiEDCRa3HXj+2QTaZSHm38ylYlJLq39T/N5sxOOOShV/lzxw3Q8NA/+Hf7V/ EUVX1Yh8dKalypHhVd/J101q2LDcM5YR0SEr6U7s= Date: Wed, 4 Nov 2020 12:29:20 -0800 From: Eric Biggers To: Lokesh Gidra Cc: Alexander Viro , James Morris , Stephen Smalley , Casey Schaufler , "Serge E. Hallyn" , Paul Moore , Eric Paris , Daniel Colascione , Kees Cook , "Eric W. Biederman" , KP Singh , David Howells , Thomas Cedeno , Anders Roxell , Sami Tolvanen , Matthew Garrett , Aaron Goidel , Randy Dunlap , "Joel Fernandes (Google)" , YueHaibing , Christian Brauner , Alexei Starovoitov , Alexey Budankov , Adrian Reber , Aleksa Sarai , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, selinux@vger.kernel.org, kaleshsingh@google.com, calin@google.com, surenb@google.com, nnk@google.com, jeffv@google.com, kernel-team@android.com Subject: Re: [PATCH v10 0/3] SELinux support for anonymous inodes and UFFD Message-ID: <20201104202920.GC1796392@gmail.com> References: <20201011082936.4131726-1-lokeshgidra@google.com> <20201104200701.GA1796392@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201104200701.GA1796392@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 04, 2020 at 12:07:16PM -0800, Eric Biggers wrote: > On Sun, Oct 11, 2020 at 01:29:33AM -0700, Lokesh Gidra wrote: > > Daniel Colascione (3): > > Add a new LSM-supporting anonymous inode interface > > Teach SELinux about anonymous inodes > > Use secure anon inodes for userfaultfd > > Patches are supposed to have subsystem prefixes, e.g. > > fs, security: add a new LSM-supporting anonymous inode interface > selinux: implement init_security_anon() > userfaultfd: use secure anon inodes > > ... but that points to the fact that the first one is really both fs and > security subsystem changes. Patches should be one logical change only. I > suggest splitting it up into: > > security: add init_security_anon() LSM hook > fs: add anon_inode_getfd_secure() Correction: it's "inode_init_security_anon()", not "init_security_anon()". - Eric