From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9FB1C4741F for ; Wed, 4 Nov 2020 21:08:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8D3C2207BB for ; Wed, 4 Nov 2020 21:08:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604524087; bh=G0uq8e6OgtV0+KbXQS1pCsWkNSlsglSBX6d5gMU26u4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=SqMa1z8llz8VwnlE0Iu1UqOASpy95ZN5k8k0LvThXpoWXpa7Rpbh0nPT9X+zGFHMz OJc/09pdQBDe9bUocxX84vdR0dpu04bMxte+gl8ZY34MfOKlRLEYdWZDyN6g6grbNp guMHpcPl+4YvAzw0W5xWGToOyKiZyfp7GXqvsrXk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731733AbgKDVIG (ORCPT ); Wed, 4 Nov 2020 16:08:06 -0500 Received: from mail-oi1-f196.google.com ([209.85.167.196]:37694 "EHLO mail-oi1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726969AbgKDVIG (ORCPT ); Wed, 4 Nov 2020 16:08:06 -0500 Received: by mail-oi1-f196.google.com with SMTP id m17so2417191oie.4; Wed, 04 Nov 2020 13:08:05 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=E6N7y6aqHymIOGjWcFaM/nQ9os/1RczW+s0nXe0CnlM=; b=aoRn86R51/XbDJekRNtAG+GYTHTUukca+quZqdJrsYWh/yYWNjBX07E3wGhjtkFveK xizBr0JC/PcrvBhRtCd35kEG0tzmKWeRXHctYjyTpXVC4Yujf3ceRKmB0nM5QKSEXcti OxmbAU1RvbhWN4GsYeKY506t11LhUJGwje5s9wCYL6XhnFkBmQhrPOQ0iQ6B5B9QjXEC y6WYEATG0OkAEh2iLPfhvlum0fI1k09mJD5PFZw6ayXA14gC04+UAXr0DsB6hCD4skpJ NR8BCXOfHEc9ivCSb/VT1PoMCFYBXpmWJ1L/29OAzxVvq4jx1m8TjYBUUxD/9/i3hrk4 Z35A== X-Gm-Message-State: AOAM531Z5hEUAtZSi/sVdGbFqqduUvFmrA5JLfXvRAiyM1qtzMiNsj+o Q9HnpzNa/AX9bM8FWNQXvA== X-Google-Smtp-Source: ABdhPJwgJn7aeZ8zCXOQwqnAD2VEZKNdyYfV8x1BfKUkOMGErVQR7l0m5hQ7mxJhgu8/lVoowdOfmw== X-Received: by 2002:aca:d6d3:: with SMTP id n202mr3608860oig.74.1604524085067; Wed, 04 Nov 2020 13:08:05 -0800 (PST) Received: from xps15 (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id p72sm803239oop.28.2020.11.04.13.08.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Nov 2020 13:08:04 -0800 (PST) Received: (nullmailer pid 4127142 invoked by uid 1000); Wed, 04 Nov 2020 21:08:03 -0000 Date: Wed, 4 Nov 2020 15:08:03 -0600 From: Rob Herring To: Amelie DELAUNAY Cc: Greg Kroah-Hartman , Maxime Coquelin , Alexandre Torgue , Russell King , Heikki Krogerus , devicetree@vger.kernel.org, "linux-kernel@vger.kernel.org" , Linux USB List , "moderated list:ARM/STM32 ARCHITECTURE" , linux-arm-kernel , Fabrice Gasnier Subject: Re: [RESEND PATCH v3 1/4] dt-bindings: connector: add power-opmode optional property to usb-connector Message-ID: <20201104210803.GA4115079@bogus> References: <20201029095806.10648-1-amelie.delaunay@st.com> <20201029095806.10648-2-amelie.delaunay@st.com> <20201029154016.GA1917373@bogus> <860d5620-4fdf-6e01-9a04-3967d6fcfd6b@st.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 30, 2020 at 04:27:14PM +0100, Amelie DELAUNAY wrote: > > > On 10/30/20 3:29 PM, Rob Herring wrote: > > On Thu, Oct 29, 2020 at 11:49 AM Amelie DELAUNAY wrote: > > > > > > > > > > > > On 10/29/20 4:40 PM, Rob Herring wrote: > > > > On Thu, Oct 29, 2020 at 10:58:03AM +0100, Amelie Delaunay wrote: > > > > > Power operation mode may depends on hardware design, so, add the optional > > > > > property power-opmode for usb-c connector to select the power operation > > > > > mode capability. > > > > > > > > > > Signed-off-by: Amelie Delaunay > > > > > --- > > > > > .../bindings/connector/usb-connector.yaml | 18 ++++++++++++++++++ > > > > > 1 file changed, 18 insertions(+) > > > > > > > > > > diff --git a/Documentation/devicetree/bindings/connector/usb-connector.yaml b/Documentation/devicetree/bindings/connector/usb-connector.yaml > > > > > index 728f82db073d..200d19c60fd5 100644 > > > > > --- a/Documentation/devicetree/bindings/connector/usb-connector.yaml > > > > > +++ b/Documentation/devicetree/bindings/connector/usb-connector.yaml > > > > > @@ -93,6 +93,24 @@ properties: > > > > > - device > > > > > - dual > > > > > > > > > > + power-opmode: > > > > > > > > I've acked this version: > > > > > > > > https://lore.kernel.org/r/20201020093627.256885-2-badhri@google.com > > > > > > > > > > frs is used for Fast Role Swap defined in USB PD spec. > > > I understand it allows to get the same information but I'm wondering why > > > the property name is limited to -frs- in this case. What about a > > > non-power delivery USB-C connector ? > > > > I've got no idea. The folks that know USB-C and PD details need to get > > together and work all this out. To me, it looks like the same thing... > > > > It looks but... > > The purpose of power-opmode property is to configure the USB-C controllers, > especially the non-PD USB-C controllers to determine the power operation > mode that the Type C connector will support and will advertise through CC > pins when it has no power delivery support, whatever the power role: Sink, > Source or Dual > The management of the property is the same that data-role and power-role > properties, and done by USB Type-C Connector Class. > > new-source-frs-typec-current specifies initial current capability of the new > source when vSafe5V is applied during PD3.0 Fast Role Swap. So here, this > property is not applied at usb-c controller configuration level, but during > PD Fast Role Swap, so when the Sink become the Source. > Moreover, the related driver code says FRS can only be supported by DRP > ports. So new-source-frs-typec-current property, in addition to being > specific to PD, is also dedicated to DRP usb-c controller. > The property is managed by Type-C Port Controller Manager for PD. But it's the same set of possible values, right? So we can align the values at least. Can we align the names in some way? power-opmode and frs-source-opmode or ?? Are these 2 properties mutually exclusive? If so, that should be captured. Rob