From: Vincent Whitchurch <vincent.whitchurch@axis.com>
To: Rob Herring <robh@kernel.org>
Cc: "lgirdwood@gmail.com" <lgirdwood@gmail.com>,
"broonie@kernel.org" <broonie@kernel.org>,
kernel <kernel@axis.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"support.opensource@diasemi.com" <support.opensource@diasemi.com>
Subject: Re: [PATCH v2 1/2] dt-bindings: regulator: Add DA9121
Date: Thu, 5 Nov 2020 10:39:26 +0100 [thread overview]
Message-ID: <20201105093926.msls7vgl42z7cpjy@axis.com> (raw)
In-Reply-To: <20201104185755.GA3948381@bogus>
On Wed, Nov 04, 2020 at 07:57:55PM +0100, Rob Herring wrote:
> On Tue, 03 Nov 2020 11:00:20 +0100, Vincent Whitchurch wrote:
> > Add bindings for the Dialog Semiconductor DA9121 voltage regulator.
> >
> > Signed-off-by: Vincent Whitchurch <vincent.whitchurch@axis.com>
> > ---
> > .../bindings/regulator/dlg,da9121.yaml | 47 +++++++++++++++++++
> > 1 file changed, 47 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/regulator/dlg,da9121.yaml
> >
>
> My bot found errors running 'make dt_binding_check' on your patch:
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/regulator/dlg,da9121.yaml: 'additionalProperties' is a required property
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/regulator/dlg,da9121.yaml: ignoring, error in schema:
> warning: no schema found in file: ./Documentation/devicetree/bindings/regulator/dlg,da9121.yaml
>
> See https://patchwork.ozlabs.org/patch/1392753
OK, thanks. I'll fix it by changing the unevaluatedProperties to an
additionalProperties (since the $ref has moved).
I think I should also move the unevaluatedProperties to the buck1 level
instead of removing it completely, because I see a bunch of other
regulator bindings doing it, but the checks don't complain about that
being missing and I can't see that making any difference for the
validation.
For example, I was hoping that this:
buck1:
description:
Initial data for the Buck1 regulator.
$ref: "regulator.yaml#"
type: object
unevaluatedProperties: false
would complain about something like:
buck1 {
not-a-real-property;
regulator-min-microvolt = <680000>;
regulator-max-microvolt = <820000>;
};
but it doesn't, so I don't quite understand what "unevaluatedProperties:
false" prevents.
>
> The base for the patch is generally the last rc1. Any dependencies
> should be noted.
>
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
>
> pip3 install dtschema --upgrade
Not sure if it's just something wrong in my setup, but I had dtschema
installed from master a while ago, and the above command didn't upgrade
it for me. I had to explicitly upgrade it with the full URL again to
get the latest version:
pip3 install --upgrade git+https://github.com/devicetree-org/dt-schema.git@master
next prev parent reply other threads:[~2020-11-05 9:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-03 10:00 [PATCH v2 0/2] DA9121 regulator support Vincent Whitchurch
2020-11-03 10:00 ` [PATCH v2 1/2] dt-bindings: regulator: Add DA9121 Vincent Whitchurch
2020-11-04 18:57 ` Rob Herring
2020-11-05 9:39 ` Vincent Whitchurch [this message]
2020-11-20 20:32 ` Rob Herring
2020-11-03 10:00 ` [PATCH v2 2/2] regulator: Add support for DA9121 regulator Vincent Whitchurch
2020-11-03 18:15 ` [PATCH v2 0/2] DA9121 regulator support Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201105093926.msls7vgl42z7cpjy@axis.com \
--to=vincent.whitchurch@axis.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@axis.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=support.opensource@diasemi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).