From: Maxime Ripard <maxime@cerno.tech>
To: Samuel Holland <samuel@sholland.org>
Cc: Chen-Yu Tsai <wens@csie.org>,
Jernej Skrabec <jernej.skrabec@siol.net>,
linux-arm-kernel@lists.infradead.org,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-sunxi@googlegroups.com, Ondrej Jirman <megous@megous.com>
Subject: Re: [PATCH 5/6] arm64: dts: allwinner: pinephone: Add WiFi support
Date: Thu, 5 Nov 2020 12:24:08 +0100 [thread overview]
Message-ID: <20201105112408.nzcly24holmpdusm@gilmour.lan> (raw)
In-Reply-To: <20201105054135.24860-6-samuel@sholland.org>
[-- Attachment #1: Type: text/plain, Size: 1325 bytes --]
On Wed, Nov 04, 2020 at 11:41:34PM -0600, Samuel Holland wrote:
> From: Ondrej Jirman <megous@megous.com>
>
> The PinePhone has a Realtek rtl8723cs WiFi module.
>
> On mainboard revisions 1.0 and 1.1, the reset input is always pulled
> high, so no power sequence is needed. On mainboard revision 1.2, the
> reset input is connected to PL2.
>
> Signed-off-by: Ondrej Jirman <megous@megous.com>
> Signed-off-by: Samuel Holland <samuel@sholland.org>
> ---
> .../allwinner/sun50i-a64-pinephone-1.2.dts | 9 ++++++++
> .../dts/allwinner/sun50i-a64-pinephone.dtsi | 22 +++++++++++++++++++
> 2 files changed, 31 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone-1.2.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone-1.2.dts
> index 94e4f11e0215..e7cf9d8577c1 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone-1.2.dts
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone-1.2.dts
> @@ -8,6 +8,11 @@
> / {
> model = "Pine64 PinePhone (1.2)";
> compatible = "pine64,pinephone-1.2", "allwinner,sun50i-a64";
> +
> + wifi_pwrseq: wifi_pwrseq {
> + compatible = "mmc-pwrseq-simple";
> + reset-gpios = <&r_pio 0 2 GPIO_ACTIVE_LOW>; /* PL2 */
> + };
Underscores are not valid in node names. I've fixed it while applying
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2020-11-05 11:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-05 5:41 [PATCH 0/6] PinePhone Device Tree Enhancements Samuel Holland
2020-11-05 5:41 ` [PATCH 1/6] arm64: dts: allwinner: pinephone: Remove AC power supply Samuel Holland
2020-11-05 5:41 ` [PATCH 2/6] arm64: dts: allwinner: pinephone: Set ALDO3 to exactly 3v0 Samuel Holland
2020-11-05 5:41 ` [PATCH 3/6] arm64: dts: allwinner: pinephone: Add LED flash Samuel Holland
2020-11-05 5:41 ` [PATCH 4/6] arm64: dts: allwinner: pinephone: Add light/proximity sensor Samuel Holland
2020-11-05 11:23 ` Maxime Ripard
2020-11-05 5:41 ` [PATCH 5/6] arm64: dts: allwinner: pinephone: Add WiFi support Samuel Holland
2020-11-05 11:24 ` Maxime Ripard [this message]
2020-11-05 5:41 ` [PATCH 6/6] arm64: dts: allwinner: pinephone: Add Bluetooth support Samuel Holland
2020-11-05 11:25 ` [PATCH 0/6] PinePhone Device Tree Enhancements Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201105112408.nzcly24holmpdusm@gilmour.lan \
--to=maxime@cerno.tech \
--cc=devicetree@vger.kernel.org \
--cc=jernej.skrabec@siol.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=megous@megous.com \
--cc=robh+dt@kernel.org \
--cc=samuel@sholland.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).