From: Feng Tang <feng.tang@intel.com>
To: Michal Hocko <mhocko@suse.com>
Cc: Vlastimil Babka <vbabka@suse.cz>,
Andrew Morton <akpm@linux-foundation.org>,
Johannes Weiner <hannes@cmpxchg.org>,
Matthew Wilcox <willy@infradead.org>,
Mel Gorman <mgorman@suse.de>,
dave.hansen@intel.com, ying.huang@intel.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 0/2] mm: fix OOMs for binding workloads to movable zone only node
Date: Thu, 5 Nov 2020 21:07:10 +0800 [thread overview]
Message-ID: <20201105130710.GB16525@shbuild999.sh.intel.com> (raw)
In-Reply-To: <20201105125828.GG21348@dhcp22.suse.cz>
On Thu, Nov 05, 2020 at 01:58:28PM +0100, Michal Hocko wrote:
> On Thu 05-11-20 13:53:24, Vlastimil Babka wrote:
> > On 11/5/20 1:08 PM, Michal Hocko wrote:
> > > On Thu 05-11-20 09:40:28, Feng Tang wrote:
> > > > > > Could you be more specific? This sounds like a bug. Allocations
> > > > > shouldn't spill over to a node which is not in the cpuset. There are few
> > > > > exceptions like IRQ context but that shouldn't happen regurarly.
> > > >
> > > > I mean when the docker starts, it will spawn many processes which obey
> > > > the mem binding set, and they have some kernel page requests, which got
> > > > successfully allocated, like the following callstack:
> > > >
> > > > [ 567.044953] CPU: 1 PID: 2021 Comm: runc:[1:CHILD] Tainted: G W I 5.9.0-rc8+ #6
> > > > [ 567.044956] Hardware name: /NUC6i5SYB, BIOS SYSKLi35.86A.0051.2016.0804.1114 08/04/2016
> > > > [ 567.044958] Call Trace:
> > > > [ 567.044972] dump_stack+0x74/0x9a
> > > > [ 567.044978] __alloc_pages_nodemask.cold+0x22/0xe5
> > > > [ 567.044986] alloc_pages_current+0x87/0xe0
> > > > [ 567.044991] allocate_slab+0x2e5/0x4f0
> > > > [ 567.044996] ___slab_alloc+0x380/0x5d0
> > > > [ 567.045021] __slab_alloc+0x20/0x40
> > > > [ 567.045025] kmem_cache_alloc+0x2a0/0x2e0
> > > > [ 567.045033] mqueue_alloc_inode+0x1a/0x30
> > > > [ 567.045041] alloc_inode+0x22/0xa0
> > > > [ 567.045045] new_inode_pseudo+0x12/0x60
> > > > [ 567.045049] new_inode+0x17/0x30
> > > > [ 567.045052] mqueue_get_inode+0x45/0x3b0
> > > > [ 567.045060] mqueue_fill_super+0x41/0x70
> > > > [ 567.045067] vfs_get_super+0x7f/0x100
> > > > [ 567.045074] get_tree_keyed+0x1d/0x20
> > > > [ 567.045080] mqueue_get_tree+0x1c/0x20
> > > > [ 567.045086] vfs_get_tree+0x2a/0xc0
> > > > [ 567.045092] fc_mount+0x13/0x50
> > > > [ 567.045099] mq_create_mount+0x92/0xe0
> > > > [ 567.045102] mq_init_ns+0x3b/0x50
> > > > [ 567.045106] copy_ipcs+0x10a/0x1b0
> > > > [ 567.045113] create_new_namespaces+0xa6/0x2b0
> > > > [ 567.045118] unshare_nsproxy_namespaces+0x5a/0xb0
> > > > [ 567.045124] ksys_unshare+0x19f/0x360
> > > > [ 567.045129] __x64_sys_unshare+0x12/0x20
> > > > [ 567.045135] do_syscall_64+0x38/0x90
> > > > [ 567.045143] entry_SYSCALL_64_after_hwframe+0x44/0xa9
> > > >
> > > > For it, the __alloc_pages_nodemask() will first try process's targed
> > > > nodemask(unmovable node here), and there is no availabe zone, so it
> > > > goes with the NULL nodemask, and get a page in the slowpath.
> > >
> > > OK, I see your point now. I was not aware of the slab allocator not
> > > following cpusets. Sounds like a bug to me.
> >
> > SLAB and SLUB seem to not care about cpusets in the fast path.
>
> Is a fallback to a different node which is outside of the cpuset
> possible?
My debug traces shows it is, and its gfp_mask is 'GFP_KERNEL'
And actually in this usage, I seen other types of kernel allocation
request got fallback to the normal node which is not in cpuset mem
nodemasks, like
[ 567.510901] CPU: 3 PID: 2022 Comm: runc:[2:INIT] Tainted: G W I 5.9.0-rc8+ #6
[ 567.510902] Hardware name: /NUC6i5SYB, BIOS SYSKLi35.86A.0051.2016.0804.1114 08/04/2016
[ 567.510903] Call Trace:
[ 567.510909] dump_stack+0x74/0x9a
[ 567.510910] __alloc_pages_nodemask.cold+0x22/0xe5
[ 567.510913] alloc_pages_current+0x87/0xe0
[ 567.510914] __vmalloc_node_range+0x14c/0x240
[ 567.510918] module_alloc+0x82/0xe0
[ 567.510921] bpf_jit_alloc_exec+0xe/0x10
[ 567.510922] bpf_jit_binary_alloc+0x7a/0x120
[ 567.510925] bpf_int_jit_compile+0x145/0x424
[ 567.510926] bpf_prog_select_runtime+0xac/0x130
[ 567.510928] bpf_prepare_filter+0x44c/0x4b0
[ 567.510932] bpf_prog_create_from_user+0xc7/0x120
[ 567.510934] do_seccomp+0x118/0x990
[ 567.510937] __x64_sys_seccomp+0x1a/0x20
[ 567.510939] do_syscall_64+0x38/0x90
And its gfp_mask is (GFP_KERNEL|__GFP_HIGHMEM|__GFP_NOWARN)
Thanks,
Feng
> > But this
> > stack shows that it went all the way to the page allocator, so the cpusets
> > should have been obeyed there at least.
>
> Looking closer what is this dump_stack saying actually?
>
> --
> Michal Hocko
> SUSE Labs
next prev parent reply other threads:[~2020-11-05 13:07 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-04 6:10 [RFC PATCH 0/2] mm: fix OOMs for binding workloads to movable zone only node Feng Tang
2020-11-04 6:10 ` [RFC PATCH 1/2] mm, oom: dump meminfo for all memory nodes Feng Tang
2020-11-04 7:18 ` Michal Hocko
2020-11-04 6:10 ` [RFC PATCH 2/2] mm, page_alloc: loose the node binding check to avoid helpless oom killing Feng Tang
2020-11-04 7:23 ` Michal Hocko
2020-11-04 7:13 ` [RFC PATCH 0/2] mm: fix OOMs for binding workloads to movable zone only node Michal Hocko
2020-11-04 7:38 ` Feng Tang
2020-11-04 7:58 ` Michal Hocko
2020-11-04 8:40 ` Feng Tang
2020-11-04 8:53 ` Michal Hocko
2020-11-05 1:40 ` Feng Tang
2020-11-05 12:08 ` Michal Hocko
2020-11-05 12:53 ` Vlastimil Babka
2020-11-05 12:58 ` Michal Hocko
2020-11-05 13:07 ` Feng Tang [this message]
2020-11-05 13:12 ` Michal Hocko
2020-11-05 13:43 ` Feng Tang
2020-11-05 16:16 ` Michal Hocko
2020-11-06 7:06 ` Feng Tang
2020-11-06 8:10 ` Michal Hocko
2020-11-06 9:08 ` Feng Tang
2020-11-06 10:35 ` Michal Hocko
2020-11-05 13:14 ` Vlastimil Babka
2020-11-05 13:19 ` Michal Hocko
2020-11-05 13:34 ` Vlastimil Babka
2020-11-06 4:32 ` Huang, Ying
2020-11-06 7:43 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201105130710.GB16525@shbuild999.sh.intel.com \
--to=feng.tang@intel.com \
--cc=akpm@linux-foundation.org \
--cc=dave.hansen@intel.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mhocko@suse.com \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).