From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5144EC55179 for ; Thu, 5 Nov 2020 14:03:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F3E232074B for ; Thu, 5 Nov 2020 14:03:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731033AbgKEODi (ORCPT ); Thu, 5 Nov 2020 09:03:38 -0500 Received: from foss.arm.com ([217.140.110.172]:33408 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729990AbgKEODh (ORCPT ); Thu, 5 Nov 2020 09:03:37 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 07E511509; Thu, 5 Nov 2020 06:03:37 -0800 (PST) Received: from localhost (e108754-lin.cambridge.arm.com [10.1.198.32]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 9D5763F719; Thu, 5 Nov 2020 06:03:36 -0800 (PST) Date: Thu, 5 Nov 2020 14:03:35 +0000 From: Ionela Voinescu To: "Rafael J. Wysocki" Cc: Ingo Molnar , Peter Zijlstra , Vincent Guittot , Catalin Marinas , Will Deacon , "Rafael J. Wysocki" , Viresh Kumar , Dietmar Eggemann , Quentin Perret , Valentin Schneider , Linux PM , Linux ARM , Linux Kernel Mailing List Subject: Re: [PATCH RESEND v2 1/3] sched/topology,schedutil: wrap sched domains rebuild Message-ID: <20201105140335.GA22244@arm.com> References: <20201027180713.7642-1-ionela.voinescu@arm.com> <20201027180713.7642-2-ionela.voinescu@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Rafael, On Friday 30 Oct 2020 at 16:26:32 (+0100), Rafael J. Wysocki wrote: > On Tue, Oct 27, 2020 at 7:08 PM Ionela Voinescu wrote: > > > > Add the rebuild_sched_domains_energy() function to wrap the functionality > > that rebuilds the scheduling domains if any of the Energy Aware Scheduling > > (EAS) initialisation conditions change. This functionality is used when > > schedutil is added or removed or when EAS is enabled or disabled > > through the sched_energy_aware sysctl. > > > > Therefore, create a single function that is used in both these cases and > > that can be later reused. > > > > Signed-off-by: Ionela Voinescu > > Acked-by: Quentin Perret > > Cc: Ingo Molnar > > Cc: Peter Zijlstra > > Cc: Rafael J. Wysocki > > Cc: Viresh Kumar > > For the schedutil part: > > Acked-by: Rafael J. Wysocki > Thank you for taking a look! > and I'm assuming the patch to be taken care of by Peter. I'm hoping that as well. I'll ask some of the arm64 folk to take another look over 2/3 to make sure that's covered. Many thanks, Ionela.