From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Bhaumik Bhatt <bbhatt@codeaurora.org>
Cc: linux-arm-msm@vger.kernel.org, hemantk@codeaurora.org,
jhugo@codeaurora.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 5/6] bus: mhi: core: Rename RDDM download function to use proper words
Date: Fri, 6 Nov 2020 11:02:54 +0530 [thread overview]
Message-ID: <20201106053254.GF3473@work> (raw)
In-Reply-To: <1604622869-40212-6-git-send-email-bbhatt@codeaurora.org>
On Thu, Nov 05, 2020 at 04:34:28PM -0800, Bhaumik Bhatt wrote:
> mhi_download_rddm_img() uses a shorter version of the word image.
> Expand it and rename the function to mhi_download_rddm_image().
>
> Signed-off-by: Bhaumik Bhatt <bbhatt@codeaurora.org>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Thanks,
Mani
> ---
> drivers/bus/mhi/core/boot.c | 4 ++--
> include/linux/mhi.h | 6 +++---
> 2 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/bus/mhi/core/boot.c b/drivers/bus/mhi/core/boot.c
> index 6b6fd96..16244cc 100644
> --- a/drivers/bus/mhi/core/boot.c
> +++ b/drivers/bus/mhi/core/boot.c
> @@ -147,7 +147,7 @@ static int __mhi_download_rddm_in_panic(struct mhi_controller *mhi_cntrl)
> }
>
> /* Download RDDM image from device */
> -int mhi_download_rddm_img(struct mhi_controller *mhi_cntrl, bool in_panic)
> +int mhi_download_rddm_image(struct mhi_controller *mhi_cntrl, bool in_panic)
> {
> void __iomem *base = mhi_cntrl->bhie;
> struct device *dev = &mhi_cntrl->mhi_dev->dev;
> @@ -169,7 +169,7 @@ int mhi_download_rddm_img(struct mhi_controller *mhi_cntrl, bool in_panic)
>
> return (rx_status == BHIE_RXVECSTATUS_STATUS_XFER_COMPL) ? 0 : -EIO;
> }
> -EXPORT_SYMBOL_GPL(mhi_download_rddm_img);
> +EXPORT_SYMBOL_GPL(mhi_download_rddm_image);
>
> static int mhi_fw_load_amss(struct mhi_controller *mhi_cntrl,
> const struct mhi_buf *mhi_buf)
> diff --git a/include/linux/mhi.h b/include/linux/mhi.h
> index 9225d55..52b3c60 100644
> --- a/include/linux/mhi.h
> +++ b/include/linux/mhi.h
> @@ -645,12 +645,12 @@ int mhi_pm_suspend(struct mhi_controller *mhi_cntrl);
> int mhi_pm_resume(struct mhi_controller *mhi_cntrl);
>
> /**
> - * mhi_download_rddm_img - Download ramdump image from device for
> - * debugging purpose.
> + * mhi_download_rddm_image - Download ramdump image from device for
> + * debugging purpose.
> * @mhi_cntrl: MHI controller
> * @in_panic: Download rddm image during kernel panic
> */
> -int mhi_download_rddm_img(struct mhi_controller *mhi_cntrl, bool in_panic);
> +int mhi_download_rddm_image(struct mhi_controller *mhi_cntrl, bool in_panic);
>
> /**
> * mhi_force_rddm_mode - Force device into rddm mode
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>
next prev parent reply other threads:[~2020-11-06 5:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-06 0:34 [PATCH v1 0/6] Minor bug fixes and clean-up for MHI host driver Bhaumik Bhatt
2020-11-06 0:34 ` [PATCH v1 1/6] bus: mhi: core: Remove unnecessary counter from mhi_firmware_copy() Bhaumik Bhatt
2020-11-06 5:25 ` Manivannan Sadhasivam
2020-11-06 0:34 ` [PATCH v1 2/6] bus: mhi: core: Add missing EXPORT_SYMBOL for mhi_get_mhi_state() Bhaumik Bhatt
2020-11-06 5:28 ` Manivannan Sadhasivam
2020-11-06 0:34 ` [PATCH v1 3/6] bus: mhi: core: Expose mhi_get_exec_env() API for controllers Bhaumik Bhatt
2020-11-06 5:29 ` Manivannan Sadhasivam
2020-11-06 0:34 ` [PATCH v1 4/6] bus: mhi: core: Remove unused mhi_fw_load_worker() declaration Bhaumik Bhatt
2020-11-06 5:30 ` Manivannan Sadhasivam
2020-11-06 0:34 ` [PATCH v1 5/6] bus: mhi: core: Rename RDDM download function to use proper words Bhaumik Bhatt
2020-11-06 5:32 ` Manivannan Sadhasivam [this message]
2020-11-06 0:34 ` [PATCH v1 6/6] bus: mhi: core: Skip RDDM download for unknown execution environment Bhaumik Bhatt
2020-11-06 5:38 ` Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201106053254.GF3473@work \
--to=manivannan.sadhasivam@linaro.org \
--cc=bbhatt@codeaurora.org \
--cc=hemantk@codeaurora.org \
--cc=jhugo@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).