* [PATCH] nvme: Simplify the nvme_req_qid()
@ 2020-10-27 8:15 Baolin Wang
2020-11-02 11:44 ` Baolin Wang
2020-11-06 13:56 ` Christoph Hellwig
0 siblings, 2 replies; 4+ messages in thread
From: Baolin Wang @ 2020-10-27 8:15 UTC (permalink / raw)
To: kbusch, axboe, hch, sagi
Cc: baolin.wang, baolin.wang7, linux-nvme, linux-kernel
Use the request's '->mq_hctx->queue_num' directly to simplify the
nvme_req_qid() function.
Signed-off-by: Baolin Wang <baolin.wang@linux.alibaba.com>
---
drivers/nvme/host/nvme.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/nvme/host/nvme.h b/drivers/nvme/host/nvme.h
index cc11113..0b62b62 100644
--- a/drivers/nvme/host/nvme.h
+++ b/drivers/nvme/host/nvme.h
@@ -178,7 +178,8 @@ static inline u16 nvme_req_qid(struct request *req)
{
if (!req->q->queuedata)
return 0;
- return blk_mq_unique_tag_to_hwq(blk_mq_unique_tag(req)) + 1;
+
+ return req->mq_hctx->queue_num + 1;
}
/* The below value is the specific amount of delay needed before checking
--
1.8.3.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] nvme: Simplify the nvme_req_qid()
2020-10-27 8:15 [PATCH] nvme: Simplify the nvme_req_qid() Baolin Wang
@ 2020-11-02 11:44 ` Baolin Wang
2020-11-02 18:02 ` Christoph Hellwig
2020-11-06 13:56 ` Christoph Hellwig
1 sibling, 1 reply; 4+ messages in thread
From: Baolin Wang @ 2020-11-02 11:44 UTC (permalink / raw)
To: kbusch, axboe, hch, sagi; +Cc: baolin.wang7, linux-nvme, linux-kernel
Hi,
> Use the request's '->mq_hctx->queue_num' directly to simplify the
> nvme_req_qid() function.
>
> Signed-off-by: Baolin Wang <baolin.wang@linux.alibaba.com>
Gentle ping?
> ---
> drivers/nvme/host/nvme.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/nvme/host/nvme.h b/drivers/nvme/host/nvme.h
> index cc11113..0b62b62 100644
> --- a/drivers/nvme/host/nvme.h
> +++ b/drivers/nvme/host/nvme.h
> @@ -178,7 +178,8 @@ static inline u16 nvme_req_qid(struct request *req)
> {
> if (!req->q->queuedata)
> return 0;
> - return blk_mq_unique_tag_to_hwq(blk_mq_unique_tag(req)) + 1;
> +
> + return req->mq_hctx->queue_num + 1;
> }
>
> /* The below value is the specific amount of delay needed before checking
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] nvme: Simplify the nvme_req_qid()
2020-11-02 11:44 ` Baolin Wang
@ 2020-11-02 18:02 ` Christoph Hellwig
0 siblings, 0 replies; 4+ messages in thread
From: Christoph Hellwig @ 2020-11-02 18:02 UTC (permalink / raw)
To: Baolin Wang
Cc: kbusch, axboe, hch, sagi, baolin.wang7, linux-nvme, linux-kernel
On Mon, Nov 02, 2020 at 07:44:21PM +0800, Baolin Wang wrote:
> Hi,
>
>> Use the request's '->mq_hctx->queue_num' directly to simplify the
>> nvme_req_qid() function.
>>
>> Signed-off-by: Baolin Wang <baolin.wang@linux.alibaba.com>
>
> Gentle ping?
As this clearly isn't 5.10 material it will have to wait for the 5.11
branch like everyone else.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] nvme: Simplify the nvme_req_qid()
2020-10-27 8:15 [PATCH] nvme: Simplify the nvme_req_qid() Baolin Wang
2020-11-02 11:44 ` Baolin Wang
@ 2020-11-06 13:56 ` Christoph Hellwig
1 sibling, 0 replies; 4+ messages in thread
From: Christoph Hellwig @ 2020-11-06 13:56 UTC (permalink / raw)
To: Baolin Wang
Cc: kbusch, axboe, hch, sagi, baolin.wang7, linux-nvme, linux-kernel
Thanks,
applied to nvme-5.11
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-11-06 13:56 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-27 8:15 [PATCH] nvme: Simplify the nvme_req_qid() Baolin Wang
2020-11-02 11:44 ` Baolin Wang
2020-11-02 18:02 ` Christoph Hellwig
2020-11-06 13:56 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).