From: Jakub Kicinski <kuba@kernel.org>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Networking <netdev@vger.kernel.org>,
Arnd Bergmann <arnd@arndb.de>,
"David S. Miller" <davem@davemloft.net>,
Christoph Hellwig <hch@infradead.org>,
Jiri Pirko <jiri@mellanox.com>, Taehee Yoo <ap420073@gmail.com>,
Eric Dumazet <edumazet@google.com>,
Alexei Starovoitov <ast@kernel.org>, Andrew Lunn <andrew@lunn.ch>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next v3 0/4] remove compat_alloc_user_space()
Date: Fri, 6 Nov 2020 14:46:16 -0800 [thread overview]
Message-ID: <20201106144616.28d074a6@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <CAK8P3a0soc41M-s0nd9xQgztyVCHNy8VJpQ9jmzi-N0Z0rGfRQ@mail.gmail.com>
On Fri, 6 Nov 2020 22:48:18 +0100 Arnd Bergmann wrote:
> On Fri, Nov 6, 2020 at 6:32 PM Arnd Bergmann <arnd@kernel.org> wrote:
> >
> > From: Arnd Bergmann <arnd@arndb.de>
> >
> > This is the third version of my seires, now spanning four patches
> > instead of two, with a new approach for handling struct ifreq
> > compatibility after I realized that my earlier approach introduces
> > additional problems.
> >
> > The idea here is to always push down the compat conversion
> > deeper into the call stack: rather than pretending to be
> > native mode with a modified copy of the original data on
> > the user space stack, have the code that actually works on
> > the data understand the difference between native and compat
> > versions.
> >
> > I have spent a long time looking at all drivers that implement
> > an ndo_do_ioctl callback to verify that my assumptions are
> > correct. This has led to a series of 29 additional patches
> > that I am not including here but will post separately, fixing
> > a number of bugs in SIOCDEVPRIVATE ioctls, removing dead
> > code, and splitting ndo_do_ioctl into two new ndo callbacks
> > for private and ethernet specific commands.
>
> I got a reply from the build bots that the version I sent was broken
> on 32-bit machines, so don't merge it just yet. Let me know if
> there are any other comments I should address before resending
> though.
Looks like patch 4 also breaks 64 bit allmodconfig build.
Beyond that - patches 1 and 4 warrant need a second look at:
checkpatch.pl --strict --min-conf-desc-length=80
prev parent reply other threads:[~2020-11-06 22:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-06 17:32 [PATCH net-next v3 0/4] remove compat_alloc_user_space() Arnd Bergmann
2020-11-06 17:32 ` [PATCH net-next v3 1/4] ethtool: improve compat ioctl handling Arnd Bergmann
2020-11-06 17:32 ` [PATCH net-next v3 2/4] net: socket: rework SIOC?IFMAP ioctls Arnd Bergmann
2020-11-06 17:32 ` [PATCH net-next v3 3/4] net: socket: simplify dev_ifconf handling Arnd Bergmann
2020-11-06 17:32 ` [PATCH net-next v3 4/4] net: socket: rework compat_ifreq_ioctl() Arnd Bergmann
2020-11-06 21:48 ` [PATCH net-next v3 0/4] remove compat_alloc_user_space() Arnd Bergmann
2020-11-06 22:46 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201106144616.28d074a6@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=ap420073@gmail.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=ast@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hch@infradead.org \
--cc=jiri@mellanox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).