* [PATCH net] net: marvell: prestera: fix compilation with CONFIG_BRIDGE=m
@ 2020-11-06 16:11 Vadym Kochan
2020-11-06 20:13 ` Randy Dunlap
2020-11-07 20:50 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 4+ messages in thread
From: Vadym Kochan @ 2020-11-06 16:11 UTC (permalink / raw)
To: Volodymyr Mytnyk, Andrii Savka, David S. Miller, Jakub Kicinski,
Vadym Kochan, Oleksandr Mazur, Serhiy Boiko, Serhiy Pshyk,
Taras Chornyi, netdev, linux-kernel
Cc: Mickey Rachamim
With CONFIG_BRIDGE=m the compilation fails:
ld: drivers/net/ethernet/marvell/prestera/prestera_switchdev.o: in function `prestera_bridge_port_event':
prestera_switchdev.c:(.text+0x2ebd): undefined reference to `br_vlan_enabled'
in case the driver is statically enabled.
Fix it by adding 'BRIDGE || BRIDGE=n' dependency.
Fixes: e1189d9a5fbe ("net: marvell: prestera: Add Switchdev driver implementation")
Reported-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Vadym Kochan <vadym.kochan@plvision.eu>
---
drivers/net/ethernet/marvell/prestera/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/marvell/prestera/Kconfig b/drivers/net/ethernet/marvell/prestera/Kconfig
index b1fcc44f566a..b6f20e2034c6 100644
--- a/drivers/net/ethernet/marvell/prestera/Kconfig
+++ b/drivers/net/ethernet/marvell/prestera/Kconfig
@@ -6,6 +6,7 @@
config PRESTERA
tristate "Marvell Prestera Switch ASICs support"
depends on NET_SWITCHDEV && VLAN_8021Q
+ depends on BRIDGE || BRIDGE=n
select NET_DEVLINK
help
This driver supports Marvell Prestera Switch ASICs family.
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH net] net: marvell: prestera: fix compilation with CONFIG_BRIDGE=m
2020-11-06 16:11 [PATCH net] net: marvell: prestera: fix compilation with CONFIG_BRIDGE=m Vadym Kochan
@ 2020-11-06 20:13 ` Randy Dunlap
2020-11-07 20:45 ` Jakub Kicinski
2020-11-07 20:50 ` patchwork-bot+netdevbpf
1 sibling, 1 reply; 4+ messages in thread
From: Randy Dunlap @ 2020-11-06 20:13 UTC (permalink / raw)
To: Vadym Kochan, Volodymyr Mytnyk, Andrii Savka, David S. Miller,
Jakub Kicinski, Oleksandr Mazur, Serhiy Boiko, Serhiy Pshyk,
Taras Chornyi, netdev, linux-kernel
Cc: Mickey Rachamim
On 11/6/20 8:11 AM, Vadym Kochan wrote:
> With CONFIG_BRIDGE=m the compilation fails:
>
> ld: drivers/net/ethernet/marvell/prestera/prestera_switchdev.o: in function `prestera_bridge_port_event':
> prestera_switchdev.c:(.text+0x2ebd): undefined reference to `br_vlan_enabled'
>
> in case the driver is statically enabled.
>
> Fix it by adding 'BRIDGE || BRIDGE=n' dependency.
>
> Fixes: e1189d9a5fbe ("net: marvell: prestera: Add Switchdev driver implementation")
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Signed-off-by: Vadym Kochan <vadym.kochan@plvision.eu>
Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested
Thanks.
> ---
> drivers/net/ethernet/marvell/prestera/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/marvell/prestera/Kconfig b/drivers/net/ethernet/marvell/prestera/Kconfig
> index b1fcc44f566a..b6f20e2034c6 100644
> --- a/drivers/net/ethernet/marvell/prestera/Kconfig
> +++ b/drivers/net/ethernet/marvell/prestera/Kconfig
> @@ -6,6 +6,7 @@
> config PRESTERA
> tristate "Marvell Prestera Switch ASICs support"
> depends on NET_SWITCHDEV && VLAN_8021Q
> + depends on BRIDGE || BRIDGE=n
> select NET_DEVLINK
> help
> This driver supports Marvell Prestera Switch ASICs family.
>
--
~Randy
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net] net: marvell: prestera: fix compilation with CONFIG_BRIDGE=m
2020-11-06 20:13 ` Randy Dunlap
@ 2020-11-07 20:45 ` Jakub Kicinski
0 siblings, 0 replies; 4+ messages in thread
From: Jakub Kicinski @ 2020-11-07 20:45 UTC (permalink / raw)
To: Randy Dunlap
Cc: Vadym Kochan, Volodymyr Mytnyk, Andrii Savka, David S. Miller,
Oleksandr Mazur, Serhiy Boiko, Serhiy Pshyk, Taras Chornyi,
netdev, linux-kernel, Mickey Rachamim
On Fri, 6 Nov 2020 12:13:12 -0800 Randy Dunlap wrote:
> On 11/6/20 8:11 AM, Vadym Kochan wrote:
> > With CONFIG_BRIDGE=m the compilation fails:
> >
> > ld: drivers/net/ethernet/marvell/prestera/prestera_switchdev.o: in function `prestera_bridge_port_event':
> > prestera_switchdev.c:(.text+0x2ebd): undefined reference to `br_vlan_enabled'
> >
> > in case the driver is statically enabled.
> >
> > Fix it by adding 'BRIDGE || BRIDGE=n' dependency.
> >
> > Fixes: e1189d9a5fbe ("net: marvell: prestera: Add Switchdev driver implementation")
> > Reported-by: Randy Dunlap <rdunlap@infradead.org>
> > Signed-off-by: Vadym Kochan <vadym.kochan@plvision.eu>
>
> Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested
Applied, thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net] net: marvell: prestera: fix compilation with CONFIG_BRIDGE=m
2020-11-06 16:11 [PATCH net] net: marvell: prestera: fix compilation with CONFIG_BRIDGE=m Vadym Kochan
2020-11-06 20:13 ` Randy Dunlap
@ 2020-11-07 20:50 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2020-11-07 20:50 UTC (permalink / raw)
To: Vadym Kochan
Cc: volodymyr.mytnyk, andrii.savka, davem, kuba, oleksandr.mazur,
serhiy.boiko, serhiy.pshyk, taras.chornyi, netdev, linux-kernel,
mickeyr
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
On Fri, 6 Nov 2020 18:11:25 +0200 you wrote:
> With CONFIG_BRIDGE=m the compilation fails:
>
> ld: drivers/net/ethernet/marvell/prestera/prestera_switchdev.o: in function `prestera_bridge_port_event':
> prestera_switchdev.c:(.text+0x2ebd): undefined reference to `br_vlan_enabled'
>
> in case the driver is statically enabled.
>
> [...]
Here is the summary with links:
- [net] net: marvell: prestera: fix compilation with CONFIG_BRIDGE=m
https://git.kernel.org/netdev/net/c/4e0396c59559
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-11-07 20:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-06 16:11 [PATCH net] net: marvell: prestera: fix compilation with CONFIG_BRIDGE=m Vadym Kochan
2020-11-06 20:13 ` Randy Dunlap
2020-11-07 20:45 ` Jakub Kicinski
2020-11-07 20:50 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).