From: Matthew Wilcox <willy@infradead.org>
To: Rong Chen <rong.a.chen@intel.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Johannes Weiner <hannes@cmpxchg.org>,
Alexey Dobriyan <adobriyan@gmail.com>,
Chris Wilson <chris@chris-wilson.co.uk>,
Huang Ying <ying.huang@intel.com>,
Hugh Dickins <hughd@google.com>,
Jani Nikula <jani.nikula@linux.intel.com>,
Matthew Auld <matthew.auld@intel.com>,
William Kucharski <william.kucharski@oracle.com>,
Qian Cai <cai@redhat.com>, LKML <linux-kernel@vger.kernel.org>,
lkp@lists.01.org, lkp@intel.com, feng.tang@intel.com,
zhengjun.xing@intel.com
Subject: Re: [mm] e6e88712e4: stress-ng.tmpfs.ops_per_sec -69.7% regression
Date: Fri, 6 Nov 2020 20:55:36 +0000 [thread overview]
Message-ID: <20201106205536.GS17076@casper.infradead.org> (raw)
In-Reply-To: <d57f327c-a22e-1fb0-26fe-68b4964e75dc@intel.com>
On Mon, Nov 02, 2020 at 01:21:39PM +0800, Rong Chen wrote:
> we compared the tmpfs.ops_per_sec: (363 / 103.02) between this commit and
> parent commit.
Thanks! I see about a 50% hit on my system, and this patch restores the
performance. Can you verify this works for you?
diff --git a/mm/madvise.c b/mm/madvise.c
index 9b065d412e5f..e602333f8c0d 100644
--- a/mm/madvise.c
+++ b/mm/madvise.c
@@ -225,7 +225,7 @@ static void force_shm_swapin_readahead(struct vm_area_struct *vma,
struct address_space *mapping)
{
XA_STATE(xas, &mapping->i_pages, linear_page_index(vma, start));
- pgoff_t end_index = end / PAGE_SIZE;
+ pgoff_t end_index = linear_page_index(vma, end + PAGE_SIZE - 1);
struct page *page;
rcu_read_lock();
next prev parent reply other threads:[~2020-11-06 20:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-30 7:17 [mm] e6e88712e4: stress-ng.tmpfs.ops_per_sec -69.7% regression kernel test robot
2020-10-30 13:17 ` Matthew Wilcox
2020-10-30 14:02 ` Chen, Rong A
2020-10-30 14:58 ` Matthew Wilcox
2020-10-31 6:10 ` [LKP] " Philip Li
2020-11-02 5:21 ` Rong Chen
2020-11-02 14:23 ` Matthew Wilcox
2020-11-06 20:55 ` Matthew Wilcox [this message]
2020-11-09 8:10 ` [LKP] " Xing Zhengjun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201106205536.GS17076@casper.infradead.org \
--to=willy@infradead.org \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=cai@redhat.com \
--cc=chris@chris-wilson.co.uk \
--cc=feng.tang@intel.com \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=jani.nikula@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=lkp@lists.01.org \
--cc=matthew.auld@intel.com \
--cc=rong.a.chen@intel.com \
--cc=torvalds@linux-foundation.org \
--cc=william.kucharski@oracle.com \
--cc=ying.huang@intel.com \
--cc=zhengjun.xing@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).