From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: "Rafael J . Wysocki" <rafael@kernel.org>,
linux-kernel@vger.kernel.org, Shawn Guo <shawnguo@kernel.org>,
Stephen Boyd <sboyd@kernel.org>,
Dong Aisheng <aisheng.dong@nxp.com>
Subject: Re: [PATCH RESEND] driver core: export device_is_bound() to fix build failure
Date: Sun, 8 Nov 2020 09:23:17 +0100 [thread overview]
Message-ID: <20201108082317.GA40741@kroah.com> (raw)
In-Reply-To: <20201107224727.11015-1-sudipm.mukherjee@gmail.com>
On Sat, Nov 07, 2020 at 10:47:27PM +0000, Sudip Mukherjee wrote:
> When CONFIG_MXC_CLK_SCU is configured as 'm' the build fails as it
> is unable to find device_is_bound(). The error being:
> ERROR: modpost: "device_is_bound" [drivers/clk/imx/clk-imx-scu.ko]
> undefined!
>
> Export the symbol so that the module finds it.
>
> Fixes: 77d8f3068c63 ("clk: imx: scu: add two cells binding support")
> Signed-off-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
> ---
>
> resending with the Fixes: tag.
>
> drivers/base/dd.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/base/dd.c b/drivers/base/dd.c
> index 148e81969e04..a796a57e5efb 100644
> --- a/drivers/base/dd.c
> +++ b/drivers/base/dd.c
> @@ -353,6 +353,7 @@ bool device_is_bound(struct device *dev)
> {
> return dev->p && klist_node_attached(&dev->p->knode_driver);
> }
> +EXPORT_SYMBOL(device_is_bound);
EXPORT_SYMBOL_GPL() please, like all the other exports in this file.
Also, wait, no, don't call this, are you sure you are calling it in a
race-free way? And what branch/tree is the above commit in?
thanks,
greg k-h
next prev parent reply other threads:[~2020-11-08 8:23 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-07 22:47 [PATCH RESEND] driver core: export device_is_bound() to fix build failure Sudip Mukherjee
2020-11-08 8:23 ` Greg Kroah-Hartman [this message]
2020-11-09 10:14 ` Sudip Mukherjee
2020-11-09 10:37 ` Greg Kroah-Hartman
2020-11-09 10:57 ` Aisheng Dong
2020-11-09 11:18 ` Sudip Mukherjee
2020-11-09 11:32 ` Aisheng Dong
2020-11-09 11:42 ` Greg Kroah-Hartman
2020-11-09 11:41 ` Greg Kroah-Hartman
2020-11-09 11:55 ` Aisheng Dong
2020-11-09 12:04 ` Greg Kroah-Hartman
2020-11-09 12:05 ` Greg Kroah-Hartman
2020-11-09 12:26 ` Aisheng Dong
2020-11-09 12:48 ` Greg Kroah-Hartman
2020-11-18 10:23 ` Aisheng Dong
2020-11-18 10:45 ` Greg Kroah-Hartman
2020-11-18 15:40 ` Aisheng Dong
2020-11-18 22:22 ` Saravana Kannan
2020-11-19 4:13 ` Aisheng Dong
2020-11-19 13:10 ` Greg Kroah-Hartman
2020-11-19 14:09 ` Aisheng Dong
2020-11-19 14:25 ` Greg Kroah-Hartman
2020-11-19 15:20 ` Aisheng Dong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201108082317.GA40741@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=aisheng.dong@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=sboyd@kernel.org \
--cc=shawnguo@kernel.org \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).