From: "Paul E. McKenney" <paulmck@kernel.org>
To: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: linux-kernel@vger.kernel.org, cgroups@vger.kernel.org,
Frederic Weisbecker <fweisbec@gmail.com>,
Josh Triplett <josh@joshtriplett.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@kernel.org>, Li Zefan <lizefan@huawei.com>
Subject: Re: [PATCH 0/4] RFC: support for global CPU list abbreviations
Date: Sun, 8 Nov 2020 10:02:22 -0800 [thread overview]
Message-ID: <20201108180222.GA17637@paulmck-ThinkPad-P72> (raw)
In-Reply-To: <20201108160816.896881-1-paul.gortmaker@windriver.com>
On Sun, Nov 08, 2020 at 11:08:12AM -0500, Paul Gortmaker wrote:
> The basic objective here was to add support for "nohz_full=8-last" and/or
> "rcu_nocbs="4-last" -- essentially introduce "last" as a portable
> reference evaluated at boot/runtime for anything using a CPU list.
>
> The thinking behind this, is that people carve off a few early CPUs to
> support housekeeping tasks, and perhaps dedicate one to a busy I/O
> peripheral, and then the remaining pool of CPUs out to the end are a
> part of a commonly configured pool used for the real work the user
> cares about.
>
> Extend that logic out to a fleet of machines - some new, and some
> nearing EOL, and you've probably got a wide range of core counts to
> contend with - even though the early number of cores dedicated to the
> system overhead probably doesn't vary.
>
> This change would enable sysadmins to have a common bootarg across all
> such systems, and would also avoid any off-by-one fencepost errors that
> happen for users who might briefly forget that core counts start at
> zero.
>
> Looking around before starting, I noticed RCU already had a short-form
> abbreviation "all" -- but if we want to treat CPU lists in a uniform
> matter, then tokens shouldn't be implemented at a subsystem level and
> hence be subsystem specific; each with their own variations.
>
> So I moved "all" to global use - for boot args, and for cgroups. Then
> I added the inverse "none" and finally, the one I wanted -- "last".
>
> The use of "last" isn't a standalone word like "all" or "none". It will
> be a part of a complete range specification, possibly with CSV separate
> ranges, and possibly specified multiple times. So I had to be a bit
> more careful with string matching - and hence un-inlined the parse
> function as commit #1 in this series.
>
> But it really is a generic support for "replace token ABC with known at
> boot value XYZ" - for example, it would be trivial to extend support to
> add "half" as a dynamic token to be replaced with 1/2 the core count,
> even though I wouldn't suggest that has a use case like "last" does.
>
> I tested the string matching with a bunch of intentionally badly crafted
> strings in a user-space harness, and tested bootarg use with nohz_full
> and rcu_nocbs, and also the post-boot cgroup use case as per below:
>
> root@hackbox:/sys/fs/cgroup/cpuset# mkdir foo
> root@hackbox:/sys/fs/cgroup/cpuset# cd foo
> root@hackbox:/sys/fs/cgroup/cpuset/foo# cat cpuset.cpus
>
> root@hackbox:/sys/fs/cgroup/cpuset/foo# /bin/echo 10-last > cpuset.cpus
> root@hackbox:/sys/fs/cgroup/cpuset/foo# cat cpuset.cpus
> 10-15
> root@hackbox:/sys/fs/cgroup/cpuset/foo# /bin/echo all > cpuset.cpus
> root@hackbox:/sys/fs/cgroup/cpuset/foo# cat cpuset.cpus
> 0-15
> root@hackbox:/sys/fs/cgroup/cpuset/foo# /bin/echo none > cpuset.cpus
> root@hackbox:/sys/fs/cgroup/cpuset/foo# cat cpuset.cpus
>
> root@hackbox:/sys/fs/cgroup/cpuset/foo#
>
> This was on a 16 core machine with CONFIG_NR_CPUS=16 in .config file.
>
> Note that the two use cases (boot and runtime) are why you see "early"
> parameter in the code - I entertained just sticking the string copy on
> the stack vs. the early alloc dance, but this felt more correct/robust.
> The cgroup and modular code using cpulist_parse() are runtime cases.
I considered doing this when adding "all" for RCU, but was just too
lazy. So you are a better man than I am! ;-)
I have queued these for testing, both "all" and "last" work just fine.
Given that "all" works, I hereby declare "none" to be working by
inspection. Therefore, for 1, 2, and 4:
Tested-by: Paul E. McKenney <paulmck@kernel.org>
For 3:
Reviewed-by: Paul E. McKenney <paulmck@kernel.org>
Or I can carry them if you wish. My expected changes in response to
this series are shown below, and are also what I used to test it.
Thanx, Paul
------------------------------------------------------------------------
diff --git a/tools/testing/selftests/rcutorture/configs/rcu/TREE04.boot b/tools/testing/selftests/rcutorture/configs/rcu/TREE04.boot
index 5adc675..25a765d 100644
--- a/tools/testing/selftests/rcutorture/configs/rcu/TREE04.boot
+++ b/tools/testing/selftests/rcutorture/configs/rcu/TREE04.boot
@@ -1 +1 @@
-rcutree.rcu_fanout_leaf=4 nohz_full=1-7
+rcutree.rcu_fanout_leaf=4 nohz_full=1-last
diff --git a/tools/testing/selftests/rcutorture/configs/rcu/TREE08.boot b/tools/testing/selftests/rcutorture/configs/rcu/TREE08.boot
index 22478fd..94d3844 100644
--- a/tools/testing/selftests/rcutorture/configs/rcu/TREE08.boot
+++ b/tools/testing/selftests/rcutorture/configs/rcu/TREE08.boot
@@ -1,3 +1,3 @@
rcupdate.rcu_self_test=1
rcutree.rcu_fanout_exact=1
-rcu_nocbs=0-7
+rcu_nocbs=all
next prev parent reply other threads:[~2020-11-08 18:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-08 16:08 [PATCH 0/4] RFC: support for global CPU list abbreviations Paul Gortmaker
2020-11-08 16:08 ` [PATCH 1/4] cpumask: un-inline cpulist_parse; prepare for ascii helpers Paul Gortmaker
2020-11-08 16:08 ` [PATCH 2/4] cpumask: make "all" alias global and not just RCU Paul Gortmaker
2020-11-08 16:08 ` [PATCH 3/4] cpumask: add a "none" alias to complement "all" Paul Gortmaker
2020-11-08 16:08 ` [PATCH 4/4] cpumask: add "last" alias for cpu list specifications Paul Gortmaker
2020-11-08 18:02 ` Paul E. McKenney [this message]
2020-11-08 20:21 ` [PATCH 0/4] RFC: support for global CPU list abbreviations Paul Gortmaker
2020-11-08 21:24 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201108180222.GA17637@paulmck-ThinkPad-P72 \
--to=paulmck@kernel.org \
--cc=cgroups@vger.kernel.org \
--cc=fweisbec@gmail.com \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=mingo@kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).