From: Peter Zijlstra <peterz@infradead.org>
To: paulmck@kernel.org
Cc: rcu@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-team@fb.com, mingo@kernel.org, jiangshanlai@gmail.com,
akpm@linux-foundation.org, mathieu.desnoyers@efficios.com,
josh@joshtriplett.org, tglx@linutronix.de, rostedt@goodmis.org,
dhowells@redhat.com, edumazet@google.com, fweisbec@gmail.com,
oleg@redhat.com, joel@joelfernandes.org, Hui Su <sh_def@163.com>
Subject: Re: [PATCH tip/core/rcu 4/4] docs/rcu: Update the call_rcu() API
Date: Mon, 9 Nov 2020 13:24:24 +0100 [thread overview]
Message-ID: <20201109122424.GN2594@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20201105230510.18660-4-paulmck@kernel.org>
On Thu, Nov 05, 2020 at 03:05:10PM -0800, paulmck@kernel.org wrote:
> From: Hui Su <sh_def@163.com>
>
> This commit updates the documented API of call_rcu() to use the
> rcu_callback_t typedef instead of the open-coded function definition.
>
> Signed-off-by: Hui Su <sh_def@163.com>
> Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
> ---
> Documentation/RCU/whatisRCU.rst | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/Documentation/RCU/whatisRCU.rst b/Documentation/RCU/whatisRCU.rst
> index fb3ff76..1a4723f 100644
> --- a/Documentation/RCU/whatisRCU.rst
> +++ b/Documentation/RCU/whatisRCU.rst
> @@ -497,8 +497,7 @@ long -- there might be other high-priority work to be done.
> In such cases, one uses call_rcu() rather than synchronize_rcu().
> The call_rcu() API is as follows::
>
> - void call_rcu(struct rcu_head * head,
> - void (*func)(struct rcu_head *head));
> + void call_rcu(struct rcu_head *head, rcu_callback_t func);
Personally I much prefer the old form, because now I have to go look up
rcu_callback_t to figure out wtf kind of signature is actually required.
next prev parent reply other threads:[~2020-11-09 12:24 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-05 23:04 [PATCH tip/core/rcu 0/4] Documentations updates for v5.11 Paul E. McKenney
2020-11-05 23:05 ` [PATCH tip/core/rcu 1/4] doc: Present the role of READ_ONCE() paulmck
2020-11-09 12:21 ` Peter Zijlstra
2020-11-09 16:20 ` Paul E. McKenney
2020-11-05 23:05 ` [PATCH tip/core/rcu 2/4] docs: Update RCU's hotplug requirements with a bit about design paulmck
2020-11-09 12:23 ` Peter Zijlstra
2020-11-09 16:24 ` Paul E. McKenney
2020-11-09 17:14 ` Peter Zijlstra
2020-11-10 20:33 ` Joel Fernandes
2020-11-11 0:20 ` Paul E. McKenney
2020-11-05 23:05 ` [PATCH tip/core/rcu 3/4] docs: RCU: Requirements.rst: Fix a list block paulmck
2020-11-05 23:05 ` [PATCH tip/core/rcu 4/4] docs/rcu: Update the call_rcu() API paulmck
2020-11-09 12:24 ` Peter Zijlstra [this message]
2020-11-10 1:20 ` Paul E. McKenney
2020-11-10 9:25 ` Peter Zijlstra
2020-11-10 14:37 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201109122424.GN2594@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=edumazet@google.com \
--cc=fweisbec@gmail.com \
--cc=jiangshanlai@gmail.com \
--cc=joel@joelfernandes.org \
--cc=josh@joshtriplett.org \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mingo@kernel.org \
--cc=oleg@redhat.com \
--cc=paulmck@kernel.org \
--cc=rcu@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=sh_def@163.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).