From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91E5BC388F7 for ; Mon, 9 Nov 2020 13:08:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 40EF220789 for ; Mon, 9 Nov 2020 13:08:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604927295; bh=9wCNtEKw6drz3rrtH4h674ZE0HDlKKmGncrRuHOz+sI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=L1kNv6loHR9RCJbKfvCD8Jt5MalJNNREUankqXJBMKithPraOtjWfFrY21LQ4uqOj IXnLaT5c2bQ+AYYfCgRlCt4lKHuJitXoxYQWhXI7CCTfoOvOl6uPS1jxJP+P0XKJqN fgDWwc0hB5zZUWMZ++5wPT9hZdeGGT0Dmj2lmBAM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731553AbgKINIO (ORCPT ); Mon, 9 Nov 2020 08:08:14 -0500 Received: from mail.kernel.org ([198.145.29.99]:32860 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730569AbgKINIJ (ORCPT ); Mon, 9 Nov 2020 08:08:09 -0500 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8854D2076E; Mon, 9 Nov 2020 13:08:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604927288; bh=9wCNtEKw6drz3rrtH4h674ZE0HDlKKmGncrRuHOz+sI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=gD1QhZZ600B08RUF4Di8leS6jhru2CAp6WBU/trghvEQbU6dnkEroA1fxaqzuCu+6 BgWdXHbxKIuiJAemtTUHppsqxfThcT8wSlyJ8IcoQm74vWryJAD1a45v8u5t25qZ0B KwHE6AT2vPgOoeHznXDat1gGP6AqNi6ZzFMX1Qbs= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Chris Wilson , Mika Kuoppala , Rodrigo Vivi Subject: [PATCH 4.19 01/71] drm/i915: Break up error capture compression loops with cond_resched() Date: Mon, 9 Nov 2020 13:54:55 +0100 Message-Id: <20201109125019.973892170@linuxfoundation.org> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20201109125019.906191744@linuxfoundation.org> References: <20201109125019.906191744@linuxfoundation.org> User-Agent: quilt/0.66 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Chris Wilson commit 7d5553147613b50149238ac1385c60e5c7cacb34 upstream. As the error capture will compress user buffers as directed to by the user, it can take an arbitrary amount of time and space. Break up the compression loops with a call to cond_resched(), that will allow other processes to schedule (avoiding the soft lockups) and also serve as a warning should we try to make this loop atomic in the future. Testcase: igt/gem_exec_capture/many-* Signed-off-by: Chris Wilson Cc: Mika Kuoppala Cc: stable@vger.kernel.org Reviewed-by: Mika Kuoppala Link: https://patchwork.freedesktop.org/patch/msgid/20200916090059.3189-2-chris@chris-wilson.co.uk (cherry picked from commit 293f43c80c0027ff9299036c24218ac705ce584e) Signed-off-by: Rodrigo Vivi Signed-off-by: Greg Kroah-Hartman --- drivers/gpu/drm/i915/i915_gpu_error.c | 3 +++ 1 file changed, 3 insertions(+) --- a/drivers/gpu/drm/i915/i915_gpu_error.c +++ b/drivers/gpu/drm/i915/i915_gpu_error.c @@ -268,6 +268,8 @@ static int compress_page(struct compress if (zlib_deflate(zstream, Z_NO_FLUSH) != Z_OK) return -EIO; + + cond_resched(); } while (zstream->avail_in); /* Fallback to uncompressed if we increase size? */ @@ -347,6 +349,7 @@ static int compress_page(struct compress if (!i915_memcpy_from_wc(ptr, src, PAGE_SIZE)) memcpy(ptr, src, PAGE_SIZE); dst->pages[dst->page_count++] = ptr; + cond_resched(); return 0; }