From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5746CC388F7 for ; Mon, 9 Nov 2020 13:29:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 13D412076E for ; Mon, 9 Nov 2020 13:29:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604928582; bh=k4bdtbA0dFbR9aFZwYxBWMXTGB4kKHFu9Z/ClaWl9Ro=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=Z2DIlwwPAeNaB1gzjgxFvhaHLUl2Cstr9ww41I4MVOWtsojU+X0ycu/X0uwK76h+A V/74ZArgrkUIccgvF22sqA7Y1pN9lTzDZTfDLzZicBY08SoNeHk5YEYhsyCDhW09fo dp7ZwHbX9uxsFyLnzCLD87a7v66djDBJHXfu6E/w= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732857AbgKIN3l (ORCPT ); Mon, 9 Nov 2020 08:29:41 -0500 Received: from mail.kernel.org ([198.145.29.99]:37534 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732507AbgKINL7 (ORCPT ); Mon, 9 Nov 2020 08:11:59 -0500 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 59DF820663; Mon, 9 Nov 2020 13:11:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604927519; bh=k4bdtbA0dFbR9aFZwYxBWMXTGB4kKHFu9Z/ClaWl9Ro=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=cicXjg37GJRMSqXhYg+kpyLN6IexJu/ulytXkvagT9gnDWSRmBuAoIVkLVgWQyt6m kgwn32hZFbwL/jaiKVH2L66YzrNKl8gUsrPlxVG5w/toarXB1fw6/QGxTp+0nUHXz3 IffDI8aeLJ25M0UnFoXiZrDyQCoCofuLrYK2ZJTk= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Shannon Nelson , Jakub Kicinski Subject: [PATCH 5.4 16/85] ionic: check port ptr before use Date: Mon, 9 Nov 2020 13:55:13 +0100 Message-Id: <20201109125023.366063108@linuxfoundation.org> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20201109125022.614792961@linuxfoundation.org> References: <20201109125022.614792961@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Shannon Nelson [ Upstream commit 2bcbf42add911ef63a6d90e92001dc2bcb053e68 ] Check for corner case of port_init failure before using the port_info pointer. Fixes: 4d03e00a2140 ("ionic: Add initial ethtool support") Signed-off-by: Shannon Nelson Link: https://lore.kernel.org/r/20201104195606.61184-1-snelson@pensando.io Signed-off-by: Jakub Kicinski Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/pensando/ionic/ionic_ethtool.c | 5 +++++ 1 file changed, 5 insertions(+) --- a/drivers/net/ethernet/pensando/ionic/ionic_ethtool.c +++ b/drivers/net/ethernet/pensando/ionic/ionic_ethtool.c @@ -125,6 +125,11 @@ static int ionic_get_link_ksettings(stru ethtool_link_ksettings_zero_link_mode(ks, supported); + if (!idev->port_info) { + netdev_err(netdev, "port_info not initialized\n"); + return -EOPNOTSUPP; + } + /* The port_info data is found in a DMA space that the NIC keeps * up-to-date, so there's no need to request the data from the * NIC, we already have it in our memory space.