* [PATCH] drm: DRM_KMB_DISPLAY should depend on ARCH_KEEMBAY
@ 2020-11-10 14:43 Geert Uytterhoeven
2020-11-10 16:15 ` Daniel Vetter
0 siblings, 1 reply; 2+ messages in thread
From: Geert Uytterhoeven @ 2020-11-10 14:43 UTC (permalink / raw)
To: Anitha Chrisanthus, Edmund Dea, David Airlie, Daniel Vetter,
Sam Ravnborg
Cc: dri-devel, linux-arm-kernel, linux-kernel, Geert Uytterhoeven
The Intel Keem Bay display controller is only present on Intel Keem Bay
SoCs. Hence add a dependency on ARCH_KEEMBAY, to prevent asking the
user about this driver when configuring a kernel without Intel Keem Bay
platform support.
Note that:
1. The dependency on ARM is dropped, as Keem Bay SoCs are only
supported in arm64 kernel builds,
2. The dependencies on OF and COMMON_CLK can be dropped for
compile-testing, as the driver builds fine regardless.
Fixes: ed794057b052b52a ("drm/kmb: Build files for KeemBay Display driver")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
drivers/gpu/drm/kmb/Kconfig | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/kmb/Kconfig b/drivers/gpu/drm/kmb/Kconfig
index 022ef3e3f05635be..3921c57ac511e2fb 100644
--- a/drivers/gpu/drm/kmb/Kconfig
+++ b/drivers/gpu/drm/kmb/Kconfig
@@ -1,7 +1,7 @@
config DRM_KMB_DISPLAY
tristate "INTEL KEEMBAY DISPLAY"
- depends on DRM && OF && (ARM || ARM64)
- depends on COMMON_CLK
+ depends on DRM
+ depends on ARCH_KEEMBAY || COMPILE_TEST
select DRM_KMS_HELPER
select DRM_KMS_CMA_HELPER
select DRM_GEM_CMA_HELPER
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm: DRM_KMB_DISPLAY should depend on ARCH_KEEMBAY
2020-11-10 14:43 [PATCH] drm: DRM_KMB_DISPLAY should depend on ARCH_KEEMBAY Geert Uytterhoeven
@ 2020-11-10 16:15 ` Daniel Vetter
0 siblings, 0 replies; 2+ messages in thread
From: Daniel Vetter @ 2020-11-10 16:15 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Anitha Chrisanthus, Edmund Dea, David Airlie, Daniel Vetter,
Sam Ravnborg, dri-devel, linux-arm-kernel, linux-kernel
On Tue, Nov 10, 2020 at 03:43:50PM +0100, Geert Uytterhoeven wrote:
> The Intel Keem Bay display controller is only present on Intel Keem Bay
> SoCs. Hence add a dependency on ARCH_KEEMBAY, to prevent asking the
> user about this driver when configuring a kernel without Intel Keem Bay
> platform support.
>
> Note that:
> 1. The dependency on ARM is dropped, as Keem Bay SoCs are only
> supported in arm64 kernel builds,
> 2. The dependencies on OF and COMMON_CLK can be dropped for
> compile-testing, as the driver builds fine regardless.
>
> Fixes: ed794057b052b52a ("drm/kmb: Build files for KeemBay Display driver")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Both drm/kmb fixes applied to drm-misc-next, thanks a lot!
-Daniel
> ---
> drivers/gpu/drm/kmb/Kconfig | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/kmb/Kconfig b/drivers/gpu/drm/kmb/Kconfig
> index 022ef3e3f05635be..3921c57ac511e2fb 100644
> --- a/drivers/gpu/drm/kmb/Kconfig
> +++ b/drivers/gpu/drm/kmb/Kconfig
> @@ -1,7 +1,7 @@
> config DRM_KMB_DISPLAY
> tristate "INTEL KEEMBAY DISPLAY"
> - depends on DRM && OF && (ARM || ARM64)
> - depends on COMMON_CLK
> + depends on DRM
> + depends on ARCH_KEEMBAY || COMPILE_TEST
> select DRM_KMS_HELPER
> select DRM_KMS_CMA_HELPER
> select DRM_GEM_CMA_HELPER
> --
> 2.25.1
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-11-10 16:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-10 14:43 [PATCH] drm: DRM_KMB_DISPLAY should depend on ARCH_KEEMBAY Geert Uytterhoeven
2020-11-10 16:15 ` Daniel Vetter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).