linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Petr Mladek <pmladek@suse.com>
To: Matteo Croce <mcroce@linux.microsoft.com>
Cc: linux-kernel@vger.kernel.org, Mike Rapoport <rppt@kernel.org>,
	Guenter Roeck <linux@roeck-us.net>, Arnd Bergmann <arnd@arndb.de>,
	Pavel Tatashin <pasha.tatashin@soleen.com>,
	Kees Cook <keescook@chromium.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Tyler Hicks <tyhicks@linux.microsoft.com>
Subject: Re: [PATCH v3] reboot: allow to specify reboot mode via sysfs
Date: Wed, 11 Nov 2020 10:22:39 +0100	[thread overview]
Message-ID: <20201111092239.GF20201@alley> (raw)
In-Reply-To: <CAFnufp3xfBCwodEmD-sSM7sRWdEv3iDbyBcjYKP_tL70yc+gtQ@mail.gmail.com>

On Tue 2020-11-10 18:36:05, Matteo Croce wrote:
> On Tue, Nov 10, 2020 at 3:58 PM Petr Mladek <pmladek@suse.com> wrote:
> > On Mon 2020-11-09 17:45:38, Matteo Croce wrote:
> > > From: Matteo Croce <mcroce@microsoft.com>
> > > +What:                /sys/kernel/reboot/force
> > > +Date:                November 2020
> > > +KernelVersion:       5.11
> > > +Contact:     Matteo Croce <mcroce@microsoft.com>
> > > +Description: Force an immediate reboot.
> >
> > This makes me feel like that the kernel will reboot
> > immediately when you write "1". It would deserve a better
> > explanation that would make it clear, something like:
> >
> > Description:    Use forced reboot that does not contact the init system.
> >
> 
> Description: Don't wait for any other CPUs on reboot and avoid
> anything that could hang.

Sound good to me. I see that Andrew already queued the updated patch
with my Reviewed-by so all is OK.

Best Regards,
Petr

      reply	other threads:[~2020-11-11  9:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-09 16:45 [PATCH v3] reboot: allow to specify reboot mode via sysfs Matteo Croce
2020-11-10 14:58 ` Petr Mladek
2020-11-10 17:36   ` Matteo Croce
2020-11-11  9:22     ` Petr Mladek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201111092239.GF20201@alley \
    --to=pmladek@suse.com \
    --cc=akpm@linux-foundation.org \
    --cc=arnd@arndb.de \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=mcroce@linux.microsoft.com \
    --cc=pasha.tatashin@soleen.com \
    --cc=rppt@kernel.org \
    --cc=tyhicks@linux.microsoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).