From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E949AC4742C for ; Thu, 12 Nov 2020 01:35:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8B3D2206F1 for ; Thu, 12 Nov 2020 01:35:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="bZOBzJf7" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728833AbgKLBfO (ORCPT ); Wed, 11 Nov 2020 20:35:14 -0500 Received: from mail.kernel.org ([198.145.29.99]:49174 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727855AbgKKXPo (ORCPT ); Wed, 11 Nov 2020 18:15:44 -0500 Received: from kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com (unknown [163.114.132.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EF5B720797; Wed, 11 Nov 2020 23:15:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1605136544; bh=BsryHKz3dVxK2sBEfXD2LfC5W276gDYqCQDz8imsdS0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=bZOBzJf7ulaTmNfU8C4zP9exUVyaxz1AzeaDx7ywfgMz8C0uigyiwwMLY23x1hme0 +sDAq6cLhG00Msc1SSLgguG6y5ZbNluc1o3aKotR7yEAVx4LDxh4e0jR8YuTC+58+S ID4KS6X1Rea3PE8uKEF6V3AbK8P9diX8nNZrgTE8= Date: Wed, 11 Nov 2020 15:15:42 -0800 From: Jakub Kicinski To: Jisheng Zhang Cc: Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S. Miller" , Maxime Coquelin , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next] net: stmmac: dwc-qos: Change the dwc_eth_dwmac_data's .probe prototype Message-ID: <20201111151542.4b9addde@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <20201109160440.3a736ee3@xhacker.debian> References: <20201109160440.3a736ee3@xhacker.debian> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 9 Nov 2020 16:05:14 +0800 Jisheng Zhang wrote: > The return pointer of dwc_eth_dwmac_data's .probe isn't used, and > "probe" usually return int, so change the prototype to follow standard > way. Secondly, it can simplify the tegra_eqos_probe() code. > > Signed-off-by: Jisheng Zhang Applied, thanks!