From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69AA7C61DD8 for ; Wed, 11 Nov 2020 16:42:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 056872072C for ; Wed, 11 Nov 2020 16:42:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="Km1fuPPH" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727582AbgKKQmT (ORCPT ); Wed, 11 Nov 2020 11:42:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55152 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727132AbgKKQmP (ORCPT ); Wed, 11 Nov 2020 11:42:15 -0500 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A91FBC0613D1; Wed, 11 Nov 2020 08:42:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=CdmQLCwtYnJ5737miMX6EDzo04FbVACXjJLBV8q9mKA=; b=Km1fuPPHydJXaMwRTIxnTPT7pO pBU+59/VZfX5+xusAShQ4joPY0E+weOOpsFrbpcjoBXqybcfQCo20iR0qOx84e37PHNvivcx13mhg kZLfAEDCCsFHPMVKhaaLWI3JbuPdA79ERGR5z5Y2JKW84K+BdzUVao/f5nFSFvG/8T23p26PAd1+8 Sc9oTLXb56vCknvvtNf6xsfcfjwrBZOhFIaVp7SSel7dlQDtw+Cb8e9qg4OKMbVxzPdyfuHM3Ab+B FZSEmkPx0JPBQacjL5Z+Y4ZGf8Wkmwuio1lE5oZpUmXji4lB70vEynRHF5/EMdIwopzpaxPOx93A9 r93p8KYg==; Received: from willy by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kctBx-00026P-W3; Wed, 11 Nov 2020 16:41:54 +0000 Date: Wed, 11 Nov 2020 16:41:53 +0000 From: Matthew Wilcox To: Shuah Khan Cc: corbet@lwn.net, keescook@chromium.org, gregkh@linuxfoundation.org, peterz@infradead.org, rafael@kernel.org, lenb@kernel.org, james.morse@arm.com, tony.luck@intel.com, bp@alien8.de, minyard@acm.org, arnd@arndb.de, mchehab@kernel.org, rric@kernel.org, valentina.manea.m@gmail.com, shuah@kernel.org, zohar@linux.ibm.com, dmitry.kasatkin@gmail.com, jmorris@namei.org, serge@hallyn.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-acpi@vger.kernel.org, openipmi-developer@lists.sourceforge.net, linux-edac@vger.kernel.org, linux-usb@vger.kernel.org, linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org Subject: Re: [PATCH 00/13] Introduce seqnum_ops Message-ID: <20201111164153.GV17076@casper.infradead.org> References: <20201111043304.GS17076@casper.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 11, 2020 at 09:03:20AM -0700, Shuah Khan wrote: > On 11/10/20 9:33 PM, Matthew Wilcox wrote: > > On Tue, Nov 10, 2020 at 12:53:26PM -0700, Shuah Khan wrote: > > > There are a number of atomic_t usages in the kernel where atomic_t api > > > is used strictly for counting sequence numbers and other statistical > > > counters and not for managing object lifetime. > > > > We already have something in Linux called a sequence counter, and it's > > different from this. ID counter? instance number? monotonic_t? stat_t? > > > > No results for monotonic_t or stat_t. Can you give me a pointer to what > your referring to. We have a seqcount_t. We need to call this something different. maybe we should call it stat_t (and for that usage, stat_add() as well as stat_inc() is a legitimate API to have).