From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Cc: u.kleine-koenig@pengutronix.de, linux-kernel@vger.kernel.org,
f.fainelli@gmail.com, linux-pwm@vger.kernel.org,
bcm-kernel-feedback-list@broadcom.com,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
wahrenst@gmx.net, linux-input@vger.kernel.org,
gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
p.zabel@pengutronix.de, linux-gpio@vger.kernel.org,
linus.walleij@linaro.org, linux-clk@vger.kernel.org,
sboyd@kernel.org, linux-rpi-kernel@lists.infradead.org,
bgolaszewski@baylibre.com, andy.shevchenko@gmail.com
Subject: Re: [PATCH v3 07/11] input: raspberrypi-ts: Release firmware handle when not needed
Date: Wed, 11 Nov 2020 17:45:42 -0800 [thread overview]
Message-ID: <20201112014542.GA1003057@dtor-ws> (raw)
In-Reply-To: <20201104103938.1286-8-nsaenzjulienne@suse.de>
Hi Nicolas,
On Wed, Nov 04, 2020 at 11:39:33AM +0100, Nicolas Saenz Julienne wrote:
> Use devm_rpi_firmware_get() so as to make sure we release RPi's firmware
> interface when unbinding the device.
Unless I am mistaken this driver does not really need the firmware
structure past rpi_ts_probe(), and will be fine if it disappears earlier
than unbind time.
Thanks.
>
> Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
>
> ---
>
> Changes since v2:
> - Use devm_rpi_firmware_get(), instead of remove function
>
> drivers/input/touchscreen/raspberrypi-ts.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/touchscreen/raspberrypi-ts.c b/drivers/input/touchscreen/raspberrypi-ts.c
> index ef6aaed217cf..efed0efa91d9 100644
> --- a/drivers/input/touchscreen/raspberrypi-ts.c
> +++ b/drivers/input/touchscreen/raspberrypi-ts.c
> @@ -134,7 +134,7 @@ static int rpi_ts_probe(struct platform_device *pdev)
> return -ENOENT;
> }
>
> - fw = rpi_firmware_get(fw_node);
> + fw = devm_rpi_firmware_get(&pdev->dev, fw_node);
> of_node_put(fw_node);
> if (!fw)
> return -EPROBE_DEFER;
> --
> 2.29.1
>
--
Dmitry
next prev parent reply other threads:[~2020-11-12 5:33 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-04 10:39 [PATCH v3 00/11] Raspberry Pi PoE HAT fan support Nicolas Saenz Julienne
2020-11-04 10:39 ` [PATCH v3 01/11] firmware: raspberrypi: Introduce devm_rpi_firmware_get() Nicolas Saenz Julienne
2020-11-05 9:13 ` Bartosz Golaszewski
2020-11-05 9:28 ` Nicolas Saenz Julienne
2020-11-05 9:42 ` Bartosz Golaszewski
2020-11-10 13:38 ` Nicolas Saenz Julienne
2020-11-04 10:39 ` [PATCH v3 02/11] clk: bcm: rpi: Release firmware handle on unbind Nicolas Saenz Julienne
2020-11-04 10:39 ` [PATCH v3 03/11] gpio: raspberrypi-exp: " Nicolas Saenz Julienne
2020-11-05 9:08 ` Bartosz Golaszewski
2020-11-04 10:39 ` [PATCH v3 04/11] reset: raspberrypi: " Nicolas Saenz Julienne
2020-11-04 10:39 ` [PATCH v3 05/11] soc: bcm: raspberrypi-power: " Nicolas Saenz Julienne
2020-11-04 10:39 ` [PATCH v3 06/11] staging: vchiq: " Nicolas Saenz Julienne
2020-11-04 10:39 ` [PATCH v3 07/11] input: raspberrypi-ts: Release firmware handle when not needed Nicolas Saenz Julienne
2020-11-12 1:45 ` Dmitry Torokhov [this message]
2020-11-12 9:06 ` Nicolas Saenz Julienne
2020-11-04 10:39 ` [PATCH v3 08/11] firmware: raspberrypi: Get rid of rpi_firmware_get() Nicolas Saenz Julienne
2020-11-04 10:39 ` [PATCH v3 09/11] dt-bindings: pwm: Add binding for RPi firmware PWM bus Nicolas Saenz Julienne
2020-11-04 19:06 ` Rob Herring
2020-11-04 19:55 ` Nicolas Saenz Julienne
2020-11-04 10:39 ` [PATCH v3 10/11] DO NOT MERGE: ARM: dts: Add RPi's official PoE hat support Nicolas Saenz Julienne
2020-11-04 10:39 ` [PATCH v3 11/11] pwm: Add Raspberry Pi Firmware based PWM bus Nicolas Saenz Julienne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201112014542.GA1003057@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=andy.shevchenko@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bgolaszewski@baylibre.com \
--cc=devel@driverdev.osuosl.org \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=nsaenzjulienne@suse.de \
--cc=p.zabel@pengutronix.de \
--cc=sboyd@kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
--cc=wahrenst@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).