From: "Mirela Rabulea (OSS)" <mirela.rabulea@oss.nxp.com>
To: mchehab@kernel.org, hverkuil-cisco@xs4all.nl,
shawnguo@kernel.org, robh+dt@kernel.org, p.zabel@pengutronix.de
Cc: paul.kocialkowski@bootlin.com, linux-media@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-imx@nxp.com,
s.hauer@pengutronix.de, aisheng.dong@nxp.com,
daniel.baluta@nxp.com, robert.chiras@nxp.com,
laurentiu.palcu@nxp.com, mark.rutland@arm.com,
devicetree@vger.kernel.org, ezequiel@collabora.com,
laurent.pinchart+renesas@ideasonboard.com,
niklas.soderlund+renesas@ragnatech.se,
dafna.hirschfeld@collabora.com,
Mirela Rabulea <mirela.rabulea@nxp.com>
Subject: [PATCH v5 09/10] media: Avoid parsing quantization and huffman tables
Date: Thu, 12 Nov 2020 05:05:56 +0200 [thread overview]
Message-ID: <20201112030557.8540-10-mirela.rabulea@oss.nxp.com> (raw)
In-Reply-To: <20201112030557.8540-1-mirela.rabulea@oss.nxp.com>
From: Mirela Rabulea <mirela.rabulea@nxp.com>
These are optional in struct v4l2_jpeg_header, so do not parse if
not requested, save some time.
Signed-off-by: Mirela Rabulea <mirela.rabulea@nxp.com>
---
drivers/media/v4l2-core/v4l2-jpeg.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/media/v4l2-core/v4l2-jpeg.c b/drivers/media/v4l2-core/v4l2-jpeg.c
index d77e04083d57..7576cd0ce6b9 100644
--- a/drivers/media/v4l2-core/v4l2-jpeg.c
+++ b/drivers/media/v4l2-core/v4l2-jpeg.c
@@ -307,6 +307,9 @@ static int jpeg_parse_quantization_tables(struct jpeg_stream *stream,
{
int len = jpeg_get_word_be(stream);
+ if (!tables)
+ return 0;
+
if (len < 0)
return len;
/* Lq = 2 + n * 65 (for baseline DCT), n >= 1 */
@@ -361,6 +364,9 @@ static int jpeg_parse_huffman_tables(struct jpeg_stream *stream,
int mt;
int len = jpeg_get_word_be(stream);
+ if (!tables)
+ return 0;
+
if (len < 0)
return len;
/* Table B.5 - Huffman table specification parameter sizes and values */
--
2.17.1
next prev parent reply other threads:[~2020-11-12 5:35 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-12 3:05 [PATCH v5 00/10] Add V4L2 driver for i.MX8 JPEG Encoder/Decoder Mirela Rabulea (OSS)
2020-11-12 3:05 ` [PATCH v5 01/10] media: v4l: Add packed YUV444 24bpp pixel format Mirela Rabulea (OSS)
2020-11-12 3:05 ` [PATCH v5 02/10] firmware: imx: scu-pd: Add power domains for imx-jpeg Mirela Rabulea (OSS)
2020-11-16 8:26 ` Shawn Guo
2020-11-12 3:05 ` [PATCH v5 03/10] media: dt-bindings: Add bindings for i.MX8QXP/QM JPEG driver Mirela Rabulea (OSS)
2020-11-16 19:18 ` Rob Herring
2020-11-12 3:05 ` [PATCH v5 04/10] media: imx-jpeg: Add V4L2 driver for i.MX8 JPEG Encoder/Decoder Mirela Rabulea (OSS)
2020-11-12 3:05 ` [PATCH v5 05/10] arm64: dts: imx8qxp: Add jpeg encoder/decoder nodes Mirela Rabulea (OSS)
2020-11-12 8:36 ` Ezequiel Garcia
2020-11-13 16:12 ` [EXT] " Mirela Rabulea (OSS)
2020-11-12 3:05 ` [PATCH v5 06/10] Add maintainer for IMX jpeg v4l2 driver Mirela Rabulea (OSS)
2020-11-12 3:05 ` [PATCH v5 07/10] media: Add parsing for APP14 data segment in jpeg helpers Mirela Rabulea (OSS)
2020-11-24 15:27 ` Mirela Rabulea
2020-12-02 15:18 ` Philipp Zabel
2020-12-04 14:13 ` [EXT] " Mirela Rabulea (OSS)
2020-12-04 14:32 ` Philipp Zabel
2020-11-12 3:05 ` [PATCH v5 08/10] media: Quit parsing stream if doesn't start with SOI Mirela Rabulea (OSS)
2020-12-02 15:18 ` Philipp Zabel
2020-11-12 3:05 ` Mirela Rabulea (OSS) [this message]
2020-12-02 12:12 ` [PATCH v5 09/10] media: Avoid parsing quantization and huffman tables Hans Verkuil
2020-12-02 15:30 ` Philipp Zabel
2020-12-02 15:22 ` Philipp Zabel
2020-11-12 3:05 ` [PATCH v5 10/10] media: imx-jpeg: Use v4l2 jpeg helpers in mxc-jpeg Mirela Rabulea (OSS)
2020-12-02 15:41 ` Philipp Zabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201112030557.8540-10-mirela.rabulea@oss.nxp.com \
--to=mirela.rabulea@oss.nxp.com \
--cc=aisheng.dong@nxp.com \
--cc=dafna.hirschfeld@collabora.com \
--cc=daniel.baluta@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=ezequiel@collabora.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=laurentiu.palcu@nxp.com \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mchehab@kernel.org \
--cc=mirela.rabulea@nxp.com \
--cc=niklas.soderlund+renesas@ragnatech.se \
--cc=p.zabel@pengutronix.de \
--cc=paul.kocialkowski@bootlin.com \
--cc=robert.chiras@nxp.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).