* [PATCH net] net: phy: mscc: remove non-MACSec compatible phy
@ 2020-11-12 9:04 Steen Hegelund
2020-11-12 22:28 ` Jakub Kicinski
0 siblings, 1 reply; 3+ messages in thread
From: Steen Hegelund @ 2020-11-12 9:04 UTC (permalink / raw)
To: Andrew Lunn, Heiner Kallweit, Russell King, David S. Miller,
Jakub Kicinski, Antoine Tenart, Bryan Whitehead
Cc: Steen Hegelund, Microchip UNG Driver List, John Haechten,
Netdev List, Linux Kernel List
Selecting VSC8575 as a MACSec PHY was not correct
The relevant datasheet can be found here:
- VSC8575: https://www.microchip.com/wwwproducts/en/VSC8575
Fixes: 0a504e9e97886 ("net: phy: mscc: macsec initialization")
Signed-off-by: Steen Hegelund <steen.hegelund@microchip.com>
---
drivers/net/phy/mscc/mscc_macsec.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/phy/mscc/mscc_macsec.c b/drivers/net/phy/mscc/mscc_macsec.c
index 1d4c012194e9..72292bf6c51c 100644
--- a/drivers/net/phy/mscc/mscc_macsec.c
+++ b/drivers/net/phy/mscc/mscc_macsec.c
@@ -981,7 +981,6 @@ int vsc8584_macsec_init(struct phy_device *phydev)
switch (phydev->phy_id & phydev->drv->phy_id_mask) {
case PHY_ID_VSC856X:
- case PHY_ID_VSC8575:
case PHY_ID_VSC8582:
case PHY_ID_VSC8584:
INIT_LIST_HEAD(&vsc8531->macsec_flows);
--
2.29.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net] net: phy: mscc: remove non-MACSec compatible phy
2020-11-12 9:04 [PATCH net] net: phy: mscc: remove non-MACSec compatible phy Steen Hegelund
@ 2020-11-12 22:28 ` Jakub Kicinski
2020-11-13 8:42 ` Steen Hegelund
0 siblings, 1 reply; 3+ messages in thread
From: Jakub Kicinski @ 2020-11-12 22:28 UTC (permalink / raw)
To: Steen Hegelund
Cc: Andrew Lunn, Heiner Kallweit, Russell King, David S. Miller,
Antoine Tenart, Bryan Whitehead, Microchip UNG Driver List,
John Haechten, Netdev List, Linux Kernel List
On Thu, 12 Nov 2020 10:04:29 +0100 Steen Hegelund wrote:
> Selecting VSC8575 as a MACSec PHY was not correct
>
> The relevant datasheet can be found here:
> - VSC8575: https://www.microchip.com/wwwproducts/en/VSC8575
>
> Fixes: 0a504e9e97886 ("net: phy: mscc: macsec initialization")
> Signed-off-by: Steen Hegelund <steen.hegelund@microchip.com>
Fixes tag: Fixes: 0a504e9e97886 ("net: phy: mscc: macsec initialization")
Has these problem(s):
- Subject does not match target commit subject
Just use
git log -1 --format='Fixes: %h ("%s")'
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net] net: phy: mscc: remove non-MACSec compatible phy
2020-11-12 22:28 ` Jakub Kicinski
@ 2020-11-13 8:42 ` Steen Hegelund
0 siblings, 0 replies; 3+ messages in thread
From: Steen Hegelund @ 2020-11-13 8:42 UTC (permalink / raw)
To: Jakub Kicinski
Cc: Andrew Lunn, Heiner Kallweit, Russell King, David S. Miller,
Antoine Tenart, Bryan Whitehead, Microchip UNG Driver List,
John Haechten, Netdev List, Linux Kernel List
On 12.11.2020 14:28, Jakub Kicinski wrote:
>EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
>On Thu, 12 Nov 2020 10:04:29 +0100 Steen Hegelund wrote:
>> Selecting VSC8575 as a MACSec PHY was not correct
>>
>> The relevant datasheet can be found here:
>> - VSC8575: https://www.microchip.com/wwwproducts/en/VSC8575
>>
>> Fixes: 0a504e9e97886 ("net: phy: mscc: macsec initialization")
>> Signed-off-by: Steen Hegelund <steen.hegelund@microchip.com>
>
>Fixes tag: Fixes: 0a504e9e97886 ("net: phy: mscc: macsec initialization")
>Has these problem(s):
> - Subject does not match target commit subject
> Just use
> git log -1 --format='Fixes: %h ("%s")'
Hi Jacub,
Right, that sha was for a tree object, not a commit. I should have
checked that.
Thanks for the log command example. That is really useful.
BR
Steen
---------------------------------------
Steen Hegelund
steen.hegelund@microchip.com
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-11-13 8:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-12 9:04 [PATCH net] net: phy: mscc: remove non-MACSec compatible phy Steen Hegelund
2020-11-12 22:28 ` Jakub Kicinski
2020-11-13 8:42 ` Steen Hegelund
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).