From: Rob Herring <robh@kernel.org>
To: Sameer Pujar <spujar@nvidia.com>
Cc: broonie@kernel.org, thierry.reding@gmail.com,
jonathanh@nvidia.com, kuninori.morimoto.gx@renesas.com,
alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
sharadg@nvidia.com
Subject: Re: [PATCH v5 1/6] ASoC: dt-bindings: tegra: Add graph bindings
Date: Thu, 12 Nov 2020 08:38:55 -0600 [thread overview]
Message-ID: <20201112143855.GA3553055@bogus> (raw)
In-Reply-To: <1605119676-32273-2-git-send-email-spujar@nvidia.com>
On Thu, Nov 12, 2020 at 12:04:31AM +0530, Sameer Pujar wrote:
> Add device tree binding properties of generic graph to ASoC component
> devices. This allows to define audio ports out of these components or
> DAIs and audio graph based sound card can be realised with this.
This is all dependent on graph.yaml being applied which hasn't happened
yet. I guess I'll need to provide a branch as there's multiple
subsystems needing it.
>
> Signed-off-by: Sameer Pujar <spujar@nvidia.com>
> ---
> .../devicetree/bindings/sound/nvidia,tegra186-dspk.yaml | 6 ++++++
> .../devicetree/bindings/sound/nvidia,tegra210-admaif.yaml | 6 ++++++
> .../devicetree/bindings/sound/nvidia,tegra210-ahub.yaml | 13 +++++++++++--
> .../devicetree/bindings/sound/nvidia,tegra210-dmic.yaml | 6 ++++++
> .../devicetree/bindings/sound/nvidia,tegra210-i2s.yaml | 6 ++++++
> 5 files changed, 35 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra186-dspk.yaml b/Documentation/devicetree/bindings/sound/nvidia,tegra186-dspk.yaml
> index ed2fb32..3c9364d 100644
> --- a/Documentation/devicetree/bindings/sound/nvidia,tegra186-dspk.yaml
> +++ b/Documentation/devicetree/bindings/sound/nvidia,tegra186-dspk.yaml
> @@ -55,6 +55,12 @@ properties:
> The name can be "DSPK1" or "DSPKx", where x depends on the maximum
> available instances on a Tegra SoC.
>
> + ports:
> + $ref: /schemas/graph.yaml#/properties/ports
If you have 'ports', then that means you have multiple ports and you
have to enumerate what each port is.
> +
> + port:
> + $ref: /schemas/sound/audio-graph.yaml#/properties/port
If you only have 1 port then, you can use 'port'.
So listing both is an error.
> +
> required:
> - compatible
> - reg
> diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra210-admaif.yaml b/Documentation/devicetree/bindings/sound/nvidia,tegra210-admaif.yaml
> index c028b25..162823d 100644
> --- a/Documentation/devicetree/bindings/sound/nvidia,tegra210-admaif.yaml
> +++ b/Documentation/devicetree/bindings/sound/nvidia,tegra210-admaif.yaml
> @@ -37,6 +37,12 @@ properties:
>
> dma-names: true
>
> + ports:
> + $ref: /schemas/graph.yaml#/properties/ports
> +
> + port:
> + $ref: /schemas/sound/audio-graph.yaml#/properties/port
> +
> if:
> properties:
> compatible:
> diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra210-ahub.yaml b/Documentation/devicetree/bindings/sound/nvidia,tegra210-ahub.yaml
> index d772197..59cd1f1 100644
> --- a/Documentation/devicetree/bindings/sound/nvidia,tegra210-ahub.yaml
> +++ b/Documentation/devicetree/bindings/sound/nvidia,tegra210-ahub.yaml
> @@ -56,6 +56,16 @@ properties:
>
> ranges: true
>
> + ports:
> + $ref: /schemas/graph.yaml#/properties/ports
> +
> + port:
> + $ref: /schemas/sound/audio-graph.yaml#/properties/port
> +
> +patternProperties:
> + "@[0-9a-f]+$":
> + type: object
> +
> required:
> - compatible
> - reg
> @@ -67,8 +77,7 @@ required:
> - "#size-cells"
> - ranges
>
> -additionalProperties:
> - type: object
> +additionalProperties: false
>
> examples:
> - |
> diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra210-dmic.yaml b/Documentation/devicetree/bindings/sound/nvidia,tegra210-dmic.yaml
> index 2a3207b..b16bf5e 100644
> --- a/Documentation/devicetree/bindings/sound/nvidia,tegra210-dmic.yaml
> +++ b/Documentation/devicetree/bindings/sound/nvidia,tegra210-dmic.yaml
> @@ -56,6 +56,12 @@ properties:
> The name can be "DMIC1" or "DMIC2" ... "DMICx", where x depends
> on the maximum available instances on a Tegra SoC.
>
> + ports:
> + $ref: /schemas/graph.yaml#/properties/ports
> +
> + port:
> + $ref: /schemas/sound/audio-graph.yaml#/properties/port
> +
> required:
> - compatible
> - reg
> diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra210-i2s.yaml b/Documentation/devicetree/bindings/sound/nvidia,tegra210-i2s.yaml
> index dfc1bf7..598f763 100644
> --- a/Documentation/devicetree/bindings/sound/nvidia,tegra210-i2s.yaml
> +++ b/Documentation/devicetree/bindings/sound/nvidia,tegra210-i2s.yaml
> @@ -74,6 +74,12 @@ properties:
> The name can be "I2S1" or "I2S2" ... "I2Sx", where x depends
> on the maximum available instances on a Tegra SoC.
>
> + ports:
> + $ref: /schemas/graph.yaml#/properties/ports
> +
> + port:
> + $ref: /schemas/sound/audio-graph.yaml#/properties/port
> +
> required:
> - compatible
> - reg
> --
> 2.7.4
>
next prev parent reply other threads:[~2020-11-12 14:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-11 18:34 [PATCH v5 0/6] Tegra210 audio graph card Sameer Pujar
2020-11-11 18:34 ` [PATCH v5 1/6] ASoC: dt-bindings: tegra: Add graph bindings Sameer Pujar
2020-11-12 14:38 ` Rob Herring [this message]
2020-11-19 9:10 ` Sameer Pujar
2020-11-11 18:34 ` [PATCH v5 2/6] ASoC: dt-bindings: tegra: Add json-schema for Tegra audio graph card Sameer Pujar
2020-11-11 18:34 ` [PATCH v5 3/6] ASoC: tegra: Add audio graph based card driver Sameer Pujar
2020-11-23 10:35 ` Jon Hunter
2020-11-23 14:17 ` Sameer Pujar
2020-11-11 18:34 ` [PATCH v5 4/6] arm64: defconfig: Enable Tegra audio graph " Sameer Pujar
2020-11-11 18:34 ` [PATCH v5 5/6] arm64: tegra: Audio graph header for Tegra210 Sameer Pujar
2020-11-11 18:34 ` [PATCH v5 6/6] arm64: tegra: Audio graph sound card for Jetson Nano and TX1 Sameer Pujar
2020-11-23 10:38 ` [PATCH v5 0/6] Tegra210 audio graph card Jon Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201112143855.GA3553055@bogus \
--to=robh@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jonathanh@nvidia.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=sharadg@nvidia.com \
--cc=spujar@nvidia.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).