linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH net-next] net: kcov: don't select SKB_EXTENSIONS when there is no NET
@ 2020-11-10 17:57 Randy Dunlap
  2020-11-12 23:25 ` Jakub Kicinski
  0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2020-11-10 17:57 UTC (permalink / raw)
  To: linux-kernel
  Cc: Randy Dunlap, Aleksandr Nogikh, Willem de Bruijn, Jakub Kicinski,
	linux-next, netdev

Fix kconfig warning when CONFIG_NET is not set/enabled:

WARNING: unmet direct dependencies detected for SKB_EXTENSIONS
  Depends on [n]: NET [=n]
  Selected by [y]:
  - KCOV [=y] && ARCH_HAS_KCOV [=y] && (CC_HAS_SANCOV_TRACE_PC [=y] || GCC_PLUGINS [=n])

Fixes: 6370cc3bbd8a ("net: add kcov handle to skb extensions")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Aleksandr Nogikh <nogikh@google.com>
Cc: Willem de Bruijn <willemb@google.com>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: linux-next@vger.kernel.org
Cc: netdev@vger.kernel.org
---
This is from linux-next. I'm only guessing that it is in net-next.

 lib/Kconfig.debug |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-next-20201110.orig/lib/Kconfig.debug
+++ linux-next-20201110/lib/Kconfig.debug
@@ -1874,7 +1874,7 @@ config KCOV
 	depends on CC_HAS_SANCOV_TRACE_PC || GCC_PLUGINS
 	select DEBUG_FS
 	select GCC_PLUGIN_SANCOV if !CC_HAS_SANCOV_TRACE_PC
-	select SKB_EXTENSIONS
+	select SKB_EXTENSIONS if NET
 	help
 	  KCOV exposes kernel code coverage information in a form suitable
 	  for coverage-guided fuzzing (randomized testing).

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH net-next] net: kcov: don't select SKB_EXTENSIONS when there is no NET
  2020-11-10 17:57 [PATCH net-next] net: kcov: don't select SKB_EXTENSIONS when there is no NET Randy Dunlap
@ 2020-11-12 23:25 ` Jakub Kicinski
  0 siblings, 0 replies; 2+ messages in thread
From: Jakub Kicinski @ 2020-11-12 23:25 UTC (permalink / raw)
  To: Randy Dunlap
  Cc: linux-kernel, Aleksandr Nogikh, Willem de Bruijn, linux-next, netdev

On Tue, 10 Nov 2020 09:57:46 -0800 Randy Dunlap wrote:
> Fix kconfig warning when CONFIG_NET is not set/enabled:
> 
> WARNING: unmet direct dependencies detected for SKB_EXTENSIONS
>   Depends on [n]: NET [=n]
>   Selected by [y]:
>   - KCOV [=y] && ARCH_HAS_KCOV [=y] && (CC_HAS_SANCOV_TRACE_PC [=y] || GCC_PLUGINS [=n])
> 
> Fixes: 6370cc3bbd8a ("net: add kcov handle to skb extensions")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>

> This is from linux-next. I'm only guessing that it is in net-next.

Yup, applied, thanks!

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-11-12 23:25 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-10 17:57 [PATCH net-next] net: kcov: don't select SKB_EXTENSIONS when there is no NET Randy Dunlap
2020-11-12 23:25 ` Jakub Kicinski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).