linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jacopo Mondi <jacopo+renesas@jmondi.org>
To: kieran.bingham+renesas@ideasonboard.com,
	laurent.pinchart+renesas@ideasonboard.com,
	niklas.soderlund+renesas@ragnatech.se, geert@linux-m68k.org
Cc: Jacopo Mondi <jacopo+renesas@jmondi.org>,
	linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
	linux-kernel@vger.kernel.org, Hyun Kwon <hyunk@xilinx.com>,
	Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Subject: [PATCH v4 0/8] media: i2c: Add RDACM21 camera module
Date: Thu, 12 Nov 2020 17:27:21 +0100	[thread overview]
Message-ID: <20201112162729.101384-1-jacopo+renesas@jmondi.org> (raw)

Hello, this v4 follows discussion on how to better handle the initial
reverse channel amplitude and incorporate Geert's and Kieran suggestion
to use the value in millivolts instead of relying on a boolean property.

v4:
- Replace 'maxim-high-threshold' with 'maxim,initial-reverse-channel-mV'
- Increse delay when reading OV490 chip ID to give it a bit more time to
  exit reset

v3:
https://patchwork.linuxtv.org/project/linux-media/list/?series=3657

Background in v1 cover letter:
https://www.spinics.net/lists/linux-renesas-soc/msg52886.html

I have tested on Eagle V3M with 4 RDACM21, but the whole point of
this series is to retain compatibility with RDACM20.

For this reason I have included 2 patches on top, not intended for merge
that re-propose DTS support for the MAXIM max9286 expansion board connected
to Salvator-X and add the newly introduced property to the DTS file.

Kieran, I know you have a working setup with RDACM20, the final two patches are
meant for ease your testing. Can you give this series a spin ?

Series based on latest renesas-drivers tag: renesas-drivers-2020-11-10-v5.10-rc3

If I get a confirmation this setup works on Salvator-X, I'll submit the new
property for inclusion to devicetree people, which I have left out at the
moment.

Thanks
  j

Jacopo Mondi (7):
  media: i2c: Add driver for RDACM21 camera module
  dt-bindings: media: max9286: Document
    'maxim,,initial-reverse-channel-mV"
  media: i2c: max9286: Break-out reverse channel setup
  media: i2c: max9286: Make channel amplitude programmable
  media: i2c: max9286: Configure reverse channel amplitude
  [DNI] arm64: dts: renesas: salvator-x-max9286: Specify channel
    amplitude
  [DNI] arm64: dts: renesas: eagle: Specify channel amplitude

Laurent Pinchart (1):
  arm64: dts: renesas: salvator-x: Add MAX9286 expansion board

 .../bindings/media/i2c/maxim,max9286.yaml     |  23 +
 MAINTAINERS                                   |  12 +
 .../arm64/boot/dts/renesas/r8a77970-eagle.dts |   1 +
 .../boot/dts/renesas/salvator-x-max9286.dtsi  | 396 +++++++++++++
 drivers/media/i2c/Kconfig                     |  13 +
 drivers/media/i2c/Makefile                    |   2 +
 drivers/media/i2c/max9286.c                   |  58 +-
 drivers/media/i2c/rdacm21.c                   | 539 ++++++++++++++++++
 8 files changed, 1031 insertions(+), 13 deletions(-)
 create mode 100644 arch/arm64/boot/dts/renesas/salvator-x-max9286.dtsi
 create mode 100644 drivers/media/i2c/rdacm21.c

--
2.29.1


             reply	other threads:[~2020-11-12 16:37 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-12 16:27 Jacopo Mondi [this message]
2020-11-12 16:27 ` [PATCH v4 1/8] media: i2c: Add driver for RDACM21 camera module Jacopo Mondi
2020-11-12 22:31   ` Kieran Bingham
2020-11-14 14:04     ` Jacopo Mondi
2020-11-16  9:08       ` Laurent Pinchart
2020-11-16 10:03         ` Jacopo Mondi
2020-11-16 10:20           ` Kieran Bingham
2020-11-16 11:33             ` Jacopo Mondi
2020-11-12 16:27 ` [PATCH v4 2/8] dt-bindings: media: max9286: Document 'maxim,,initial-reverse-channel-mV" Jacopo Mondi
2020-11-12 22:34   ` Kieran Bingham
2020-11-12 16:27 ` [PATCH v4 3/8] media: i2c: max9286: Break-out reverse channel setup Jacopo Mondi
2020-11-12 16:27 ` [PATCH v4 4/8] media: i2c: max9286: Make channel amplitude programmable Jacopo Mondi
2020-11-12 16:27 ` [PATCH v4 5/8] media: i2c: max9286: Configure reverse channel amplitude Jacopo Mondi
2020-11-12 22:38   ` Kieran Bingham
2020-11-12 16:27 ` [PATCH v4 6/8] arm64: dts: renesas: salvator-x: Add MAX9286 expansion board Jacopo Mondi
2020-11-12 16:27 ` [PATCH v4 7/8] [DNI] arm64: dts: renesas: salvator-x-max9286: Specify channel amplitude Jacopo Mondi
2020-11-12 16:27 ` [PATCH v4 8/8] [DNI] arm64: dts: renesas: eagle: " Jacopo Mondi
2020-11-12 20:52   ` Sergei Shtylyov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201112162729.101384-1-jacopo+renesas@jmondi.org \
    --to=jacopo+renesas@jmondi.org \
    --cc=geert@linux-m68k.org \
    --cc=hyunk@xilinx.com \
    --cc=kieran.bingham+renesas@ideasonboard.com \
    --cc=laurent.pinchart+renesas@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=manivannan.sadhasivam@linaro.org \
    --cc=niklas.soderlund+renesas@ragnatech.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).