From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00B42C5519F for ; Thu, 12 Nov 2020 18:00:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A7CEF221E9 for ; Thu, 12 Nov 2020 18:00:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726890AbgKLSAy (ORCPT ); Thu, 12 Nov 2020 13:00:54 -0500 Received: from mail.kernel.org ([198.145.29.99]:33448 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726864AbgKLSAu (ORCPT ); Thu, 12 Nov 2020 13:00:50 -0500 Received: from gaia (unknown [2.26.170.190]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CC841221E9; Thu, 12 Nov 2020 18:00:48 +0000 (UTC) Date: Thu, 12 Nov 2020 18:00:46 +0000 From: Catalin Marinas To: Ionela Voinescu Cc: mark.rutland@arm.com, sudeep.holla@arm.com, will@kernel.org, morten.rasmussen@arm.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 3/3] arm64: implement CPPC FFH support using AMUs Message-ID: <20201112180045.GO29613@gaia> References: <20201106125334.21570-1-ionela.voinescu@arm.com> <20201106125334.21570-4-ionela.voinescu@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201106125334.21570-4-ionela.voinescu@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 06, 2020 at 12:53:34PM +0000, Ionela Voinescu wrote: > +static inline > +int counters_read_on_cpu(int cpu, smp_call_func_t func, u64 *val) > +{ > + if (!cpu_has_amu_feat(cpu)) > + return -EOPNOTSUPP; > + > + smp_call_function_single(cpu, func, val, 1); > + > + return 0; > +} I got lost in the cpufreq call chains. Can this function ever be called with interrupts disabled? -- Catalin