linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v4 0/3] Add support for frequency invariance to AMD EPYC Zen2
@ 2020-11-12 18:26 Giovanni Gherdovich
  2020-11-12 18:26 ` [PATCH v4 1/3] x86, sched: Calculate frequency invariance for AMD systems Giovanni Gherdovich
                   ` (2 more replies)
  0 siblings, 3 replies; 12+ messages in thread
From: Giovanni Gherdovich @ 2020-11-12 18:26 UTC (permalink / raw)
  To: Borislav Petkov, Thomas Gleixner, Ingo Molnar, Peter Zijlstra,
	Len Brown, Rafael J . Wysocki
  Cc: Jon Grimm, Nathan Fontenot, Yazen Ghannam, Thomas Lendacky,
	Mel Gorman, Pu Wen, Viresh Kumar, Juri Lelli, Vincent Guittot,
	Dietmar Eggemann, Doug Smythies, x86, linux-pm, linux-kernel,
	linux-acpi, Giovanni Gherdovich

v3 at https://lore.kernel.org/lkml/20201110200519.18180-1-ggherdovich@suse.cz/

Changes wrt v3:

- Correct the #ifdef guard for cppc_get_perf_caps() from CONFIG_ACPI to
  CONFIG_ACPI_CPPC_LIB (reported by "kernel test robot <lkp@intel.com>")

- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
Cover Letter from v3:

v2 at https://lore.kernel.org/lkml/20201110183054.15883-1-ggherdovich@suse.cz/

Changes wrt v2:

- "code golf" on the function function init_freq_invariance_cppc().
  Make better use of the "secondary" argument to init_freq_invariance(),
  which was introduced at b56e7d45e807 ("x86, sched: Don't enable static key
  when starting secondary CPUs") to deal with CPU hotplug.

- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
Cover Letter from v2:

v1 at https://lore.kernel.org/lkml/20201110083936.31994-1-ggherdovich@suse.cz/

Changes wrt v1:

- made initialization safe under CPU hotplug.
  The function init_freq_invariance_cppc now lets only the first caller
  into init_freq_invariance().

- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
Cover Letter from v1:

This series adds support for frequency invariant accounting on AMD EPYC Zen2
(aka "Rome"). The first patch by Nathan lays out the foundation by querying
ACPI infrastructure for the max boost frequency of the system. Specifically,
this value is available via the CPPC machinery; the previous EPYC generation,
namely Zen aka "Naples", doesn't implement that and frequency invariance won't
be supported.

The second patch sets the estimate for freq_max to be the midpoint between
max_boost and max_P, as that works slightly better in practice.

A side effect of this series is to provide, with the invariant schedutil
governor, a suitable baseline to evaluate a (still work-in-progress)
CPPC-based cpufreq driver for the AMD platform (see
https://lore.kernel.org/lkml/cover.1562781484.git.Janakarajan.Natarajan@amd.com
if/when it will resubmitted.


Giovanni Gherdovich (2):
  x86, sched: Use midpoint of max_boost and max_P for frequency
    invariance on AMD EPYC
  x86: Print ratio freq_max/freq_base used in frequency invariance
    calculations

Nathan Fontenot (1):
  x86, sched: Calculate frequency invariance for AMD systems

 arch/x86/include/asm/topology.h |  8 ++++
 arch/x86/kernel/smpboot.c       | 79 ++++++++++++++++++++++++++++++---
 drivers/acpi/cppc_acpi.c        |  3 ++
 3 files changed, 85 insertions(+), 5 deletions(-)

-- 
2.26.2


^ permalink raw reply	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2020-12-11  9:36 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-12 18:26 [PATCH v4 0/3] Add support for frequency invariance to AMD EPYC Zen2 Giovanni Gherdovich
2020-11-12 18:26 ` [PATCH v4 1/3] x86, sched: Calculate frequency invariance for AMD systems Giovanni Gherdovich
2020-12-03  9:13   ` [tip: sched/core] " tip-bot2 for Nathan Fontenot
2020-12-11  9:34   ` tip-bot2 for Nathan Fontenot
2020-11-12 18:26 ` [PATCH v4 2/3] x86, sched: Use midpoint of max_boost and max_P for frequency invariance on AMD EPYC Giovanni Gherdovich
2020-12-03  9:13   ` [tip: sched/core] " tip-bot2 for Giovanni Gherdovich
2020-12-04 17:03   ` [PATCH v4 RESEND] " Giovanni Gherdovich
2020-12-04 17:10     ` Giovanni Gherdovich
2020-12-11  9:34   ` [tip: sched/core] " tip-bot2 for Giovanni Gherdovich
2020-11-12 18:26 ` [PATCH v4 3/3] x86: Print ratio freq_max/freq_base used in frequency invariance calculations Giovanni Gherdovich
2020-12-03  9:13   ` [tip: sched/core] " tip-bot2 for Giovanni Gherdovich
2020-12-11  9:34   ` tip-bot2 for Giovanni Gherdovich

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).