From: Arvind Sankar <nivedita@alum.mit.edu>
To: Adrian Ratiu <adrian.ratiu@collabora.com>
Cc: Nick Desaulniers <ndesaulniers@google.com>,
Nathan Chancellor <natechancellor@gmail.com>,
Arnd Bergmann <arnd@arndb.de>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
clang-built-linux <clang-built-linux@googlegroups.com>,
Russell King <linux@armlinux.org.uk>,
LKML <linux-kernel@vger.kernel.org>,
Collabora Kernel ML <kernel@collabora.com>,
Ard Biesheuvel <ardb@kernel.org>
Subject: Re: [PATCH 2/2] arm: lib: xor-neon: disable clang vectorization
Date: Thu, 12 Nov 2020 16:50:33 -0500 [thread overview]
Message-ID: <20201112215033.GA438824@rani.riverdale.lan> (raw)
In-Reply-To: <87lff8gesg.fsf@collabora.com>
On Wed, Nov 11, 2020 at 04:15:59PM +0200, Adrian Ratiu wrote:
> On Tue, 10 Nov 2020, Nick Desaulniers <ndesaulniers@google.com>
> wrote:
> >
> > Yes, though additionally Arvind points out that this code is
> > kind of curious if there was overlap; maybe the parameters
> > should just be restrict-qualified.
> >
>
> For now I think I'll just re-send the GCC changes and leave the
> Clang optimization as is, until we better understand what's
> happening and what's the best way to enable it.
>
Note that the __restrict__ keywords also help GCC -- it saves it from
having to emit the non-vectorized version and switch between the two at
runtime. If we can verify it's safe, it's a good thing to add all
around.
next prev parent reply other threads:[~2020-11-12 21:50 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-06 5:14 [PATCH 0/2] arm: lib: xor-neon: Remove warn & disble neon vect Adrian Ratiu
2020-11-06 5:14 ` [PATCH 1/2] arm: lib: xor-neon: remove unnecessary GCC < 4.6 warning Adrian Ratiu
2020-11-06 14:46 ` Arnd Bergmann
2020-11-06 18:03 ` Nathan Chancellor
2020-11-06 21:46 ` Arnd Bergmann
2020-11-06 5:14 ` [PATCH 2/2] arm: lib: xor-neon: disable clang vectorization Adrian Ratiu
2020-11-06 10:14 ` Nathan Chancellor
2020-11-06 11:50 ` Adrian Ratiu
2020-11-06 18:01 ` Nathan Chancellor
2020-11-06 19:52 ` Nick Desaulniers
2020-11-07 18:07 ` Adrian Ratiu
2020-11-09 19:53 ` Adrian Ratiu
2020-11-10 21:41 ` Nick Desaulniers
2020-11-10 22:15 ` Arvind Sankar
2020-11-10 22:36 ` Nick Desaulniers
2020-11-10 22:39 ` Nick Desaulniers
2020-11-10 22:39 ` Nick Desaulniers
2020-11-10 22:54 ` Arvind Sankar
2020-11-10 23:56 ` Adrian Ratiu
2020-11-11 0:18 ` Nick Desaulniers
2020-11-11 14:15 ` Adrian Ratiu
2020-11-12 21:50 ` Arvind Sankar [this message]
2020-11-12 21:55 ` Nick Desaulniers
2020-11-07 10:22 ` Russell King - ARM Linux admin
2020-11-07 18:12 ` Adrian Ratiu
2020-11-08 17:40 ` Arvind Sankar
2020-11-08 18:09 ` Arvind Sankar
2020-11-08 20:14 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201112215033.GA438824@rani.riverdale.lan \
--to=nivedita@alum.mit.edu \
--cc=adrian.ratiu@collabora.com \
--cc=ardb@kernel.org \
--cc=arnd@arndb.de \
--cc=clang-built-linux@googlegroups.com \
--cc=kernel@collabora.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=natechancellor@gmail.com \
--cc=ndesaulniers@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).