Re: [PATCH net-next v2 02/11] net: dsa: microchip: support for "ethernet-ports" node

From: Vladimir Oltean <olteanv@gmail.com>
To: Christian Eggers <ceggers@arri.de>
Cc: Jakub Kicinski <kuba@kernel.org>, Andrew Lunn <andrew@lunn.ch>,
	Richard Cochran <richardcochran@gmail.com>,
	Rob Herring <robh+dt@kernel.org>,
	Vivien Didelot <vivien.didelot@gmail.com>,
	"David S . Miller" <davem@davemloft.net>,
	Kurt Kanzenbach <kurt.kanzenbach@linutronix.de>,
	George McCollister <george.mccollister@gmail.com>,
	Marek Vasut <marex@denx.de>,
	Helmut Grohne <helmut.grohne@intenta.de>,
	Paul Barker <pbarker@konsulko.com>,
	Codrin Ciubotariu <codrin.ciubotariu@microchip.com>,
	Tristram Ha <Tristram.Ha@microchip.com>,
	Woojung Huh <woojung.huh@microchip.com>,
	Microchip Linux Driver Support <UNGLinuxDriver@microchip.com>,
	netdev@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2 02/11] net: dsa: microchip: support for "ethernet-ports" node
Date: Fri, 13 Nov 2020 00:42:43 +0200	[thread overview]
Message-ID: <20201112224243.u6oxe4gnfrv7onkz@skbuf> (raw)
In-Reply-To: <20201112153537.22383-3-ceggers@arri.de>

On Thu, Nov 12, 2020 at 04:35:28PM +0100, Christian Eggers wrote:
> The dsa.yaml device tree binding allows "ethernet-ports" (preferred) and
> "ports".
>
> Signed-off-by: Christian Eggers <ceggers@arri.de>
> ---
>  drivers/net/dsa/microchip/ksz_common.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/dsa/microchip/ksz_common.c b/drivers/net/dsa/microchip/ksz_common.c
> index 71cd1828e25d..a135fd5a9264 100644
> --- a/drivers/net/dsa/microchip/ksz_common.c
> +++ b/drivers/net/dsa/microchip/ksz_common.c
> @@ -427,7 +427,9 @@ int ksz_switch_register(struct ksz_device *dev,
>  		ret = of_get_phy_mode(dev->dev->of_node, &interface);
>  		if (ret == 0)
>  			dev->compat_interface = interface;
> -		ports = of_get_child_by_name(dev->dev->of_node, "ports");
> +		ports = of_get_child_by_name(dev->dev->of_node, "ethernet-ports");
> +		if (!ports)
> +			ports = of_get_child_by_name(dev->dev->of_node, "ports");

Man, I didn't think there could be something as uninspired as naming the
private structure of your driver "dev"...

>  		if (ports)
>  			for_each_available_child_of_node(ports, port) {
>  				if (of_property_read_u32(port, "reg",
> --

Either way:

Reviewed-by: Vladimir Oltean <olteanv@gmail.com>