From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4AA0EC55ABD for ; Fri, 13 Nov 2020 07:56:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 082EA208D5 for ; Fri, 13 Nov 2020 07:56:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="AerqIHFg" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726205AbgKMH4f (ORCPT ); Fri, 13 Nov 2020 02:56:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53088 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726172AbgKMH4f (ORCPT ); Fri, 13 Nov 2020 02:56:35 -0500 Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0573CC0613D1 for ; Thu, 12 Nov 2020 23:56:35 -0800 (PST) Received: by mail-wm1-x344.google.com with SMTP id c9so7244070wml.5 for ; Thu, 12 Nov 2020 23:56:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=cOP+0eig0gjhxgKfd2cuaF6IlWUlTJn2OZzeeMSeWhc=; b=AerqIHFgop/7P2PMm34Kz4CM7dd9l3bj7/XhKrLyW6aWmKvZBgBzqELCxRfY2BluTP twdkIIzY7N/ZBOZ5sntVK6ItihT7OxNfxff3Cu5DPL/JFIzALuOJ3iu1lNRJtZuZ4Fcu IDf0YHJFazOe8fRL+vywm3GiYlackXME6lN9lftrCr48IXm4gOxGKUDPkWJgbkFv7grq nIoV2i/T6k7syAq4sZCgDW+7XhUCu9qBfTjCn2HUBjHcIxKigL8JF0PElYgCP0b3YhGo cWXZKkVlJKcxJ0Ns4LjlG+iNPDQW/zHBwaXng6FBoqebvNCtZAmeJ2CvhKeBosdRBX6N /Qjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=cOP+0eig0gjhxgKfd2cuaF6IlWUlTJn2OZzeeMSeWhc=; b=JBotSAg/qGHxVe7RUXNeADXMt5bhu2YLL9lGojKBKzNI3EY4q8Y9myjf0NbLgtvv0f HEvzDHL0sKQP7QR1QUONv69OMVZC3KMhsbYMxYi/xyJuirUI56W9/QnNXXNtauny8C8i DNVOPWv9PFYgeXWFd9lLPYj30lbJq4HR3/5ToayJS1UZaYzRiEO/qMY5rQWwcnCNZVUJ lxpGnXvRmOQ23oxBT0Rfc0EI3/HK+cHiNT31q3l7zPLbcr27YHhfDgyfSErMtNRcO44L WZXUrM9zESF56v4wvAXjwQGzm+GF4USwIegBd2pZFsyjrIGxz4gmDTJa3thehofN58QC Uw4Q== X-Gm-Message-State: AOAM532HR02w1UIa3iifXcB3GBmimzEu4pt7j3cnCyCXMk8ks/u9NHZn wXzAr5HKUd8vh2ao4CBbAE+MeA== X-Google-Smtp-Source: ABdhPJwkNK+wFKVZpkIBP9nA+L6UcyZoyc3Re9G9w9f2S1MCGByMREJr+NBCR3FXY7k421EsDRw2BQ== X-Received: by 2002:a7b:c201:: with SMTP id x1mr1175562wmi.42.1605254193779; Thu, 12 Nov 2020 23:56:33 -0800 (PST) Received: from dell ([91.110.221.159]) by smtp.gmail.com with ESMTPSA id t11sm9212415wmf.35.2020.11.12.23.56.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Nov 2020 23:56:33 -0800 (PST) Date: Fri, 13 Nov 2020 07:56:31 +0000 From: Lee Jones To: Dmitry Torokhov Cc: linux-kernel@vger.kernel.org, Henrik Rydberg , James Hilliard , Daniel Ritz , linux-input@vger.kernel.org Subject: Re: [PATCH 07/15] input: touchscreen: usbtouchscreen: Remove unused variable 'ret' Message-ID: <20201113075631.GI2787115@dell> References: <20201112110204.2083435-1-lee.jones@linaro.org> <20201112110204.2083435-8-lee.jones@linaro.org> <20201113073655.GF356503@dtor-ws> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20201113073655.GF356503@dtor-ws> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 12 Nov 2020, Dmitry Torokhov wrote: > On Thu, Nov 12, 2020 at 11:01:56AM +0000, Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > > > drivers/input/touchscreen/usbtouchscreen.c: In function ‘nexio_read_data’: > > drivers/input/touchscreen/usbtouchscreen.c:1052:50: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] > > > > Cc: Dmitry Torokhov > > Cc: Henrik Rydberg > > Cc: James Hilliard > > Cc: Daniel Ritz > > Cc: linux-input@vger.kernel.org > > Signed-off-by: Lee Jones > > --- > > drivers/input/touchscreen/usbtouchscreen.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/input/touchscreen/usbtouchscreen.c b/drivers/input/touchscreen/usbtouchscreen.c > > index 397cb1d3f481b..c3b7130cd9033 100644 > > --- a/drivers/input/touchscreen/usbtouchscreen.c > > +++ b/drivers/input/touchscreen/usbtouchscreen.c > > @@ -1049,7 +1049,7 @@ static int nexio_read_data(struct usbtouch_usb *usbtouch, unsigned char *pkt) > > unsigned int data_len = be16_to_cpu(packet->data_len); > > unsigned int x_len = be16_to_cpu(packet->x_len); > > unsigned int y_len = be16_to_cpu(packet->y_len); > > - int x, y, begin_x, begin_y, end_x, end_y, w, h, ret; > > + int x, y, begin_x, begin_y, end_x, end_y, w, h; > > > > /* got touch data? */ > > if ((pkt[0] & 0xe0) != 0xe0) > > @@ -1061,7 +1061,7 @@ static int nexio_read_data(struct usbtouch_usb *usbtouch, unsigned char *pkt) > > x_len -= 0x80; > > > > /* send ACK */ > > - ret = usb_submit_urb(priv->ack, GFP_ATOMIC); > > + usb_submit_urb(priv->ack, GFP_ATOMIC); > > I wonder if we should handle potential errors instead. Your call. I'll do whatever you decide. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog