linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Miroslav Benes <mbenes@suse.cz>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Masami Hiramatsu <mhiramat@kernel.org>,
	Josh Poimboeuf <jpoimboe@redhat.com>,
	Jiri Kosina <jikos@kernel.org>,
	live-patching@vger.kernel.org
Subject: Re: [PATCH 3/3 v6] livepatch: Use the default ftrace_ops instead of REGS when ARGS is available
Date: Fri, 13 Nov 2020 08:10:06 -0500	[thread overview]
Message-ID: <20201113081006.00c350c7@oasis.local.home> (raw)
In-Reply-To: <alpine.LSU.2.21.2011131229460.16581@pobox.suse.cz>

On Fri, 13 Nov 2020 12:31:11 +0100 (CET)
Miroslav Benes <mbenes@suse.cz> wrote:

> > +++ b/arch/x86/include/asm/livepatch.h
> > @@ -12,9 +12,9 @@
> >  #include <asm/setup.h>
> >  #include <linux/ftrace.h>
> >  
> > -static inline void klp_arch_set_pc(struct pt_regs *regs, unsigned long ip)
> > +static inline void klp_arch_set_pc(struct ftrace_regs *fregs, unsigned long ip)
> >  {
> > -	regs->ip = ip;
> > +	ftrace_regs_set_ip(fregs, ip);  
> 
> You forgot to update the call site :)

Bah. This would have been caught via my full test suite, but I only ran
the cross compiling tests :-P

Thanks, will fix in v7.

-- Steve

  reply	other threads:[~2020-11-13 13:10 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-13  2:01 [PATCH 0/3 v6] ftrace: Add access to function arguments for all callbacks Steven Rostedt
2020-11-13  2:01 ` [PATCH 1/3 v6] ftrace: Have the callbacks receive a struct ftrace_regs instead of pt_regs Steven Rostedt
2020-11-13  2:01 ` [PATCH 2/3 v6] ftrace/x86: Allow for arguments to be passed in to ftrace_regs by default Steven Rostedt
2020-11-13  2:01 ` [PATCH 3/3 v6] livepatch: Use the default ftrace_ops instead of REGS when ARGS is available Steven Rostedt
2020-11-13 11:31   ` Miroslav Benes
2020-11-13 13:10     ` Steven Rostedt [this message]
2020-11-13  8:07 ` [PATCH 0/3 v6] ftrace: Add access to function arguments for all callbacks Peter Zijlstra
2020-11-13 13:26   ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201113081006.00c350c7@oasis.local.home \
    --to=rostedt@goodmis.org \
    --cc=akpm@linux-foundation.org \
    --cc=jikos@kernel.org \
    --cc=jpoimboe@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=live-patching@vger.kernel.org \
    --cc=mbenes@suse.cz \
    --cc=mhiramat@kernel.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).