linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/2] phy: qualcomm: usb: Fix two COMPILE_TEST errors
@ 2020-11-13 15:12 Bryan O'Donoghue
  2020-11-13 15:12 ` [PATCH 1/2] phy: qualcomm: usb: Fix SuperSpeed PHY OF dependency Bryan O'Donoghue
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Bryan O'Donoghue @ 2020-11-13 15:12 UTC (permalink / raw)
  To: kishon, vkoul; +Cc: linux-kernel, Bryan O'Donoghue

kernel build robot fired this email at me about an hour ago
https://lkml.org/lkml/2020/11/13/414

The build robot has flagged the super-speed PHY driver but both Kconfig
entries have the same error. Fix those now.

verified with "make menuconfig ARCH=s390"

Bryan O'Donoghue (2):
  phy: qualcomm: usb: Fix SuperSpeed PHY OF dependency
  phy: qualcomm: Fix 28 nm Hi-Speed USB PHY OF dependency

 drivers/phy/qualcomm/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

-- 
2.28.0


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 1/2] phy: qualcomm: usb: Fix SuperSpeed PHY OF dependency
  2020-11-13 15:12 [PATCH 0/2] phy: qualcomm: usb: Fix two COMPILE_TEST errors Bryan O'Donoghue
@ 2020-11-13 15:12 ` Bryan O'Donoghue
  2020-11-13 15:12 ` [PATCH 2/2] phy: qualcomm: Fix 28 nm Hi-Speed USB " Bryan O'Donoghue
  2020-11-16  7:50 ` [PATCH 0/2] phy: qualcomm: usb: Fix two COMPILE_TEST errors Vinod Koul
  2 siblings, 0 replies; 4+ messages in thread
From: Bryan O'Donoghue @ 2020-11-13 15:12 UTC (permalink / raw)
  To: kishon, vkoul; +Cc: linux-kernel, Bryan O'Donoghue, kernel test robot

This Kconfig entry should declare a dependency on OF

Fixes: 6076967a500c ("phy: qualcomm: usb: Add SuperSpeed PHY driver")
Reported-by: kernel test robot <lkp@intel.com>
Link: https://lkml.org/lkml/2020/11/13/414
Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
---
 drivers/phy/qualcomm/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/phy/qualcomm/Kconfig b/drivers/phy/qualcomm/Kconfig
index 928db510b86c..9129c4b8bb9b 100644
--- a/drivers/phy/qualcomm/Kconfig
+++ b/drivers/phy/qualcomm/Kconfig
@@ -98,7 +98,7 @@ config PHY_QCOM_USB_HS_28NM
 
 config PHY_QCOM_USB_SS
 	tristate "Qualcomm USB Super-Speed PHY driver"
-	depends on ARCH_QCOM || COMPILE_TEST
+	depends on OF && (ARCH_QCOM || COMPILE_TEST)
 	depends on EXTCON || !EXTCON # if EXTCON=m, this cannot be built-in
 	select GENERIC_PHY
 	help
-- 
2.28.0


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 2/2] phy: qualcomm: Fix 28 nm Hi-Speed USB PHY OF dependency
  2020-11-13 15:12 [PATCH 0/2] phy: qualcomm: usb: Fix two COMPILE_TEST errors Bryan O'Donoghue
  2020-11-13 15:12 ` [PATCH 1/2] phy: qualcomm: usb: Fix SuperSpeed PHY OF dependency Bryan O'Donoghue
@ 2020-11-13 15:12 ` Bryan O'Donoghue
  2020-11-16  7:50 ` [PATCH 0/2] phy: qualcomm: usb: Fix two COMPILE_TEST errors Vinod Koul
  2 siblings, 0 replies; 4+ messages in thread
From: Bryan O'Donoghue @ 2020-11-13 15:12 UTC (permalink / raw)
  To: kishon, vkoul; +Cc: linux-kernel, Bryan O'Donoghue

This Kconfig entry should declare a dependency on OF

Fixes: 67b27dbeac4d ("phy: qualcomm: Add Synopsys 28nm Hi-Speed USB PHY driver")
Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
---
 drivers/phy/qualcomm/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/phy/qualcomm/Kconfig b/drivers/phy/qualcomm/Kconfig
index 9129c4b8bb9b..7f6fcb8ec5ba 100644
--- a/drivers/phy/qualcomm/Kconfig
+++ b/drivers/phy/qualcomm/Kconfig
@@ -87,7 +87,7 @@ config PHY_QCOM_USB_HSIC
 
 config PHY_QCOM_USB_HS_28NM
 	tristate "Qualcomm 28nm High-Speed PHY"
-	depends on ARCH_QCOM || COMPILE_TEST
+	depends on OF && (ARCH_QCOM || COMPILE_TEST)
 	depends on EXTCON || !EXTCON # if EXTCON=m, this cannot be built-in
 	select GENERIC_PHY
 	help
-- 
2.28.0


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 0/2] phy: qualcomm: usb: Fix two COMPILE_TEST errors
  2020-11-13 15:12 [PATCH 0/2] phy: qualcomm: usb: Fix two COMPILE_TEST errors Bryan O'Donoghue
  2020-11-13 15:12 ` [PATCH 1/2] phy: qualcomm: usb: Fix SuperSpeed PHY OF dependency Bryan O'Donoghue
  2020-11-13 15:12 ` [PATCH 2/2] phy: qualcomm: Fix 28 nm Hi-Speed USB " Bryan O'Donoghue
@ 2020-11-16  7:50 ` Vinod Koul
  2 siblings, 0 replies; 4+ messages in thread
From: Vinod Koul @ 2020-11-16  7:50 UTC (permalink / raw)
  To: Bryan O'Donoghue; +Cc: kishon, linux-kernel

On 13-11-20, 15:12, Bryan O'Donoghue wrote:
> kernel build robot fired this email at me about an hour ago
> https://lkml.org/lkml/2020/11/13/414
> 
> The build robot has flagged the super-speed PHY driver but both Kconfig
> entries have the same error. Fix those now.
> 
> verified with "make menuconfig ARCH=s390"

Applied, thanks

-- 
~Vinod

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-11-16  7:54 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-13 15:12 [PATCH 0/2] phy: qualcomm: usb: Fix two COMPILE_TEST errors Bryan O'Donoghue
2020-11-13 15:12 ` [PATCH 1/2] phy: qualcomm: usb: Fix SuperSpeed PHY OF dependency Bryan O'Donoghue
2020-11-13 15:12 ` [PATCH 2/2] phy: qualcomm: Fix 28 nm Hi-Speed USB " Bryan O'Donoghue
2020-11-16  7:50 ` [PATCH 0/2] phy: qualcomm: usb: Fix two COMPILE_TEST errors Vinod Koul

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).