From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8C5EC55ABD for ; Fri, 13 Nov 2020 18:54:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 60136221EB for ; Fri, 13 Nov 2020 18:54:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726308AbgKMSy3 (ORCPT ); Fri, 13 Nov 2020 13:54:29 -0500 Received: from mail-wm1-f66.google.com ([209.85.128.66]:54081 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726090AbgKMSy2 (ORCPT ); Fri, 13 Nov 2020 13:54:28 -0500 Received: by mail-wm1-f66.google.com with SMTP id p22so9594820wmg.3; Fri, 13 Nov 2020 10:54:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=tzL14T6rCTSN4RsuVPtTnWJiOyUZXc1z2gXeQlm5kq8=; b=gCvOupb3ISWmYY9xXbqcFv5BfoEfp9v+Q5AKWACfOj7Dx+ta7muduPNtC0Zn0KQeBy cYefoRUp3xnm1ou7naolKgLP0MjOcIhJ2JzQXDtVRlwn3GYi7JfPr7+sCitTaTKC4RVd 2dSknXtk1ac4FpPdRal04vGFR4BuXKYlg1B51qREVqTwqoSgNOgLUnTSp5FrK68xbcCZ PPeb2DXt8muR+LrCiKEYaOsxwQRggxFDDApb8nmbBtEzOwYYu2mG9hCS1wP8zS25HRVb VZTO59F/Y4yJlqQ7+fM6Ye5wIb0tBySvhDd+Bvd4jqyDTNEjVywZPei/xiE8+zSMaDuS Gv/A== X-Gm-Message-State: AOAM532LqRgi4YI7Im4QJBqxxH5Z/RViIG5kcU9je5nabhM/jLWUNSBJ T/8MH1Pq0LUmAJHoMZ9qO7s= X-Google-Smtp-Source: ABdhPJwZPyvPPpg2JGbFWoSxXPFRAFGFLuAl484xnZIUH09JJJ8ZkGkOxsNN8/LkABhANC6ma/BPcA== X-Received: by 2002:a7b:c8c5:: with SMTP id f5mr889104wml.174.1605293666845; Fri, 13 Nov 2020 10:54:26 -0800 (PST) Received: from liuwe-devbox-debian-v2 ([51.145.34.42]) by smtp.gmail.com with ESMTPSA id u5sm7158222wro.56.2020.11.13.10.54.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Nov 2020 10:54:26 -0800 (PST) Date: Fri, 13 Nov 2020 18:54:24 +0000 From: Wei Liu To: "Andrea Parri (Microsoft)" Cc: linux-kernel@vger.kernel.org, "K . Y . Srinivasan" , Haiyang Zhang , Stephen Hemminger , Wei Liu , linux-hyperv@vger.kernel.org, Andres Beltran , Michael Kelley , Saruhan Karademir , Juan Vazquez , "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org Subject: Re: [PATCH v9 2/3] scsi: storvsc: Use vmbus_requestor to generate transaction IDs for VMBus hardening Message-ID: <20201113185424.ujdfx6ot7siqr5qh@liuwe-devbox-debian-v2> References: <20201109100402.8946-1-parri.andrea@gmail.com> <20201109100402.8946-3-parri.andrea@gmail.com> <20201113113327.dmium67e32iadqbz@liuwe-devbox-debian-v2> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201113113327.dmium67e32iadqbz@liuwe-devbox-debian-v2> User-Agent: NeoMutt/20180716 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 13, 2020 at 11:33:27AM +0000, Wei Liu wrote: > On Mon, Nov 09, 2020 at 11:04:01AM +0100, Andrea Parri (Microsoft) wrote: > > From: Andres Beltran > > > > Currently, pointers to guest memory are passed to Hyper-V as > > transaction IDs in storvsc. In the face of errors or malicious > > behavior in Hyper-V, storvsc should not expose or trust the transaction > > IDs returned by Hyper-V to be valid guest memory addresses. Instead, > > use small integers generated by vmbus_requestor as requests > > (transaction) IDs. > > > > Signed-off-by: Andres Beltran > > Co-developed-by: Andrea Parri (Microsoft) > > Signed-off-by: Andrea Parri (Microsoft) > > Reviewed-by: Michael Kelley > > Cc: "James E.J. Bottomley" > > Cc: "Martin K. Petersen" > > Cc: linux-scsi@vger.kernel.org > > Reviewed-by: Wei Liu Martin already gave his ack back in July. I guess nothing substantial changed so it should have been carried over? Wei.