Re: [PATCH v2 0/6] Add AHCI support for Tegra186

From: Thierry Reding <thierry.reding@gmail.com>
To: Sowjanya Komatineni <skomatineni@nvidia.com>,
	Preetham Chandru <pchandru@nvidia.com>
Cc: jonathanh@nvidia.com, robh+dt@kernel.org,
	devicetree@vger.kernel.org, linux-ide@vger.kernel.org,
	linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/6] Add AHCI support for Tegra186
Date: Fri, 13 Nov 2020 21:29:04 +0100	[thread overview]
Message-ID: <20201113202904.GC1416567@ulmo> (raw)
In-Reply-To: <1605296218-2510-1-git-send-email-skomatineni@nvidia.com>

[-- Attachment #1: Type: text/plain, Size: 2462 bytes --]

On Fri, Nov 13, 2020 at 11:36:52AM -0800, Sowjanya Komatineni wrote:
> This series adds support for AHCI-compliant SATA to Tegra186 SoC.
> 
> This series includes patches for
> - Converting text based dt-binding document to YAML.
> - Adding dt-bindings for Tegra186.
> - Enabling AHCI-compliance SATA for Jetson TX2.
> - Adding Tegra186 support to Tegra AHCI driver.
> 
> Delta between patch versions:
> [v2]:	v1 feedback related to yaml dt-binding.
> 	Removed conditional reset order in yaml and updated dts files
> 	to maintain same order for commonly available resets across
> 	Tegra124 thru Tegra186.
> 
> 
> Sowjanya Komatineni (6):
>   arm: tegra: Change order of SATA resets for Tegra124
>   arm64: tegra: Change order of SATA resets for Tegra132 and Tegra210
>   dt-bindings: ata: tegra: Convert binding documentation to YAML
>   dt-binding: ata: tegra: Add dt-binding documentation for Tegra186
>   arm64: tegra: Enable AHCI on Jetson TX2
>   ata: ahci_tegra: Add AHCI support for Tegra186
> 
>  .../devicetree/bindings/ata/nvidia,tegra-ahci.yaml | 175 +++++++++++++++++++++
>  .../bindings/ata/nvidia,tegra124-ahci.txt          |  44 ------
>  arch/arm/boot/dts/tegra124.dtsi                    |   6 +-
>  arch/arm64/boot/dts/nvidia/tegra132.dtsi           |   6 +-
>  arch/arm64/boot/dts/nvidia/tegra186-p2771-0000.dts |   4 +
>  arch/arm64/boot/dts/nvidia/tegra186.dtsi           |  28 ++++
>  arch/arm64/boot/dts/nvidia/tegra210.dtsi           |   6 +-
>  drivers/ata/ahci_tegra.c                           |  60 +++++--
>  8 files changed, 263 insertions(+), 66 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/ata/nvidia,tegra-ahci.yaml
>  delete mode 100644 Documentation/devicetree/bindings/ata/nvidia,tegra124-ahci.txt

Preetham,

I vaguely recall discussing this with you previously and I think you had
mentioned that we may need changes to the XUSB pad controller to add
support for the SATA lanes on Tegra186 and later.

I've tested this patch and it does seem to work fine, so I wonder if
we're just getting lucky and the power on defaults are just right for
this use-case (I've only tested on Jetson TX2) or if we don't need any
support in the XUSB pad controller driver after all.

I'm not sure if you're subscribed to linux-tegra, but if not, here's a
link to this complete patchset:

	http://patchwork.ozlabs.org/project/linux-tegra/list/?series=214338

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]