From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62D67C63697 for ; Fri, 13 Nov 2020 21:39:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 200C62224D for ; Fri, 13 Nov 2020 21:39:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QsOQMrz4" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726255AbgKMVjr (ORCPT ); Fri, 13 Nov 2020 16:39:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42554 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725981AbgKMVjo (ORCPT ); Fri, 13 Nov 2020 16:39:44 -0500 Received: from mail-ed1-x541.google.com (mail-ed1-x541.google.com [IPv6:2a00:1450:4864:20::541]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CA065C0613D1; Fri, 13 Nov 2020 13:39:42 -0800 (PST) Received: by mail-ed1-x541.google.com with SMTP id v22so12454080edt.9; Fri, 13 Nov 2020 13:39:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=GY3sxkg3pkqNwc0wL90fxKYZ45EqrlmAu69mRryF7BM=; b=QsOQMrz4ShhUlES7isqspW1o38dZdZLYZ3bnw/pYncm8p7NSiCAur8hXoz+MgjoiuC oUETvqL8Opp+A5mRL77tkDmyeoUJNPzhRbwP6sXK/suo4a30oJdLx9sJeV/3wK4idJTP JWktnT9+kU1yb9FdiQ/6HgFNF9DgVoDBa7gNEMmUojuVjHGxxC4GinQVDn682o7A6doU 9HDipvWp0f8ln8xzFQsMcUyd+GdzzOBg6okpdp3D6gkxDVaD0AOEeSGzPgyS0+PK7z9i z6o6KrTmsKKq/6t5c+vWvRpnBrCbo1pzb9ZmO3VXiQIddCjjIxW4yiu+iaU0/Wh0veSb ZhBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=GY3sxkg3pkqNwc0wL90fxKYZ45EqrlmAu69mRryF7BM=; b=sfSHKQldyK/Yx1/IokCI+jLf5SsgleKXhcFYLU6nzDHCr8po7JtRO3XaV6L1XOTTgS a6piG2rIwtfYrqud/gm7EbRiD6KI1EKbN8A2Nv+rjDP5aYFJoBqO5ibh+FIBi4C2KZJa B9fEKtIj3p24/cjeeMmrYApqLYnRos6gpa+7yXeHt+ynq3dIdxwA7d/t6GTmqWNL3Qjz yNcTi/XLwp6DsEhV+VDIMHc/r/sZDHU0HUZcbkuPZdg1gNqGBC/vVtoqrPbVq1B37e8m 8sNYExgfkYe1Yt2A55D28WQomzTdlFdjZyrqndCmxzfNn5Jk0+r3K9Gwy1Nni2vXaQKR I3Sg== X-Gm-Message-State: AOAM532p7tplJdcHBt7IZRt2IKxt2Tl3yOT7blRDRuo+spxH2V0bn4pd jcZrh5AMliszDg+IcucqiW8= X-Google-Smtp-Source: ABdhPJxvP333YF/+k+Gwi+3JjsWYJs7f8n+Vq0nNrbugFBnqg0LfQdeG/4azufOrmOGtRssqLNnT9Q== X-Received: by 2002:a50:f392:: with SMTP id g18mr4798636edm.140.1605303581324; Fri, 13 Nov 2020 13:39:41 -0800 (PST) Received: from andrea (host-82-51-6-75.retail.telecomitalia.it. [82.51.6.75]) by smtp.gmail.com with ESMTPSA id p26sm3095853eja.13.2020.11.13.13.39.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Nov 2020 13:39:40 -0800 (PST) Date: Fri, 13 Nov 2020 22:39:33 +0100 From: Andrea Parri To: Wei Liu Cc: linux-kernel@vger.kernel.org, "K . Y . Srinivasan" , Haiyang Zhang , Stephen Hemminger , linux-hyperv@vger.kernel.org, Andres Beltran , Michael Kelley , Saruhan Karademir , Juan Vazquez , "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org Subject: Re: [PATCH v9 2/3] scsi: storvsc: Use vmbus_requestor to generate transaction IDs for VMBus hardening Message-ID: <20201113213933.GA4937@andrea> References: <20201109100402.8946-1-parri.andrea@gmail.com> <20201109100402.8946-3-parri.andrea@gmail.com> <20201113113327.dmium67e32iadqbz@liuwe-devbox-debian-v2> <20201113185424.ujdfx6ot7siqr5qh@liuwe-devbox-debian-v2> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201113185424.ujdfx6ot7siqr5qh@liuwe-devbox-debian-v2> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 13, 2020 at 06:54:24PM +0000, Wei Liu wrote: > On Fri, Nov 13, 2020 at 11:33:27AM +0000, Wei Liu wrote: > > On Mon, Nov 09, 2020 at 11:04:01AM +0100, Andrea Parri (Microsoft) wrote: > > > From: Andres Beltran > > > > > > Currently, pointers to guest memory are passed to Hyper-V as > > > transaction IDs in storvsc. In the face of errors or malicious > > > behavior in Hyper-V, storvsc should not expose or trust the transaction > > > IDs returned by Hyper-V to be valid guest memory addresses. Instead, > > > use small integers generated by vmbus_requestor as requests > > > (transaction) IDs. > > > > > > Signed-off-by: Andres Beltran > > > Co-developed-by: Andrea Parri (Microsoft) > > > Signed-off-by: Andrea Parri (Microsoft) > > > Reviewed-by: Michael Kelley > > > Cc: "James E.J. Bottomley" > > > Cc: "Martin K. Petersen" > > > Cc: linux-scsi@vger.kernel.org > > > > Reviewed-by: Wei Liu > > Martin already gave his ack back in July. I guess nothing substantial > changed so it should have been carried over? The only change here happened in v7 and consisted in moving the allocation of the request IDs from the VSC code down into the core vmbus_sendpacket()&co functions. As mentioned in v7 cover letter, this change was applied to ensure that the allocation in question is performed after the packet is copied into the ring buffer. On a positive note, this change greatly reduced the diff of this and the following (NetVSC) patches. Andrea