* [PATCH -next] cxgb4: Remove unused variable ret
@ 2020-11-14 9:38 Zou Wei
2020-11-14 17:50 ` Jakub Kicinski
0 siblings, 1 reply; 2+ messages in thread
From: Zou Wei @ 2020-11-14 9:38 UTC (permalink / raw)
To: vishal, davem, kuba; +Cc: netdev, linux-kernel, Zou Wei
This patch fixes below warning reported by coccicheck:
./drivers/net/ethernet/chelsio/cxgb4/t4_hw.c:3284:5-8: Unneeded variable: "ret". Return "0" on line 3301
Signed-off-by: Zou Wei <zou_wei@huawei.com>
---
drivers/net/ethernet/chelsio/cxgb4/t4_hw.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/chelsio/cxgb4/t4_hw.c b/drivers/net/ethernet/chelsio/cxgb4/t4_hw.c
index 98d01a7..426d15e 100644
--- a/drivers/net/ethernet/chelsio/cxgb4/t4_hw.c
+++ b/drivers/net/ethernet/chelsio/cxgb4/t4_hw.c
@@ -3281,8 +3281,6 @@ int t4_get_scfg_version(struct adapter *adapter, u32 *vers)
*/
int t4_get_version_info(struct adapter *adapter)
{
- int ret = 0;
-
#define FIRST_RET(__getvinfo) \
do { \
int __ret = __getvinfo; \
@@ -3298,7 +3296,7 @@ int t4_get_version_info(struct adapter *adapter)
FIRST_RET(t4_get_vpd_version(adapter, &adapter->params.vpd_vers));
#undef FIRST_RET
- return ret;
+ return 0;
}
/**
--
2.6.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] cxgb4: Remove unused variable ret
2020-11-14 9:38 [PATCH -next] cxgb4: Remove unused variable ret Zou Wei
@ 2020-11-14 17:50 ` Jakub Kicinski
0 siblings, 0 replies; 2+ messages in thread
From: Jakub Kicinski @ 2020-11-14 17:50 UTC (permalink / raw)
To: Zou Wei; +Cc: vishal, davem, netdev, linux-kernel
On Sat, 14 Nov 2020 17:38:26 +0800 Zou Wei wrote:
> This patch fixes below warning reported by coccicheck:
>
> ./drivers/net/ethernet/chelsio/cxgb4/t4_hw.c:3284:5-8: Unneeded variable: "ret". Return "0" on line 3301
>
> Signed-off-by: Zou Wei <zou_wei@huawei.com>
Some macro uses it implicitly, this breaks the build.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-11-14 17:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-14 9:38 [PATCH -next] cxgb4: Remove unused variable ret Zou Wei
2020-11-14 17:50 ` Jakub Kicinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).